Skip to contentSkip to conversation

cmem: Adding New recipe for cmem

PATCH Superseded Sam Nelson 3 participants 4 messages Dec 18, 2013

lore
Share & tools
lore

Sam Nelson

author
#0 lore raw

PATCH v4 1/1 cmem: Adding New recipe for cmem

- Cmem module is used for user space contiguous memory alloation

---
 recipes-bsp/cmem/cmem-mod_git.bb |    4 ++--
 recipes-bsp/cmem/cmem.inc        |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
recipes-bsp/cmem/cmem-mod_git.bb +2 -2
index a072f77..bbd81d4 100644
@@ -13,13 +13,13 @@ inherit module
 do_compile () {
     unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
     cd ${S}
-    make -f lu.mak module_clean
+    make -f lu.mak modules_clean
     make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PREFIX=${CROSS_COMPILE}
 }
 
 do_install () {
     unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
     cd ${S}
-    make -f lu.mak module_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
+    make -f lu.mak modules_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
 }
 
recipes-bsp/cmem/cmem.inc +2 -2
index 094b2dc..b1f441a 100644
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://include/ti/cmem.h;beginline=1;endline=30;md5=b86138d4028fb8310b3b983024edc620"
 
 BRANCH ?= "master"
-# This corresponds to version 4.00.00.06
-SRCREV = "c2cf2406702bcb889c10d0e6e7d298ba7b84ae7d"
+# This corresponds to version 4.00.01.08
+SRCREV = "0b68dfe9f155a1978cdb2178e052dc0d6f1e705b"
 
 SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}"
Signature · 1 line
1.7.9.5
#1 lore raw

Sam,

Can you please include patch version notes in the patch? i.e.

---
Fixed in Version 4:
* Item 1
* Item 2

---
 recipes-bsp/cmem/cmem-mod_git.bb |    4 ++--
 recipes-bsp/cmem/cmem.inc        |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Without that reviewing multiple patch revisions, particularly over time is extremely difficult.

Sincerely,
Chase Maupin
Integration Team Manager
Linux Core Product Development
e-mail: [email protected]
phone: (214) 567-2950

For support:
Forums - http://community.ti.com/forums/
Wiki - http://wiki.davincidsp.com/

Quoted 68 lines

-----Original Message-----
From: [email protected] [mailto:meta-ti- [email protected]] On Behalf Of Nelson, Sam
Sent: Wednesday, December 18, 2013 3:25 PM
To: [email protected]
Subject: [meta-ti] [PATCH v4] cmem: Adding New recipe for cmem

- Cmem module is used for user space contiguous memory alloation

---

recipes-bsp/cmem/cmem-mod_git.bb |    4 ++--
recipes-bsp/cmem/cmem.inc        |    4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
recipes- renamed from recipes-bsp/cmem/cmem-mod_git.bb +0 -0

bsp/cmem/cmem-mod_git.bb
index a072f77..bbd81d4 100644

recipes-bsp/cmem/cmem-mod_git.bb +1 -2
@@ -13,13 +13,13 @@ inherit module
 do_compile () {
    unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
    cd ${S}
-    make -f lu.mak module_clean
+    make -f lu.mak modules_clean
    make -f lu.mak module
 KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR}
 TOOLCHAIN_PREFIX=${CROSS_COMPILE}
 }
 
 do_install () {
    unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
    cd ${S}
-    make -f lu.mak module_install

KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
+ make -f lu.mak modules_install
KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
}

recipes-bsp/cmem/cmem.inc +0 -0
index 094b2dc..b1f441a 100644
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"

LIC_FILES_CHKSUM = "file://include/ti/cmem.h;beginline=1;endline=30;md5=b86138d4028fb 8310b3b983024edc620"

BRANCH ?= "master"

recipes-bsp/cmem/cmem.inc +2 -2
-# This corresponds to version 4.00.00.06
-SRCREV = "c2cf2406702bcb889c10d0e6e7d298ba7b84ae7d"
+# This corresponds to version 4.00.01.08
+SRCREV = "0b68dfe9f155a1978cdb2178e052dc0d6f1e705b"

SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" --
1.7.9.5

_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

#2 lore raw

Sorry, this is a fresh commit for meta-ti. I will resubmit again as the whole patch. With regards,
sam

Quoted 105 lines

-----Original Message-----
From: Maupin, Chase
Sent: Wednesday, December 18, 2013 5:09 PM
To: Nelson, Sam; [email protected]
Subject: RE: [meta-ti] [PATCH v4] cmem: Adding New recipe for cmem

Sam,

Can you please include patch version notes in the patch? i.e.

---
Fixed in Version 4:
* Item 1
* Item 2

---
 recipes-bsp/cmem/cmem-mod_git.bb |    4 ++--
 recipes-bsp/cmem/cmem.inc        |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Without that reviewing multiple patch revisions, particularly over time is extremely difficult.

Sincerely,
Chase Maupin
Integration Team Manager
Linux Core Product Development
e-mail: [email protected]
phone: (214) 567-2950

For support:
Forums - http://community.ti.com/forums/
Wiki - http://wiki.davincidsp.com/

Quoted 68 lines

-----Original Message-----
From: [email protected] [mailto:meta-ti- [email protected]] On Behalf Of Nelson, Sam
Sent: Wednesday, December 18, 2013 3:25 PM
To: [email protected]
Subject: [meta-ti] [PATCH v4] cmem: Adding New recipe for cmem

- Cmem module is used for user space contiguous memory alloation

---

recipes-bsp/cmem/cmem-mod_git.bb |    4 ++--
recipes-bsp/cmem/cmem.inc        |    4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
recipes- renamed from recipes-bsp/cmem/cmem-mod_git.bb +0 -0

bsp/cmem/cmem-mod_git.bb
index a072f77..bbd81d4 100644

recipes-bsp/cmem/cmem-mod_git.bb +1 -2
@@ -13,13 +13,13 @@ inherit module
 do_compile () {
    unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
    cd ${S}
-    make -f lu.mak module_clean
+    make -f lu.mak modules_clean
    make -f lu.mak module
 KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR}
 TOOLCHAIN_PREFIX=${CROSS_COMPILE}
 }
 
 do_install () {
    unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
    cd ${S}
-    make -f lu.mak module_install

KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
+ make -f lu.mak modules_install
KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
}

recipes-bsp/cmem/cmem.inc +0 -0
index 094b2dc..b1f441a 100644
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"

LIC_FILES_CHKSUM = "file://include/ti/cmem.h;beginline=1;endline=30;md5=b86138d4028fb 8310b3b983024edc620"

BRANCH ?= "master"

recipes-bsp/cmem/cmem.inc +2 -2
-# This corresponds to version 4.00.00.06
-SRCREV = "c2cf2406702bcb889c10d0e6e7d298ba7b84ae7d"
+# This corresponds to version 4.00.01.08
+SRCREV = "0b68dfe9f155a1978cdb2178e052dc0d6f1e705b"

SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}" --
1.7.9.5

_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti

#3 lore raw
In reply to Sam Nelson

Sam,

Your last email to the list from few days ealier also worked, I just didn't have time to reply.

As of the patch itself, it is based on a previous commit with cmem, which never made it to meta-ti, so please make sure all the dependencies are met.

Signature · 1 line
Denys
Quoted 49 lines · Sam Nelson

- Cmem module is used for user space contiguous memory alloation

---
 recipes-bsp/cmem/cmem-mod_git.bb |    4 ++--
 recipes-bsp/cmem/cmem.inc        |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
recipes-bsp/cmem/cmem-mod_git.bb +2 -2
index a072f77..bbd81d4 100644
@@ -13,13 +13,13 @@ inherit module
 do_compile () {
     unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
     cd ${S}
-    make -f lu.mak module_clean
+    make -f lu.mak modules_clean
     make -f lu.mak module KERNEL_INSTALL_DIR=${STAGING_KERNEL_DIR} TOOLCHAIN_PREFIX=${CROSS_COMPILE}
 }
 
 do_install () {
     unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
     cd ${S}
-    make -f lu.mak module_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
+    make -f lu.mak modules_install KERNEL_INSTALL_DIR="${STAGING_KERNEL_DIR}" EXEC_DIR="${D}/lib/modules/${KERNEL_VERSION}/extra" INSTALL_MOD_PATH="${D}"
 }
 
recipes-bsp/cmem/cmem.inc +2 -2
index 094b2dc..b1f441a 100644
@@ -4,7 +4,7 @@ LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://include/ti/cmem.h;beginline=1;endline=30;md5=b86138d4028fb8310b3b983024edc620"
 
 BRANCH ?= "master"
-# This corresponds to version 4.00.00.06
-SRCREV = "c2cf2406702bcb889c10d0e6e7d298ba7b84ae7d"
+# This corresponds to version 4.00.01.08
+SRCREV = "0b68dfe9f155a1978cdb2178e052dc0d6f1e705b"
 
 SRC_URI = "git://git.ti.com/ipc/ludev.git;protocol=git;branch=${BRANCH}"
Signature · 6 lines
1.7.9.5

_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti