pull request [net]: batman-adv 2013-12-19
Subsystems (3)
Hello David,
this is a pull request intended for net.
Patch 1 is fixing a bug that is present in the batman-adv code since a while. The bug prevents a batman-adv encapsulated packet from being correctly processed by "Netfilter Bridge" twice. In particular a packet that first enters a bridge with the batman-adv header and then enters another bridge after the header has been removed is improperly processed. The problem is due to the skb->nf_bridge member not being cleaned when the batman-adv header is removed.
This patch takes care of properly releasing the nf_bridge field at the right time (like all the other tunneling protocol do).
** Please, enqueue this patch for stable.
Patches from 2 to 6 take care of reshaping the packet layout a little bit to make sure that all the structures we use for sending messages have size multiple of 4 (or 2 when pack(2) is used).
This solves the problem raised by Russel King about the static checks failure when compiling the module on the ARM architecture.
Please pull or let me know of any problem.
Thank you,
Antonio
The following changes since commit 58a4782449c5882f61882396ef18cc34c7dc1269:
ipv6: sit: update mtu check to take care of gso packets (2013-12-18 17:55:24 -0500)
are available in the git repository at:
git://git.open-mesh.org/linux-merge.git tags/batman-adv-fix-for-davem
for you to fetch changes up to 128cfa6a586154581ce1b891baf929810117a82a:
batman-adv: fix alignment for batadv_tvlv_tt_change (2013-12-19 00:27:24 +0100)
----------------------------------------------------------------
Included changes:
- release skb->nf_bridge when removing the batman-adv header from an incoming packet. This prevents netfilter bridge from being fooled when the same packet enters a bridge twice (or more): the first time within the batman-adv header and the second time without.
- adjust the packet layout to prevent any architecture from adding padding bytes. All the structs sent over the wire now have size multiple of 4bytes (unless pack(2) is used).
----------------------------------------------------------------
Antonio Quartulli (3):
batman-adv: free nf_bridge member on locally delivered skb
batman-adv: fix size of batadv_icmp_header
batman-adv: fix alignment for batadv_tvlv_tt_change
Simon Wunderlich (3):
batman-adv: fix alignment for batadv_coded_packet
batman-adv: fix header alignment by unrolling batadv_header
batman-adv: fix size of batadv_bla_claim_dst
net/batman-adv/bat_iv_ogm.c | 36 +++++----- net/batman-adv/distributed-arp-table.c | 6 +- net/batman-adv/fragmentation.c | 8 +-- net/batman-adv/icmp_socket.c | 6 +- net/batman-adv/main.c | 16 ++--- net/batman-adv/network-coding.c | 22 +++--- net/batman-adv/packet.h | 124 +++++++++++++++++++++++++-------- net/batman-adv/routing.c | 30 ++++---- net/batman-adv/send.c | 10 +-- net/batman-adv/soft-interface.c | 19 +++-- net/batman-adv/soft-interface.h | 16 +++++ net/batman-adv/translation-table.c | 6 +- 12 files changed, 195 insertions(+), 104 deletions(-)
PATCH 1/6 batman-adv: free nf_bridge member on locally delivered skb
If an interface enslaved into batman-adv is a bridge (or a virtual interface built on top of a bridge) the nf_bridge member of the skbs reaching the soft-interface is filled with the state about "netfilter bridge" operations.
Then, if one of such skbs is locally delivered, the nf_bridge member should be cleaned up to avoid that the old state could mess up with other "netfilter bridge" operations when entering a second bridge.
This is needed because batman-adv is an encapsulation protocol.
However at the moment skb->nf_bridge is not released at all leading to bogus "netfilter bridge" behaviours. Fix this by releasing skb->nf_bridge before an skb gets delivered to the upper layer in interface_rx().
--- net/batman-adv/soft-interface.c | 8 ++++++++ net/batman-adv/soft-interface.h | 16 ++++++++++++++++ 2 files changed, 24 insertions(+)
net/batman-adv/soft-interface.c +8 -0
@@ -392,6 +392,14 @@ void batadv_interface_rx(struct net_device *soft_iface, vid)) goto dropped; +/* Clean the netfilter state before delivering the skb. +* This packet may have traversed a bridge when it was encapsulated into +* the batman header. Now that the header has been removed, the +* netfilter state must be cleaned up to avoid to mess up with a +* possible second bridge +*/ +batadv_nf_bridge_skb_free (skb); +netif_rx (skb); goto out;
net/batman-adv/soft-interface.h +16 -0
@@ -33,4 +33,20 @@ void batadv_softif_vlan_free_ref(struct batadv_softif_vlan *softif_vlan);struct batadv_softif_vlan *batadv_softif_vlan_get (struct batadv_priv *bat_priv,unsigned short vid); +#ifdef CONFIG_BRIDGE_NETFILTER +/** +* batadv_nf_bridge_skb_free - clean the NF bridge data in an skb +* @skb: the skb which nf data has to be free'd +*/ +static inline void batadv_nf_bridge_skb_free (struct sk_buff *skb) +{ +nf_bridge_put (skb->nf_bridge); + skb->nf_bridge =NULL ; +} +#else +static inline void batadv_nf_bridge_skb_free (struct sk_buff *skb) +{ +} +#endif /* CONFIG_BRIDGE_NETFILTER */ +#endif /* _NET_BATMAN_ADV_SOFT_INTERFACE_H_ */
Signature · 1 line
1.8.5.1
David Miller
maintainerRe: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb
From: Antonio Quartulli <[email protected]>
Date: Thu, 19 Dec 2013 01:15:27 +0100
Quoted 12 lines
If an interface enslaved into batman-adv is a bridge (or a virtual interface built on top of a bridge) the
nf_bridgemember of the skbs reaching the soft-interface is filled with the state about "netfilter bridge" operations.Then, if one of such skbs is locally delivered, the
nf_bridgemember should be cleaned up to avoid that the old state could mess up with other "netfilter bridge" operations when entering a second bridge.
This is needed because batman-adv is an encapsulation protocol.
Quoted 7 lines
However at the moment
skb->nf_bridgeis not released at all leading to bogus "netfilter bridge" behaviours. Fix this by releasingskb->nf_bridgebefore an skb gets delivered to the upper layer ininterface_rx().Signed-off-by Antonio Quartulli <[email protected]>Signed-off-by Marek Lindner <[email protected]>
See nf_reset() and skb_scrub_packet(). Do not reinvent the wheel.
Thank you.
Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb
Quoted 4 lines · David Miller
See
nf_reset()andskb_scrub_packet(). Do not reinvent the wheel.
Hello David,
after some discussion[1] the suggestion was to keep the behaviour as less intrusive as possible, thus I avoided any nf_reset() (and similar) and I directly wrote my function that calls nf_bridge_put() only.
Do you think it is safe to use nf_reset() directly?
Pablo was worried about "strange" user configurations that may break because of this.
(Even if somebody may argue that in this case user configurations are probably broken, not the kernel :-) ).
Regards,
[1] http://thread.gmane.org/gmane.linux.network/286965/focus=287502
Signature · 1 line
Antonio Quartulli
David Miller
maintainerRe: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb
From: Antonio Quartulli <[email protected]>
Date: Mon, 23 Dec 2013 01:11:10 +0100
Quoted 1 line
Do you think it is safe to use
nf_reset()directly?
If you do not know, you probably should not be making these changes at all :-)
There is zero reason for your protocol layer to have an ad-hoc private SKB netfilter state reset function that touches internals in this way.
At least with the generic helpers, we know the side effects and the function is well known to other developers.
A message that is not in the archive (sent off-list or not yet received): 20131222.191622.118900475665948342.davem-fT/PcQaiUtIeIZ0/[email protected]
Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb
Quoted 3 lines · David Miller
There is zero reason for your protocol layer to have an ad-hoc private SKB netfilter state reset function that touches internals in this way.
agreed.
Quoted 3 lines
At least with the generic helpers, we know the side effects and the function is well known to other developers.
Ok, I'll do it the clean way and resend the pull request.
Thanks!
Signature · 1 line
Antonio Quartulli
PATCH 2/6 batman-adv: fix alignment for batadv_coded_packet
In reply to Antonio QuartulliFrom: Simon Wunderlich <[email protected]>
The compiler may decide to pad the structure, and then it does not have the expected size of 46 byte. Fix this by moving it in the pragma pack(2) part of the code.
--- net/batman-adv/packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/batman-adv/packet.h +2 -2
@@ -315,8 +315,6 @@ struct batadv_bcast_packet {*/ }; -#pragma pack() -/** * struct batadv_coded_packet - network coded packet * @header: common batman packet header and ttl of first included packet
@@ -349,6 +347,8 @@ struct batadv_coded_packet {__be16 coded_len; }; +#pragma pack() +/** * struct batadv_unicast_tvlv - generic unicast packet with tvlv payload * @header: common batman packet header
Signature · 1 line
1.8.5.1
PATCH 3/6 batman-adv: fix header alignment by unrolling batadv_header
In reply to Antonio QuartulliFrom: Simon Wunderlich <[email protected]>
The size of the batadv_header of 3 is problematic on some architectures which automatically pad all structures to a 32 bit boundary. To not lose performance by packing this struct, better embed it into the various host structures.
--- net/batman-adv/bat_iv_ogm.c | 36 ++++++++--------- net/batman-adv/distributed-arp-table.c | 6 +-- net/batman-adv/fragmentation.c | 8 ++-- net/batman-adv/icmp_socket.c | 6 +-- net/batman-adv/main.c | 12 +++--- net/batman-adv/network-coding.c | 22 +++++----- net/batman-adv/packet.h | 74 ++++++++++++++++++++++++---------- net/batman-adv/routing.c | 18 ++++----- net/batman-adv/send.c | 10 ++--- net/batman-adv/soft-interface.c | 11 ++--- 10 files changed, 118 insertions(+), 85 deletions(-)
net/batman-adv/bat_iv_ogm.c +18 -18
@@ -307,9 +307,9 @@ static int batadv_iv_ogm_iface_enable(struct batadv_hard_iface *hard_iface) hard_iface->bat_iv.ogm_buff = ogm_buff; batadv_ogm_packet = (struct batadv_ogm_packet *)ogm_buff; - batadv_ogm_packet->header.packet_type =BATADV_IV_OGM ; - batadv_ogm_packet->header.version =BATADV_COMPAT_VERSION ; - batadv_ogm_packet->header.ttl =2 ; + batadv_ogm_packet->packet_type =BATADV_IV_OGM ; + batadv_ogm_packet->version =BATADV_COMPAT_VERSION ; + batadv_ogm_packet->ttl =2 ; batadv_ogm_packet->flags =BATADV_NO_FLAGS ; batadv_ogm_packet->reserved =0 ; batadv_ogm_packet->tq =BATADV_TQ_MAX_VALUE ;
@@ -346,7 +346,7 @@ batadv_iv_ogm_primary_iface_set(struct batadv_hard_iface *hard_iface) batadv_ogm_packet = (struct batadv_ogm_packet *)ogm_buff; batadv_ogm_packet->flags =BATADV_PRIMARIES_FIRST_HOP ; - batadv_ogm_packet->header.ttl =BATADV_TTL ; + batadv_ogm_packet->ttl =BATADV_TTL ; }/* when do we schedule our own ogm to be sent */
@@ -435,7 +435,7 @@ static void batadv_iv_ogm_send_to_if(struct batadv_forw_packet *forw_packet, fwd_str, (packet_num >0 ?"aggregated " :"" ), batadv_ogm_packet->orig,ntohl (batadv_ogm_packet->seqno), - batadv_ogm_packet->tq, batadv_ogm_packet->header.ttl, + batadv_ogm_packet->tq, batadv_ogm_packet->ttl, (batadv_ogm_packet->flags &BATADV_DIRECTLINK ?"on" :"off" ), hard_iface->net_dev->name,
@@ -491,7 +491,7 @@ static void batadv_iv_ogm_emit(struct batadv_forw_packet *forw_packet)/* multihomed peer assumed * non-primary OGMs are only broadcasted on their interface */ -if ((directlink && (batadv_ogm_packet->header.ttl ==1 )) || +if ((directlink && (batadv_ogm_packet->ttl ==1 )) || (forw_packet->own && (forw_packet->if_incoming != primary_if))) {/* FIXME: what about aggregated packets ? */ batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
@@ -499,7 +499,7 @@ static void batadv_iv_ogm_emit(struct batadv_forw_packet *forw_packet) (forw_packet->own ?"Sending own" :"Forwarding" ), batadv_ogm_packet->orig,ntohl (batadv_ogm_packet->seqno), - batadv_ogm_packet->header.ttl, + batadv_ogm_packet->ttl, forw_packet->if_incoming->net_dev->name, forw_packet->if_incoming->net_dev->dev_addr);
@@ -572,7 +572,7 @@ batadv_iv_ogm_can_aggregate(const struct batadv_ogm_packet *new_bat_ogm_packet,*/ if ((!directlink) && (!(batadv_ogm_packet->flags & BATADV_DIRECTLINK)) && - (batadv_ogm_packet->header.ttl != 1) && + (batadv_ogm_packet->ttl != 1) &&/* own packets originating non-primary * interfaces leave only that interface
@@ -587,7 +587,7 @@ batadv_iv_ogm_can_aggregate(const struct batadv_ogm_packet *new_bat_ogm_packet,* interface only - we still can aggregate */ if ((directlink) && - (new_bat_ogm_packet->header.ttl == 1) && + (new_bat_ogm_packet->ttl == 1) && (forw_packet->if_incoming == if_incoming) &&/* packets from direct neighbors or
@@ -778,7 +778,7 @@ static void batadv_iv_ogm_forward(struct batadv_orig_node *orig_node,struct batadv_priv *bat_priv =netdev_priv (if_incoming->soft_iface);uint16_t tvlv_len; -if (batadv_ogm_packet->header.ttl <=1 ) { +if (batadv_ogm_packet->ttl <=1 ) {batadv_dbg (BATADV_DBG_BATMAN , bat_priv,"ttl exceeded\n" );return ; }
@@ -798,7 +798,7 @@ static void batadv_iv_ogm_forward(struct batadv_orig_node *orig_node, tvlv_len =ntohs (batadv_ogm_packet->tvlv_len); - batadv_ogm_packet->header.ttl--; + batadv_ogm_packet->ttl--;memcpy (batadv_ogm_packet->prev_sender, ethhdr->h_source,ETH_ALEN );/* apply hop penalty */
@@ -807,7 +807,7 @@ static void batadv_iv_ogm_forward(struct batadv_orig_node *orig_node,batadv_dbg (BATADV_DBG_BATMAN , bat_priv,"Forwarding packet: tq: %i, ttl: %i\n" , - batadv_ogm_packet->tq, batadv_ogm_packet->header.ttl); + batadv_ogm_packet->tq, batadv_ogm_packet->ttl);/* switch of primaries first hop flag when forwarding */ batadv_ogm_packet->flags &= ~BATADV_PRIMARIES_FIRST_HOP ;
@@ -972,8 +972,8 @@ batadv_iv_ogm_orig_update(struct batadv_priv *bat_priv,spin_unlock_bh (&neigh_node->bat_iv.lq_update_lock);if (dup_status ==BATADV_NO_DUP ) { - orig_node->last_ttl = batadv_ogm_packet->header.ttl; - neigh_node->last_ttl = batadv_ogm_packet->header.ttl; + orig_node->last_ttl = batadv_ogm_packet->ttl; + neigh_node->last_ttl = batadv_ogm_packet->ttl; }batadv_bonding_candidate_add (bat_priv, orig_node, neigh_node);
@@ -1247,7 +1247,7 @@ static void batadv_iv_ogm_process(const struct ethhdr *ethhdr,* packet in an aggregation. Here we expect that the padding * is always zero (or not 0x01) */ -if (batadv_ogm_packet->header.packet_type !=BATADV_IV_OGM ) +if (batadv_ogm_packet->packet_type !=BATADV_IV_OGM )return ;/* could be changed by schedule_own_packet() */
@@ -1267,8 +1267,8 @@ static void batadv_iv_ogm_process(const struct ethhdr *ethhdr, if_incoming->net_dev->dev_addr, batadv_ogm_packet->orig, batadv_ogm_packet->prev_sender,ntohl (batadv_ogm_packet->seqno), batadv_ogm_packet->tq, - batadv_ogm_packet->header.ttl, - batadv_ogm_packet->header.version, has_directlink_flag); + batadv_ogm_packet->ttl, + batadv_ogm_packet->version, has_directlink_flag);rcu_read_lock ();list_for_each_entry_rcu (hard_iface, &batadv_hardif_list, list) {
@@ -1433,7 +1433,7 @@ static void batadv_iv_ogm_process(const struct ethhdr *ethhdr,* seqno and similar ttl as the non-duplicate */ sameseq = orig_node->last_real_seqno ==ntohl (batadv_ogm_packet->seqno); - similar_ttl = orig_node->last_ttl -3 <= batadv_ogm_packet->header.ttl; + similar_ttl = orig_node->last_ttl -3 <= batadv_ogm_packet->ttl;if (is_bidirect && ((dup_status ==BATADV_NO_DUP ) || (sameseq && similar_ttl))) batadv_iv_ogm_orig_update(bat_priv, orig_node, ethhdr,
net/batman-adv/distributed-arp-table.c +3 -3
@@ -349,7 +349,7 @@ static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb, unicast_4addr_packet = (struct batadv_unicast_4addr_packet *)skb->data; -switch (unicast_4addr_packet->u.header.packet_type) { +switch (unicast_4addr_packet->u.packet_type) {case BATADV_UNICAST :batadv_dbg (BATADV_DBG_DAT , bat_priv,"* encapsulated within a UNICAST packet\n" );
@@ -374,7 +374,7 @@ static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb,break ;default :batadv_dbg (BATADV_DBG_DAT , bat_priv,"* type: Unknown (%u)!\n" , - unicast_4addr_packet->u.header.packet_type); + unicast_4addr_packet->u.packet_type); }break ;case BATADV_BCAST :
@@ -387,7 +387,7 @@ static void batadv_dbg_arp(struct batadv_priv *bat_priv, struct sk_buff *skb,default :batadv_dbg (BATADV_DBG_DAT , bat_priv,"* encapsulated within an unknown packet type (0x%x)\n" , - unicast_4addr_packet->u.header.packet_type); + unicast_4addr_packet->u.packet_type); } }
net/batman-adv/fragmentation.c +4 -4
@@ -355,7 +355,7 @@ bool batadv_frag_skb_fwd(struct sk_buff *skb,batadv_add_counter (bat_priv,BATADV_CNT_FRAG_FWD_BYTES , skb->len +ETH_HLEN ); - packet->header.ttl--; + packet->ttl--;batadv_send_skb_packet (skb, neigh_node->if_incoming, neigh_node->addr); ret = true;
@@ -444,9 +444,9 @@ bool batadv_frag_send_packet(struct sk_buff *skb, goto out_err;/* Create one header to be copied to all fragments */ - frag_header.header.packet_type =BATADV_UNICAST_FRAG ; - frag_header.header.version =BATADV_COMPAT_VERSION ; - frag_header.header.ttl =BATADV_TTL ; + frag_header.packet_type =BATADV_UNICAST_FRAG ; + frag_header.version =BATADV_COMPAT_VERSION ; + frag_header.ttl =BATADV_TTL ; frag_header.seqno =htons (atomic_inc_return (&bat_priv->frag_seqno)); frag_header.reserved =0 ; frag_header.no =0 ;
net/batman-adv/icmp_socket.c +3 -3
@@ -194,7 +194,7 @@ static ssize_t batadv_socket_write(struct file *file, const char __user *buff, goto free_skb; } -if (icmp_header->header.packet_type !=BATADV_ICMP ) { +if (icmp_header->packet_type !=BATADV_ICMP ) {batadv_dbg (BATADV_DBG_BATMAN , bat_priv,"Error - can't send packet from char device: got bogus packet type (expected: BAT_ICMP)\n" ); len = -EINVAL ;
@@ -243,9 +243,9 @@ static ssize_t batadv_socket_write(struct file *file, const char __user *buff, icmp_header->uid = socket_client->index; -if (icmp_header->header.version !=BATADV_COMPAT_VERSION ) { +if (icmp_header->version !=BATADV_COMPAT_VERSION ) { icmp_header->msg_type =BATADV_PARAMETER_PROBLEM ; - icmp_header->header.version =BATADV_COMPAT_VERSION ; + icmp_header->version =BATADV_COMPAT_VERSION ;batadv_socket_add_packet (socket_client, icmp_header, packet_len); goto free_skb;
net/batman-adv/main.c +6 -6
@@ -383,17 +383,17 @@ int batadv_batman_skb_recv(struct sk_buff *skb, struct net_device *dev, batadv_ogm_packet = (struct batadv_ogm_packet *)skb->data; -if (batadv_ogm_packet->header.version !=BATADV_COMPAT_VERSION ) { +if (batadv_ogm_packet->version !=BATADV_COMPAT_VERSION ) {batadv_dbg (BATADV_DBG_BATMAN , bat_priv,"Drop packet: incompatible batman version (%i)\n" , - batadv_ogm_packet->header.version); + batadv_ogm_packet->version); goto err_free; }/* all receive handlers return whether they received or reused * the supplied skb. if not, we have to free the skb. */ - idx = batadv_ogm_packet->header.packet_type; + idx = batadv_ogm_packet->packet_type; ret = (*batadv_rx_handler[idx])(skb, hard_iface);if (ret ==NET_RX_DROP )
@@ -1119,9 +1119,9 @@ void batadv_tvlv_unicast_send(struct batadv_priv *bat_priv, uint8_t *src,skb_reserve (skb,ETH_HLEN ); tvlv_buff =skb_put (skb,sizeof (*unicast_tvlv_packet) + tvlv_len); unicast_tvlv_packet = (struct batadv_unicast_tvlv_packet *)tvlv_buff; - unicast_tvlv_packet->header.packet_type =BATADV_UNICAST_TVLV ; - unicast_tvlv_packet->header.version =BATADV_COMPAT_VERSION ; - unicast_tvlv_packet->header.ttl =BATADV_TTL ; + unicast_tvlv_packet->packet_type =BATADV_UNICAST_TVLV ; + unicast_tvlv_packet->version =BATADV_COMPAT_VERSION ; + unicast_tvlv_packet->ttl =BATADV_TTL ; unicast_tvlv_packet->reserved =0 ; unicast_tvlv_packet->tvlv_len =htons (tvlv_len); unicast_tvlv_packet->align =0 ;
net/batman-adv/network-coding.c +11 -11
@@ -722,7 +722,7 @@ static bool batadv_can_nc_with_orig(struct batadv_priv *bat_priv, {if (orig_node->last_real_seqno !=ntohl (ogm_packet->seqno))return false; -if (orig_node->last_ttl != ogm_packet->header.ttl +1 ) +if (orig_node->last_ttl != ogm_packet->ttl +1 )return false;if (!batadv_compare_eth (ogm_packet->orig, ogm_packet->prev_sender))return false;
@@ -1082,9 +1082,9 @@ static bool batadv_nc_code_packets(struct batadv_priv *bat_priv, coded_packet = (struct batadv_coded_packet *)skb_dest->data;skb_reset_mac_header (skb_dest); - coded_packet->header.packet_type =BATADV_CODED ; - coded_packet->header.version =BATADV_COMPAT_VERSION ; - coded_packet->header.ttl = packet1->header.ttl; + coded_packet->packet_type =BATADV_CODED ; + coded_packet->version =BATADV_COMPAT_VERSION ; + coded_packet->ttl = packet1->ttl;/* Info about first unicast packet */ memcpy (coded_packet->first_source, first_source,ETH_ALEN );
@@ -1097,7 +1097,7 @@ static bool batadv_nc_code_packets(struct batadv_priv *bat_priv,memcpy (coded_packet->second_source, second_source,ETH_ALEN );memcpy (coded_packet->second_orig_dest, packet2->dest,ETH_ALEN ); coded_packet->second_crc = packet_id2; - coded_packet->second_ttl = packet2->header.ttl; + coded_packet->second_ttl = packet2->ttl; coded_packet->second_ttvn = packet2->ttvn; coded_packet->coded_len =htons (coding_len);
@@ -1452,7 +1452,7 @@ bool batadv_nc_skb_forward(struct sk_buff *skb,/* We only handle unicast packets */ payload =skb_network_header (skb); packet = (struct batadv_unicast_packet *)payload; -if (packet->header.packet_type !=BATADV_UNICAST ) +if (packet->packet_type !=BATADV_UNICAST ) goto out;/* Try to find a coding opportunity and send the skb if one is found */
@@ -1505,7 +1505,7 @@ void batadv_nc_skb_store_for_decoding(struct batadv_priv *bat_priv,/* Check for supported packet type */ payload =skb_network_header (skb); packet = (struct batadv_unicast_packet *)payload; -if (packet->header.packet_type !=BATADV_UNICAST ) +if (packet->packet_type !=BATADV_UNICAST ) goto out;/* Find existing nc_path or create a new */
@@ -1623,7 +1623,7 @@ batadv_nc_skb_decode_packet(struct batadv_priv *bat_priv, struct sk_buff *skb, ttvn = coded_packet_tmp.second_ttvn; }else { orig_dest = coded_packet_tmp.first_orig_dest; - ttl = coded_packet_tmp.header.ttl; + ttl = coded_packet_tmp.ttl; ttvn = coded_packet_tmp.first_ttvn; }
@@ -1648,9 +1648,9 @@ batadv_nc_skb_decode_packet(struct batadv_priv *bat_priv, struct sk_buff *skb,/* Create decoded unicast packet */ unicast_packet = (struct batadv_unicast_packet *)skb->data; - unicast_packet->header.packet_type =BATADV_UNICAST ; - unicast_packet->header.version =BATADV_COMPAT_VERSION ; - unicast_packet->header.ttl = ttl; + unicast_packet->packet_type =BATADV_UNICAST ; + unicast_packet->version =BATADV_COMPAT_VERSION ; + unicast_packet->ttl = ttl;memcpy (unicast_packet->dest, orig_dest,ETH_ALEN ); unicast_packet->ttvn = ttvn;
net/batman-adv/packet.h +53 -21
148 lines not on this page · raw message
net/batman-adv/routing.c +9 -9
@@ -308,7 +308,7 @@ static int batadv_recv_my_icmp_packet(struct batadv_priv *bat_priv,memcpy (icmph->dst, icmph->orig,ETH_ALEN );memcpy (icmph->orig, primary_if->net_dev->dev_addr,ETH_ALEN ); icmph->msg_type =BATADV_ECHO_REPLY ; - icmph->header.ttl =BATADV_TTL ; + icmph->ttl =BATADV_TTL ; res =batadv_send_skb_to_orig (skb, orig_node,NULL );if (res !=NET_XMIT_DROP )
@@ -363,7 +363,7 @@ static int batadv_recv_icmp_ttl_exceeded(struct batadv_priv *bat_priv,memcpy (icmp_packet->icmph.orig, primary_if->net_dev->dev_addr,ETH_ALEN ); icmp_packet->icmph.msg_type =BATADV_TTL_EXCEEDED ; - icmp_packet->icmph.header.ttl =BATADV_TTL ; + icmp_packet->icmph.ttl =BATADV_TTL ;if (batadv_send_skb_to_orig (skb, orig_node,NULL ) !=NET_XMIT_DROP ) ret =NET_RX_SUCCESS ;
@@ -434,7 +434,7 @@ int batadv_recv_icmp_packet(struct sk_buff *skb,return batadv_recv_my_icmp_packet (bat_priv, skb);/* TTL exceeded */ -if (icmph->header.ttl <2 ) +if (icmph->ttl <2 )return batadv_recv_icmp_ttl_exceeded (bat_priv, skb);/* get routing information */
@@ -449,7 +449,7 @@ int batadv_recv_icmp_packet(struct sk_buff *skb, icmph = (struct batadv_icmp_header *)skb->data;/* decrement ttl */ - icmph->header.ttl--; + icmph->ttl--;/* route it */ if (batadv_send_skb_to_orig (skb, orig_node, recv_if) !=NET_XMIT_DROP )
@@ -709,7 +709,7 @@ static int batadv_route_unicast_packet(struct sk_buff *skb, unicast_packet = (struct batadv_unicast_packet *)skb->data;/* TTL exceeded */ -if (unicast_packet->header.ttl <2 ) { +if (unicast_packet->ttl <2 ) {pr_debug ("Warning - can't forward unicast packet from %pM to %pM: ttl exceeded\n" , ethhdr->h_source, unicast_packet->dest); goto out;
@@ -727,9 +727,9 @@ static int batadv_route_unicast_packet(struct sk_buff *skb,/* decrement ttl */ unicast_packet = (struct batadv_unicast_packet *)skb->data; - unicast_packet->header.ttl--; + unicast_packet->ttl--; -switch (unicast_packet->header.packet_type) { +switch (unicast_packet->packet_type) {case BATADV_UNICAST_4ADDR : hdr_len =sizeof (struct batadv_unicast_4addr_packet );break ;
@@ -970,7 +970,7 @@ int batadv_recv_unicast_packet(struct sk_buff *skb, unicast_packet = (struct batadv_unicast_packet *)skb->data; unicast_4addr_packet = (struct batadv_unicast_4addr_packet *)skb->data; - is4addr = unicast_packet->header.packet_type ==BATADV_UNICAST_4ADDR ; + is4addr = unicast_packet->packet_type ==BATADV_UNICAST_4ADDR ;/* the caller function should have already pulled 2 bytes */ if (is4addr) hdr_size =sizeof (*unicast_4addr_packet);
@@ -1160,7 +1160,7 @@ int batadv_recv_bcast_packet(struct sk_buff *skb,if (batadv_is_my_mac (bat_priv, bcast_packet->orig)) goto out; -if (bcast_packet->header.ttl <2 ) +if (bcast_packet->ttl <2 ) goto out; orig_node =batadv_orig_hash_find (bat_priv, bcast_packet->orig);
net/batman-adv/send.c +5 -5
@@ -161,11 +161,11 @@ batadv_send_skb_push_fill_unicast(struct sk_buff *skb, int hdr_size,return false; unicast_packet = (struct batadv_unicast_packet *)skb->data; - unicast_packet->header.version =BATADV_COMPAT_VERSION ; + unicast_packet->version =BATADV_COMPAT_VERSION ;/* batman packet type: unicast */ - unicast_packet->header.packet_type =BATADV_UNICAST ; + unicast_packet->packet_type =BATADV_UNICAST ;/* set unicast ttl */ - unicast_packet->header.ttl =BATADV_TTL ; + unicast_packet->ttl =BATADV_TTL ;/* copy the destination for faster routing */ memcpy (unicast_packet->dest, orig_node->orig,ETH_ALEN );/* set the destination tt version number */
@@ -221,7 +221,7 @@ bool batadv_send_skb_prepare_unicast_4addr(struct batadv_priv *bat_priv, goto out; uc_4addr_packet = (struct batadv_unicast_4addr_packet *)skb->data; - uc_4addr_packet->u.header.packet_type =BATADV_UNICAST_4ADDR ; + uc_4addr_packet->u.packet_type =BATADV_UNICAST_4ADDR ;memcpy (uc_4addr_packet->src, primary_if->net_dev->dev_addr,ETH_ALEN ); uc_4addr_packet->subtype = packet_subtype; uc_4addr_packet->reserved =0 ;
@@ -436,7 +436,7 @@ int batadv_add_bcast_packet_to_list(struct batadv_priv *bat_priv,/* as we have a copy now, it is safe to decrease the TTL */ bcast_packet = (struct batadv_bcast_packet *)newskb->data; - bcast_packet->header.ttl--; + bcast_packet->ttl--;skb_reset_mac_header (newskb);
net/batman-adv/soft-interface.c +6 -5
@@ -264,11 +264,11 @@ static int batadv_interface_tx(struct sk_buff *skb, goto dropped; bcast_packet = (struct batadv_bcast_packet *)skb->data; - bcast_packet->header.version =BATADV_COMPAT_VERSION ; - bcast_packet->header.ttl =BATADV_TTL ; + bcast_packet->version =BATADV_COMPAT_VERSION ; + bcast_packet->ttl =BATADV_TTL ;/* batman packet type: broadcast */ - bcast_packet->header.packet_type =BATADV_BCAST ; + bcast_packet->packet_type =BATADV_BCAST ; bcast_packet->reserved =0 ;/* hw address of first interface is the orig mac because only
@@ -328,7 +328,7 @@ void batadv_interface_rx(struct net_device *soft_iface, struct sk_buff *skb, struct batadv_hard_iface *recv_if, int hdr_size, struct batadv_orig_node *orig_node) { - struct batadv_header *batadv_header = (struct batadv_header *)skb->data; + struct batadv_bcast_packet *batadv_bcast_packet;struct batadv_priv *bat_priv =netdev_priv (soft_iface);__be16 ethertype =htons (ETH_P_BATMAN );struct vlan_ethhdr *vhdr;
@@ -336,7 +336,8 @@ void batadv_interface_rx(struct net_device *soft_iface,unsigned short vid;bool is_bcast; - is_bcast = (batadv_header->packet_type ==BATADV_BCAST ); + batadv_bcast_packet = (struct batadv_bcast_packet *)skb->data; + is_bcast = (batadv_bcast_packet->packet_type ==BATADV_BCAST );/* check if enough space is available for pulling, and pull */ if (!pskb_may_pull (skb, hdr_size))
Signature · 1 line
1.8.5.1
PATCH 4/6 batman-adv: fix size of batadv_icmp_header
In reply to Antonio Quartullistruct batadv_icmp_header currently has a size of 17, which will be padded to 20 on some architectures. Fix this by unrolling the header into the parent structures.
Moreover keep the ICMP parsing functions as generic as they are now by using a stub icmp_header struct during packet parsing.
--- net/batman-adv/main.c | 4 ++-- net/batman-adv/packet.h | 40 +++++++++++++++++++++++++++++++++++----- net/batman-adv/routing.c | 14 +++++++------- 3 files changed, 44 insertions(+), 14 deletions(-)
net/batman-adv/main.c +2 -2
@@ -426,8 +426,8 @@ static void batadv_recv_handler_init(void)BUILD_BUG_ON (offsetof(struct batadv_unicast_packet , dest) !=4 );BUILD_BUG_ON (offsetof(struct batadv_unicast_tvlv_packet , dst) !=4 );BUILD_BUG_ON (offsetof(struct batadv_frag_packet , dest) !=4 ); - BUILD_BUG_ON(offsetof(struct batadv_icmp_packet, icmph.dst) != 4); - BUILD_BUG_ON(offsetof(struct batadv_icmp_packet_rr, icmph.dst) != 4); +BUILD_BUG_ON (offsetof(struct batadv_icmp_packet , dst) !=4 ); +BUILD_BUG_ON (offsetof(struct batadv_icmp_packet_rr , dst) !=4 );/* broadcast packet */ batadv_rx_handler[BATADV_BCAST ] = batadv_recv_bcast_packet;
net/batman-adv/packet.h +35 -5
@@ -191,7 +191,7 @@ struct batadv_ogm_packet {#define BATADV_OGM_HLEN sizeof(struct batadv_ogm_packet)/** -* batadv_icmp_header - common ICMP header +* batadv_icmp_header - common members among all the ICMP packets * @packet_type: batman-adv packet type, part of the general header * @version: batman-adv protocol version, part of the genereal header * @ttl: time to live for this packet, part of the genereal header
@@ -199,6 +199,11 @@ struct batadv_ogm_packet {* @dst: address of the destination node * @orig: address of the source node * @uid: local ICMP socket identifier +* @align: not used - useful for alignment purposes only +* +* This structure is used for ICMP packets parsing only and it is never sent +* over the wire. The alignment field at the end is there to ensure that +* members are padded the same way as they are in real packets. */ struct batadv_icmp_header {uint8_t packet_type;
@@ -208,16 +213,29 @@ struct batadv_icmp_header {uint8_t dst[ETH_ALEN ];uint8_t orig[ETH_ALEN ];uint8_t uid; +uint8_t align[3 ]; };/** * batadv_icmp_packet - ICMP packet -* @icmph: common ICMP header +* @packet_type: batman-adv packet type, part of the general header +* @version: batman-adv protocol version, part of the genereal header +* @ttl: time to live for this packet, part of the genereal header +* @msg_type: ICMP packet type +* @dst: address of the destination node +* @orig: address of the source node +* @uid: local ICMP socket identifier * @reserved: not used - useful for alignment * @seqno: ICMP sequence number */ struct batadv_icmp_packet { -struct batadv_icmp_header icmph; +uint8_t packet_type; +uint8_t version; +uint8_t ttl; +uint8_t msg_type;/* see ICMP message types above */ +uint8_t dst[ETH_ALEN ]; +uint8_t orig[ETH_ALEN ]; +uint8_t uid;uint8_t reserved;__be16 seqno; };
@@ -226,13 +244,25 @@ struct batadv_icmp_packet {/** * batadv_icmp_packet_rr - ICMP RouteRecord packet -* @icmph: common ICMP header +* @packet_type: batman-adv packet type, part of the general header +* @version: batman-adv protocol version, part of the genereal header +* @ttl: time to live for this packet, part of the genereal header +* @msg_type: ICMP packet type +* @dst: address of the destination node +* @orig: address of the source node +* @uid: local ICMP socket identifier * @rr_cur: number of entries the rr array * @seqno: ICMP sequence number * @rr: route record array */ struct batadv_icmp_packet_rr { -struct batadv_icmp_header icmph; +uint8_t packet_type; +uint8_t version; +uint8_t ttl; +uint8_t msg_type;/* see ICMP message types above */ +uint8_t dst[ETH_ALEN ]; +uint8_t orig[ETH_ALEN ]; +uint8_t uid;uint8_t rr_cur;__be16 seqno;uint8_t rr[BATADV_RR_LEN ][ETH_ALEN ];
net/batman-adv/routing.c +7 -7
@@ -338,9 +338,9 @@ static int batadv_recv_icmp_ttl_exceeded(struct batadv_priv *bat_priv, icmp_packet = (struct batadv_icmp_packet *)skb->data;/* send TTL exceeded if packet is an echo request (traceroute) */ -if (icmp_packet->icmph.msg_type !=BATADV_ECHO_REQUEST ) { +if (icmp_packet->msg_type !=BATADV_ECHO_REQUEST ) {pr_debug ("Warning - can't forward icmp packet from %pM to %pM: ttl exceeded\n" , - icmp_packet->icmph.orig, icmp_packet->icmph.dst); + icmp_packet->orig, icmp_packet->dst); goto out; }
@@ -349,7 +349,7 @@ static int batadv_recv_icmp_ttl_exceeded(struct batadv_priv *bat_priv, goto out;/* get routing information */ - orig_node =batadv_orig_hash_find (bat_priv, icmp_packet->icmph.orig); + orig_node =batadv_orig_hash_find (bat_priv, icmp_packet->orig);if (!orig_node) goto out;
@@ -359,11 +359,11 @@ static int batadv_recv_icmp_ttl_exceeded(struct batadv_priv *bat_priv, icmp_packet = (struct batadv_icmp_packet *)skb->data; -memcpy (icmp_packet->icmph.dst, icmp_packet->icmph.orig,ETH_ALEN ); -memcpy (icmp_packet->icmph.orig, primary_if->net_dev->dev_addr, +memcpy (icmp_packet->dst, icmp_packet->orig,ETH_ALEN ); +memcpy (icmp_packet->orig, primary_if->net_dev->dev_addr,ETH_ALEN ); - icmp_packet->icmph.msg_type =BATADV_TTL_EXCEEDED ; - icmp_packet->icmph.ttl =BATADV_TTL ; + icmp_packet->msg_type =BATADV_TTL_EXCEEDED ; + icmp_packet->ttl =BATADV_TTL ;if (batadv_send_skb_to_orig (skb, orig_node,NULL ) !=NET_XMIT_DROP ) ret =NET_RX_SUCCESS ;
Signature · 1 line
1.8.5.1
PATCH 5/6 batman-adv: fix size of batadv_bla_claim_dst
In reply to Antonio QuartulliFrom: Simon Wunderlich <[email protected]>
Since this is a mac address and always 48 bit, and we can assume that it is always aligned to 2-byte boundaries, add a pack(2) pragma.
--- net/batman-adv/packet.h | 2 ++ 1 file changed, 2 insertions(+)
net/batman-adv/packet.h +2 -0
@@ -155,6 +155,7 @@ enum batadv_tvlv_type { BATADV_TVLV_ROAM = 0x05, }; +#pragma pack(2)/* the destination hardware field in the ARP frame is used to * transport the claim type and the group id */
@@ -163,6 +164,7 @@ struct batadv_bla_claim_dst {uint8_t type;/* bla_claimframe */ __be16 group;/* group id */ }; +#pragma pack()/** * struct batadv_ogm_packet - ogm (routing protocol) packet
Signature · 1 line
1.8.5.1
PATCH 6/6 batman-adv: fix alignment for batadv_tvlv_tt_change
In reply to Antonio QuartulliMake struct batadv_tvlv_tt_change a multiple 4 bytes long to avoid padding on any architecture.
--- net/batman-adv/packet.h | 4 ++-- net/batman-adv/translation-table.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-)
net/batman-adv/packet.h +2 -2
@@ -484,13 +484,13 @@ struct batadv_tvlv_tt_vlan_data {* struct batadv_tvlv_tt_change - translation table diff data * @flags: status indicators concerning the non-mesh client (see * batadv_tt_client_flags) -* @reserved: reserved field +* @reserved: reserved field - useful for alignment purposes only * @addr: mac address of non-mesh client that triggered this tt change * @vid: VLAN identifier */ struct batadv_tvlv_tt_change {uint8_t flags; -uint8_t reserved; +uint8_t reserved[3 ];uint8_t addr[ETH_ALEN ];__be16 vid; };
net/batman-adv/translation-table.c +4 -2
@@ -333,7 +333,8 @@ static void batadv_tt_local_event(struct batadv_priv *bat_priv,return ; tt_change_node->change.flags = flags; - tt_change_node->change.reserved =0 ; +memset (tt_change_node->change.reserved,0 , +sizeof (tt_change_node->change.reserved));memcpy (tt_change_node->change.addr, common->addr,ETH_ALEN ); tt_change_node->change.vid =htons (common->vid);
@@ -2221,7 +2222,8 @@ static void batadv_tt_tvlv_generate(struct batadv_priv *bat_priv, ETH_ALEN); tt_change->flags = tt_common_entry->flags; tt_change->vid =htons (tt_common_entry->vid); - tt_change->reserved =0 ; +memset (tt_change->reserved,0 , +sizeof (tt_change->reserved)); tt_num_entries++; tt_change++;
Signature · 1 line
1.8.5.1