powerpc: Make 64-bit non-VMX __copy_tofrom_user bi-endian
PATCH 1/1 powerpc: Make 64-bit non-VMX __copy_tofrom_user bi-endian
From: Paul E. McKenney <[email protected]>
The powerpc 64-bit __copy_tofrom_user() function uses shifts to handle unaligned invocations. However, these shifts were designed for big-endian systems: On little-endian systems, they must shift in the opposite direction.
This commit relies on the C preprocessor to insert the correct shifts into the assembly code.
[ This is a rare but nasty LE issue. Most of the time we use the POWER7 optimised __copy_tofrom_user_power7 loop, but when it hits an exception we fall back to the base __copy_tofrom_user loop. - Anton ]
---
arch/powerpc/lib/copyuser_64.S +38 -15
@@ -9,6 +9,14 @@ #include <asm/processor.h> #include <asm/ppc_asm.h> +#ifdef __BIG_ENDIAN__ +#define sLd sld /* Shift towards low-numbered address. */ +#define sHd srd /* Shift towards high-numbered address. */ +#else +#define sLd srd /* Shift towards low-numbered address. */ +#define sHd sld /* Shift towards high-numbered address. */ +#endif + .align 7 _GLOBAL(__copy_tofrom_user) BEGIN_FTR_SECTION
@@ -118,10 +126,10 @@ END_FTR_SECTION_IFCLR(CPU_FTR_UNALIGNED_LD_STD) 24: ld r9,0(r4) /* 3+2n loads, 2+2n stores */ 25: ld r0,8(r4) - sld r6,r9,r10 + sLd r6,r9,r10 26: ldu r9,16(r4) - srd r7,r0,r11 - sld r8,r0,r10 + sHd r7,r0,r11 + sLd r8,r0,r10 or r7,r7,r6 blt cr6,79f 27: ld r0,8(r4)
@@ -129,35 +137,35 @@ END_FTR_SECTION_IFCLR(CPU_FTR_UNALIGNED_LD_STD) 28: ld r0,0(r4) /* 4+2n loads, 3+2n stores */ 29: ldu r9,8(r4) - sld r8,r0,r10 + sLd r8,r0,r10 addi r3,r3,-8 blt cr6,5f 30: ld r0,8(r4) - srd r12,r9,r11 - sld r6,r9,r10 + sHd r12,r9,r11 + sLd r6,r9,r10 31: ldu r9,16(r4) or r12,r8,r12 - srd r7,r0,r11 - sld r8,r0,r10 + sHd r7,r0,r11 + sLd r8,r0,r10 addi r3,r3,16 beq cr6,78f 1: or r7,r7,r6 32: ld r0,8(r4) 76: std r12,8(r3) -2: srd r12,r9,r11 - sld r6,r9,r10 +2: sHd r12,r9,r11 + sLd r6,r9,r10 33: ldu r9,16(r4) or r12,r8,r12 77: stdu r7,16(r3) - srd r7,r0,r11 - sld r8,r0,r10 + sHd r7,r0,r11 + sLd r8,r0,r10 bdnz 1b 78: std r12,8(r3) or r7,r7,r6 79: std r7,16(r3) -5: srd r12,r9,r11 +5: sHd r12,r9,r11 or r12,r8,r12 80: std r12,24(r3) bne 6f
@@ -165,23 +173,38 @@ END_FTR_SECTION_IFCLR(CPU_FTR_UNALIGNED_LD_STD) blr 6: cmpwi cr1,r5,8 addi r3,r3,32 - sld r9,r9,r10 + sLd r9,r9,r10 ble cr1,7f 34: ld r0,8(r4) - srd r7,r0,r11 + sHd r7,r0,r11 or r9,r7,r9 7: bf cr7*4+1,1f +#ifdef __BIG_ENDIAN__ rotldi r9,r9,32 +#endif 94: stw r9,0(r3) +#ifdef __LITTLE_ENDIAN__ + rotrdi r9,r9,32 +#endif addi r3,r3,4 1: bf cr7*4+2,2f +#ifdef __BIG_ENDIAN__ rotldi r9,r9,16 +#endif 95: sth r9,0(r3) +#ifdef __LITTLE_ENDIAN__ + rotrdi r9,r9,16 +#endif addi r3,r3,2 2: bf cr7*4+3,3f +#ifdef __BIG_ENDIAN__ rotldi r9,r9,8 +#endif 96: stb r9,0(r3) +#ifdef __LITTLE_ENDIAN__ + rotrdi r9,r9,8 +#endif 3: li r3,0 blr
Hi,
Quoted 3 lines
[ This is a rare but nasty LE issue. Most of the time we use the POWER7 optimised
__copy_tofrom_user_power7loop, but when it hits an exception we fall back to the base__copy_tofrom_userloop. - Anton ]
To try and catch any screw ups in our ppc64 memcpy and copy_tofrom_user loops, I wrote a quick test:
http://ozlabs.org/~anton/junkcode/validate_kernel_copyloops.tar.gz
"make check" runs through all source and destination alignments for a range of sizes. It verifies the data was copied correctly and the redzone before and after were untouched.
It tests:
copyuser_64copyuser_power7memcpy_64memcpy_power7
memcpy_64 is currently unused on LE, but I added Paul McKenney's LE fixes regardless. copyuser_64 has the same LE fix (posted yesterday). All loops pass the test on both LE and BE.
Anton
Quoted 10 lines · Anton Blanchard
Hi,
Quoted 3 lines
[ This is a rare but nasty LE issue. Most of the time we use the POWER7 optimised
__copy_tofrom_user_power7loop, but when it hits an exception we fall back to the base__copy_tofrom_userloop. - Anton ]To try and catch any screw ups in our ppc64 memcpy and
copy_tofrom_userloops, I wrote a quick test:http://ozlabs.org/~anton/junkcode/validate_kernel_copyloops.tar.gz
Nice! How's this look?
cheers
selftests: Import Anton's memcpy / copy_tofrom_user tests
Turn Anton's memcpy / copy_tofrom_user test into something that can live in tools/testing/selftests.
It requires one turd in arch/powerpc/lib/memcpy_64.S, but it's pretty harmless IMHO.
We are sailing very close to the wind with the feature macros. We define them to nothing, which currently means we get a few extra nops and include the unaligned calls.
--- arch/powerpc/lib/memcpy_64.S | 2 + tools/testing/selftests/powerpc/Makefile | 2 +- tools/testing/selftests/powerpc/copyloops/Makefile | 29 +++++++ .../selftests/powerpc/copyloops/asm/ppc_asm.h | 86 +++++++++++++++++++ .../selftests/powerpc/copyloops/asm/processor.h | 0 .../selftests/powerpc/copyloops/copyuser_64.S | 1 + .../selftests/powerpc/copyloops/copyuser_power7.S | 1 + .../selftests/powerpc/copyloops/memcpy_64.S | 1 + .../selftests/powerpc/copyloops/memcpy_power7.S | 1 + .../testing/selftests/powerpc/copyloops/validate.c | 99 ++++++++++++++++++++++ tools/testing/selftests/powerpc/utils.h | 3 + 11 files changed, 224 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/powerpc/copyloops/Makefile create mode 100644 tools/testing/selftests/powerpc/copyloops/asm/ppc_asm.h create mode 100644 tools/testing/selftests/powerpc/copyloops/asm/processor.h create mode 120000 tools/testing/selftests/powerpc/copyloops/copyuser_64.S create mode 120000 tools/testing/selftests/powerpc/copyloops/copyuser_power7.S create mode 120000 tools/testing/selftests/powerpc/copyloops/memcpy_64.S create mode 120000 tools/testing/selftests/powerpc/copyloops/memcpy_power7.S create mode 100644 tools/testing/selftests/powerpc/copyloops/validate.c
arch/powerpc/lib/memcpy_64.S +2 -0
@@ -14,7 +14,9 @@ _GLOBAL(memcpy) BEGIN_FTR_SECTION std r3,48(r1) /* save destination pointer for return value */ FTR_SECTION_ELSE +#ifndef SELFTEST b memcpy_power7 +#endif ALT_FTR_SECTION_END_IFCLR(CPU_FTR_VMX_COPY) PPC_MTOCRF(0x01,r5) cmpldi cr1,r5,16
tools/testing/selftests/powerpc/Makefile +1 -1
@@ -13,7 +13,7 @@ CFLAGS := -Wall -O2 -flto -Wall -Werror -DGIT_VERSION='"$(GIT_VERSION)"' -I$(CUR export CC CFLAGS -TARGETS = pmu +TARGETS = pmu copyloops endif
tools/testing/selftests/powerpc/copyloops/Makefile new file +29 -0
@@ -0,0 +1,29 @@ +# The loops are all 64-bit code +CFLAGS += -m64 +CFLAGS += -I$(CURDIR) +CFLAGS += -D SELFTEST + +# Use our CFLAGS for the implicit .S rule +ASFLAGS = $(CFLAGS) + +PROGS := copyuser_64 copyuser_power7 memcpy_64 memcpy_power7 +EXTRA_SOURCES := validate.c ../harness.c + +all: $(PROGS) + +copyuser_64: CPPFLAGS += -D COPY_LOOP=test___copy_tofrom_user_base +copyuser_power7: CPPFLAGS += -D COPY_LOOP=test___copy_tofrom_user_power7 +memcpy_64: CPPFLAGS += -D COPY_LOOP=test_memcpy +memcpy_power7: CPPFLAGS += -D COPY_LOOP=test_memcpy_power7 + +$(PROGS): $(EXTRA_SOURCES) + +run_tests: all + @-for PROG in $(PROGS); do \ + ./$$PROG; \ + done; + +clean: + rm -f $(PROGS) *.o + +.PHONY: all run_tests clean
tools/testing/selftests/powerpc/copyloops/asm/ppc_asm.h new file +86 -0
86 lines not on this page · raw message
tools/testing/selftests/powerpc/copyloops/asm/processor.h new file +0 -0
tools/testing/selftests/powerpc/copyloops/copyuser_64.S new file +1 -0
@@ -0,0 +1 @@ +../../../../../arch/powerpc/lib/copyuser_64.S
tools/testing/selftests/powerpc/copyloops/copyuser_power7.S new file +1 -0
@@ -0,0 +1 @@ +../../../../../arch/powerpc/lib/copyuser_power7.S
tools/testing/selftests/powerpc/copyloops/memcpy_64.S new file +1 -0
@@ -0,0 +1 @@ +../../../../../arch/powerpc/lib/memcpy_64.S
tools/testing/selftests/powerpc/copyloops/memcpy_power7.S new file +1 -0
@@ -0,0 +1 @@ +../../../../../arch/powerpc/lib/memcpy_power7.S
tools/testing/selftests/powerpc/copyloops/validate.c new file +99 -0
99 lines not on this page · raw message
tools/testing/selftests/powerpc/utils.h +3 -0
@@ -31,4 +31,7 @@ do { \ } \ } while (0) +#define _str (s) #s +#define str (s) _str(s) +#endif /* _SELFTESTS_POWERPC_UTILS_H */
Signature · 1 line
1.8.3.2
Hi Michael,
Quoted 6 lines
Quoted 4 lines
To try and catch any screw ups in our ppc64 memcpy and
copy_tofrom_userloops, I wrote a quick test:http://ozlabs.org/~anton/junkcode/validate_kernel_copyloops.tar.gz
Nice! How's this look?
Love it!
At the moment my other copy_to/from_user tests run against the kernel (testing we copy all data right up to a page fault and that we return the correct number of bytes not copied etc). A small signal handler that walks the exception entries and branches to the handler should be all it takes to do it completely in userspace.
Anton
Quoted 352 lines
cheers
selftests: Import Anton's memcpy /
copy_tofrom_usertestsTurn Anton's memcpy /
copy_tofrom_usertest into something that can live intools/testing/selftests.It requires one turd in
arch/powerpc/lib/memcpy_64.S, but it's pretty harmless IMHO.We are sailing very close to the wind with the feature macros. We define them to nothing, which currently means we get a few extra nops and include the unaligned calls.
--- arch/powerpc/lib/memcpy_64.S | 2 + tools/testing/selftests/powerpc/Makefile | 2 +- tools/testing/selftests/powerpc/copyloops/Makefile | 29 +++++++ .../selftests/powerpc/copyloops/asm/ppc_asm.h | 86 +++++++++++++++++++ .../selftests/powerpc/copyloops/asm/processor.h | 0 .../selftests/powerpc/copyloops/copyuser_64.S | 1 + .../selftests/powerpc/copyloops/copyuser_power7.S | 1 + .../selftests/powerpc/copyloops/memcpy_64.S | 1 + .../selftests/powerpc/copyloops/memcpy_power7.S | 1 + .../testing/selftests/powerpc/copyloops/validate.c | 99++++++++++++++++++++++
tools/testing/selftests/powerpc/utils.h| 3 + 11 files
changed, 224 insertions(+), 1 deletion(-) create mode 100644tools/testing/selftests/powerpc/copyloops/Makefilecreate mode 100644tools/testing/selftests/powerpc/copyloops/asm/ppc_asm.hcreate mode 100644tools/testing/selftests/powerpc/copyloops/asm/processor.hcreate mode 120000tools/testing/selftests/powerpc/copyloops/copyuser_64.Screate mode 120000tools/testing/selftests/powerpc/copyloops/copyuser_power7.Screate mode 120000tools/testing/selftests/powerpc/copyloops/memcpy_64.Screate mode 120000tools/testing/selftests/powerpc/copyloops/memcpy_power7.Screate mode 100644tools/testing/selftests/powerpc/copyloops/validate.c(quoted diff) +0
-0
b/arch/powerpc/lib/memcpy_64.Sindex d2bbbc8..72ad055 100644arch/powerpc/lib/memcpy_64.S +0
-0@@ -14,7 +14,9 @@ _GLOBAL(memcpy) BEGIN_FTR_SECTION std r3,48(r1) /* save destination pointer forreturn value */
FTR_SECTION_ELSEarch/powerpc/lib/memcpy_64.S +2
-0+#ifndef SELFTEST b memcpy_power7 +#endif ALT_FTR_SECTION_END_IFCLR(CPU_FTR_VMX_COPY) PPC_MTOCRF(0x01,r5) cmpldi cr1,r5,16(quoted diff) +0
-0b/tools/testing/selftests/powerpc/Makefile index bd24ae5..316194f 100644 --- a/tools/testing/selftests/powerpc/Makefile +++ b/tools/testing/selftests/powerpc/Makefile
tools/testing/selftests/powerpc/Makefile +1
-2@@ -13,7 +13,7 @@ CFLAGS := -Wall -O2 -flto -Wall -Werror -DGIT_VERSION='"$(GIT_VERSION)"' -I$(CUR export CC CFLAGS -TARGETS = pmu +TARGETS = pmu copyloops endif(quoted diff) +0
-0b/tools/testing/selftests/powerpc/copyloops/Makefile new file mode 100644 index 0000000..6f2d3be
tools/testing/selftests/powerpc/copyloops/Makefile new file +14
-0@@ -0,0 +1,29 @@ +# The loops are all 64-bit code +CFLAGS += -m64 +CFLAGS += -I$(CURDIR) +CFLAGS += -D SELFTEST + +# Use our CFLAGS for the implicit .S rule +ASFLAGS = $(CFLAGS) + +PROGS := copyuser_64 copyuser_power7 memcpy_64 memcpy_power7 +EXTRA_SOURCES := validate.c ../harness.c + +all: $(PROGS) + +copyuser_64: CPPFLAGS += -DCOPY_LOOP=test___copy_tofrom_user_base +copyuser_power7: CPPFLAGS += -D COPY_LOOP=test___copy_tofrom_user_power7 +memcpy_64:
CPPFLAGS += -D COPY_LOOP=test_memcpy +memcpy_power7: CPPFLAGS += -D
COPY_LOOP=test_memcpy_power7 +
+$(PROGS): $(EXTRA_SOURCES)tools/testing/selftests/powerpc/copyloops/Makefile new file +10
-0+ +run_tests: all + @-for PROG in $(PROGS); do \ + ./$$PROG; \ + done; + +clean: + rm -f $(PROGS) *.o + +.PHONY: all run_tests clean(quoted diff) +0
-0
b/tools/testing/selftests/powerpc/copyloops/asm/ppc_asm.hnew file mode 100644 index 0000000..ccd9c84tools/testing/selftests/powerpc/copyloops/asm/ppc_asm.h new file +86
-0@@ -0,0 +1,86 @@ +#include <ppc-asm.h> + +#define CONFIG_ALTIVEC + +#define r1 1 + +#define vr0 0 +#define vr1 1 +#define vr2 2 +#define vr3 3 +#define vr4 4 +#define vr5 5 +#define vr6 6 +#define vr7 7 +#define vr8 8 +#define vr9 9 +#define vr10 10 +#define vr11 11 +#define vr12 12 +#define vr13 13 +#define vr14 14 +#define vr15 15 +#define vr16 16 +#define vr17 17 +#define vr18 18 +#define vr19 19 +#define vr20 20 +#define vr21 21 +#define vr22 22 +#define vr23 23 +#define vr24 24 +#define vr25 25 +#define vr26 26 +#define vr27 27 +#define vr28 28 +#define vr29 29 +#define vr30 30 +#define vr31 31 + +#define R14 r14 +#define R15 r15 +#define R16 r16 +#define R17 r17 +#define R18 r18 +#define R19 r19 +#define R20 r20 +#define R21 r21 +#define R22 r22 + +#define STACKFRAMESIZE 256 +#define STK_PARAM (i) (48 + ((i)-3)*8) +#define STK_REG (i) (112 + ((i)-14)*8) + +#define _GLOBAL (A ) FUNC_START(test_ ## A) + +#define PPC_MTOCRF (A ,B ) mtocrf A, B + +FUNC_START (enter_vmx_usercopy) + li r3,1 + blr + +FUNC_START(exit_vmx_usercopy) + li r3,0 + blr + +FUNC_START(enter_vmx_copy) + li r3,1 + blr + +FUNC_START(exit_vmx_copy) + blr + +FUNC_START(memcpy_power7) + blr + +FUNC_START(__copy_tofrom_user_power7) + blr + +FUNC_START(__copy_tofrom_user_base) + blr + +#define BEGIN_FTR_SECTION +#define FTR_SECTION_ELSE +#define ALT_FTR_SECTION_END_IFCLR(x) +#define ALT_FTR_SECTION_END(x, y) +#define END_FTR_SECTION_IFCLR(x)diff --git
a/tools/testing/selftests/powerpc/copyloops/asm/processor.hb/tools/testing/selftests/powerpc/copyloops/asm/processor.hnew file mode 100644 index 0000000..e69de29 diff --gita/tools/testing/selftests/powerpc/copyloops/copyuser_64.Sb/tools/testing/selftests/powerpc/copyloops/copyuser_64.Snew file mode 120000 index 0000000..f1c418a ---/dev/null
+++b/tools/testing/selftests/powerpc/copyloops/copyuser_64.Stools/testing/selftests/powerpc/copyloops/asm/ppc_asm.h new file +1
-0@@ -0,0 +1 @@ +../../../../../arch/powerpc/lib/copyuser_64.Sdiff --git
a/tools/testing/selftests/powerpc/copyloops/copyuser_power7.Sb/tools/testing/selftests/powerpc/copyloops/copyuser_power7.Snew file mode 120000 index 0000000..4786895 ---/dev/null+++b/tools/testing/selftests/powerpc/copyloops/copyuser_power7.Stools/testing/selftests/powerpc/copyloops/asm/ppc_asm.h new file +1
-0@@ -0,0 +1 @@ +../../../../../arch/powerpc/lib/copyuser_power7.S(quoted diff) +0
-0
b/tools/testing/selftests/powerpc/copyloops/memcpy_64.Snew file mode 120000 index 0000000..cce33fbtools/testing/selftests/powerpc/copyloops/memcpy_64.S new file +1
-0@@ -0,0 +1 @@ +../../../../../arch/powerpc/lib/memcpy_64.Sdiff --git
a/tools/testing/selftests/powerpc/copyloops/memcpy_power7.Sb/tools/testing/selftests/powerpc/copyloops/memcpy_power7.Snew file mode 120000 index 0000000..0d6fbfa ---/dev/null
+++b/tools/testing/selftests/powerpc/copyloops/memcpy_power7.Stools/testing/selftests/powerpc/copyloops/memcpy_64.S new file +1
-0@@ -0,0 +1 @@ +../../../../../arch/powerpc/lib/memcpy_power7.S(quoted diff) +0
-0
b/tools/testing/selftests/powerpc/copyloops/validate.cnew file mode 100644 index 0000000..1750ff5tools/testing/selftests/powerpc/copyloops/validate.c new file +14
-0@@ -0,0 +1,99 @@ +#include <malloc.h> +#include <string.h> +#include <stdlib.h> +#include <stdbool.h> + +#include "../utils.h" + +#define MAX_LEN 8192 +#define MAX_OFFSET 16 +#define MIN_REDZONE 128 +#define BUFLEN (MAX_LEN+MAX_OFFSET+2*MIN_REDZONE) +#define POISON 0xa5 + +unsigned long COPY_LOOP(void *to, const void *from, unsigned longsize); +
tools/testing/selftests/powerpc/copyloops/validate.c new file +2
-0+static void do_one (char *src,char *dst,unsigned long src_off, + unsigned long dst_off, unsigned long len, void*redzone,
tools/testing/selftests/powerpc/copyloops/validate.c new file +16
-0+ void *fill) +{ +char *srcp, *dstp; +unsigned long ret; +unsigned long i; + + srcp = src +MIN_REDZONE + src_off; + dstp = dst +MIN_REDZONE + dst_off; + +memset (src,POISON ,BUFLEN ); +memset (dst,POISON ,BUFLEN ); +memcpy (srcp, fill, len); + + ret =COPY_LOOP (dstp, srcp, len); +if (ret && ret != (unsigned long )dstp) { + printf("(%p,%p,%ld) returned %ld\n", dstp, srcp,len, ret);
tools/testing/selftests/powerpc/copyloops/validate.c new file +53
-0+abort (); + } + +if (memcmp (dstp, srcp, len)) { +printf ("(%p,%p,%ld) miscompare\n" , dstp, srcp, len); +printf ("src: " ); +for (i =0 ; i < len; i++) +printf ("%02x " , srcp[i]); +printf ("\ndst: " ); +for (i =0 ; i < len; i++) +printf ("%02x " , dstp[i]); +printf ("\n" ); +abort (); + } + +if (memcmp (dst, redzone, dstp - dst)) { +printf ("(%p,%p,%ld) redzone before corrupted\n" , + dstp, srcp, len); +abort (); + } + +if (memcmp (dstp+len, redzone, dst+BUFLEN -(dstp+len))) { +printf ("(%p,%p,%ld) redzone after corrupted\n" , + dstp, srcp, len); +abort (); + } +} + +int test_copy_loop (void ) +{ +char *src, *dst, *redzone, *fill; +unsigned long len, src_off, dst_off; +unsigned long i; + + src =memalign (BUFLEN ,BUFLEN ); + dst =memalign (BUFLEN ,BUFLEN ); + redzone =malloc (BUFLEN ); + fill =malloc (BUFLEN ); + +if (!src || !dst || !redzone || !fill) { +fprintf (stderr,"malloc failed\n" ); +exit (1 ); + } + +memset (redzone,POISON ,BUFLEN ); + +/* Fill with sequential bytes */ +for (i =0 ; i <BUFLEN ; i++) + fill[i] = i &0xff ; + +for (len =1 ; len <MAX_LEN ; len++) { +for (src_off =0 ; src_off <MAX_OFFSET ; src_off++) { + for (dst_off = 0; dst_off < MAX_OFFSET;dst_off++) {
tools/testing/selftests/powerpc/copyloops/validate.c new file +1
-0+ do_one(src, dst, src_off, dst_off,len,
tools/testing/selftests/powerpc/copyloops/validate.c new file +12
-0+ redzone, fill); + } + } + } + +return 0 ; +} + +int main (void ) +{ +return test_harness (test_copy_loop,str (COPY_LOOP )); +}(quoted diff) +0
-0
b/tools/testing/selftests/powerpc/utils.hindex 5851c4b..0de0644 100644 ---a/tools/testing/selftests/powerpc/utils.h+++b/tools/testing/selftests/powerpc/utils.h(quoted diff) +0
-0@@ -31,4 +31,7 @@ do {\ } \ } while
(0)tools/testing/selftests/powerpc/utils.h +3
-0+#define _str (s) #s +#define str (s) _str(s) +#endif /* _SELFTESTS_POWERPC_UTILS_H */
Quoted 10 lines · Anton Blanchard
Hi Michael,
Quoted 6 lines
Quoted 4 lines
To try and catch any screw ups in our ppc64 memcpy and
copy_tofrom_userloops, I wrote a quick test:http://ozlabs.org/~anton/junkcode/validate_kernel_copyloops.tar.gz
Nice! How's this look?
Love it!
Cool, I'll add your Signed-off-by and resubmit.
Quoted 5 lines
At the moment my other copy_to/from_user tests run against the kernel (testing we copy all data right up to a page fault and that we return the correct number of bytes not copied etc). A small signal handler that walks the exception entries and branches to the handler should be all it takes to do it completely in userspace.
That'd be nice. Are they in your junkcode? I couldn't spot them at a glance.
cheers