x86: sysfb: fool-proof CONFIG_X86_SYSFB
Subsystems (3)
PATCH 1/1 x86: sysfb: fool-proof CONFIG_X86_SYSFB
Turns out, people do not read help-texts of new config-options and enable them nonetheless. So several reports came in with X86_SYSFB=y and FB_SIMPLE=n, which in almost all situations prevents firmware-fbs from being probed.
X86_SYSFB clearly states that it turns legacy vesa/efi framebuffers into a format compatible to simplefb (and does nothing else..). So to avoid further complaints about missing gfx-support during boot, simply depend on FB_SIMPLE now.
As FB_SIMPLE is disabled by default and usually only enabled on selected ARM architectures, x86 users should thus never see the X86_SYSFB config-option. And if they do, everything is fine as simplefb will be available.
Note that most of the sysfb code is enabled independently of X86_SYSFB. The config option only selects a compatibility mode for simplefb. It was introduced to ease the transition to SimpleDRM and disabling fbdev. As this is still ongoing, there's no need for non-developers to care for X86_SYSFB so just change the help-text recommendation to "n".
--- arch/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/x86/Kconfig +2 -1
@@ -2298,6 +2298,7 @@ source "drivers/rapidio/Kconfig" config X86_SYSFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" + depends on (FB_SIMPLE = y) help Firmwares often provide initial graphics framebuffers so the BIOS, bootloader or kernel can show basic video-output during boot for
@@ -2320,7 +2321,7 @@ config X86_SYSFB and others enabled as fallback if a system framebuffer is incompatible with simplefb. - If unsure, say Y. + If unsure, say N. endmenu
Signature · 1 line
1.8.5.1
Quoted 2 lines · David Herrmann
Turns out, people do not read help-texts of new config-options and enable them nonetheless. [...]
Yeah, I too don't read them either, whenever an option name seems obvious to enable, so this is really something that happens frequently ;-)
Quoted 32 lines
[...] So several reports came in with X86_SYSFB=y and FB_SIMPLE=n, which in almost all situations prevents firmware-fbs from being probed.
X86_SYSFBclearly states that it turns legacy vesa/efi framebuffers into a format compatible to simplefb (and does nothing else..). So to avoid further complaints about missing gfx-support during boot, simply depend onFB_SIMPLEnow.As
FB_SIMPLEis disabled by default and usually only enabled on selected ARM architectures, x86 users should thus never see theX86_SYSFBconfig-option. And if they do, everything is fine as simplefb will be available.Note that most of the sysfb code is enabled independently of
X86_SYSFB. The config option only selects a compatibility mode for simplefb. It was introduced to ease the transition to SimpleDRM and disabling fbdev. As this is still ongoing, there's no need for non-developers to care forX86_SYSFBso just change the help-text recommendation to "n".Cc <[email protected]> # 3.11+Signed-off-by David Herrmann <[email protected]>--- arch/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/x86/Kconfig +0
-0
arch/x86/Kconfig source "drivers/rapidio/Kconfig" · line 2301
Quoted 4 lines
arch/x86/Kconfig +1
-0@@ -2298,6 +2298,7 @@ source "drivers/rapidio/Kconfig" config X86_SYSFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" + depends on (FB_SIMPLE = y)
Could that be written as:
depends on FB_SIMPLE
Or is there some complication with modular builds?
arch/x86/Kconfig config X86_SYSFB · line 2324
Quoted 9 lines
arch/x86/Kconfig +1
-1help Firmwares often provide initial graphics framebuffers so the BIOS, bootloader or kernel can show basic video-output during boot for@@ -2320,7 +2321,7 @@ config X86_SYSFB and others enabled as fallback if a system framebuffer is incompatible with simplefb. - If unsure, say Y. + If unsure, say N.
We might in fact leave this bit alone and suggest 'Y' - with the robustification fixes it's not possible anymore to crash the boot or to create an unintentionally headless system, right?
Thanks,
Ingo
Hi
Quoted 49 lines · Ingo Molnar
Quoted 2 lines · David Herrmann
Turns out, people do not read help-texts of new config-options and enable them nonetheless. [...]
Yeah, I too don't read them either, whenever an option name seems obvious to enable, so this is really something that happens frequently ;-)
Quoted 32 lines
[...] So several reports came in with X86_SYSFB=y and FB_SIMPLE=n, which in almost all situations prevents firmware-fbs from being probed.
X86_SYSFBclearly states that it turns legacy vesa/efi framebuffers into a format compatible to simplefb (and does nothing else..). So to avoid further complaints about missing gfx-support during boot, simply depend onFB_SIMPLEnow.As
FB_SIMPLEis disabled by default and usually only enabled on selected ARM architectures, x86 users should thus never see theX86_SYSFBconfig-option. And if they do, everything is fine as simplefb will be available.Note that most of the sysfb code is enabled independently of
X86_SYSFB. The config option only selects a compatibility mode for simplefb. It was introduced to ease the transition to SimpleDRM and disabling fbdev. As this is still ongoing, there's no need for non-developers to care forX86_SYSFBso just change the help-text recommendation to "n".Cc <[email protected]> # 3.11+Signed-off-by David Herrmann <[email protected]>--- arch/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/x86/Kconfig +0
-0arch/x86/Kconfig source "drivers/rapidio/Kconfig" · line 2301
Quoted 4 lines
arch/x86/Kconfig +1
-0@@ -2298,6 +2298,7 @@ source "drivers/rapidio/Kconfig" config X86_SYSFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" + depends on (FB_SIMPLE = y)Could that be written as:
Quoted 3 lines
depends on
FB_SIMPLEOr is there some complication with modular builds?
simplefb is actually "bool" so yeah, I can remove the "= y".
Note that *if* it ever is built as module, it will not get loaded during boot, thus not showing any boot-messages. But that's true for vesafb/efifb, too, so we're fine.
Quoted 7 lines
Quoted 7 lines
arch/x86/Kconfig +0
-0help Firmwares often provide initial graphics framebuffers so the BIOS, bootloader or kernel can show basic video-output during boot for@@ -2320,7 +2321,7 @@ config X86_SYSFB and others enabled as fallback if a system framebuffer is incompatible with simplefb.
Quoted 6 lines
arch/x86/Kconfig config X86_SYSFB · line 2324
Quoted 2 lines
arch/x86/Kconfig +1
-1- If unsure, say Y. + If unsure, say N.We might in fact leave this bit alone and suggest 'Y' - with the robustification fixes it's not possible anymore to crash the boot or to create an unintentionally headless system, right?
Nope, we will not cause a headless system, but the handover to other fbdev/DRM drivers (other than the common nouveau/radeon/i915) may still fail without the other patch (x86: sysfb: remove sysfb when probing real hw).
I will gladly keep the Y, if no-one disagrees. Given that the other patch is rather complex (and a no-op with X86_SYSFB=n) I wasn't quite sure. But as SYSFB is set to 'n' now if FB_SIMPLE wasn't explicitly selected, I think we're fine both ways.
Thanks
David
Quoted 81 lines · David Herrmann
Hi
Quoted 49 lines · Ingo Molnar
Quoted 2 lines · David Herrmann
Turns out, people do not read help-texts of new config-options and enable them nonetheless. [...]
Yeah, I too don't read them either, whenever an option name seems obvious to enable, so this is really something that happens frequently ;-)
Quoted 32 lines
[...] So several reports came in with X86_SYSFB=y and FB_SIMPLE=n, which in almost all situations prevents firmware-fbs from being probed.
X86_SYSFBclearly states that it turns legacy vesa/efi framebuffers into a format compatible to simplefb (and does nothing else..). So to avoid further complaints about missing gfx-support during boot, simply depend onFB_SIMPLEnow.As
FB_SIMPLEis disabled by default and usually only enabled on selected ARM architectures, x86 users should thus never see theX86_SYSFBconfig-option. And if they do, everything is fine as simplefb will be available.Note that most of the sysfb code is enabled independently of
X86_SYSFB. The config option only selects a compatibility mode for simplefb. It was introduced to ease the transition to SimpleDRM and disabling fbdev. As this is still ongoing, there's no need for non-developers to care forX86_SYSFBso just change the help-text recommendation to "n".Cc <[email protected]> # 3.11+Signed-off-by David Herrmann <[email protected]>--- arch/x86/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)arch/x86/Kconfig +0
-0arch/x86/Kconfig source "drivers/rapidio/Kconfig" · line 2301
Quoted 4 lines
arch/x86/Kconfig +1
-0@@ -2298,6 +2298,7 @@ source "drivers/rapidio/Kconfig" config X86_SYSFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" + depends on (FB_SIMPLE = y)Could that be written as:
Quoted 3 lines
depends on
FB_SIMPLEOr is there some complication with modular builds?
simplefb is actually "bool" so yeah, I can remove the "= y".
Note that *if* it ever is built as module, it will not get loaded during boot, thus not showing any boot-messages. But that's true for vesafb/efifb, too, so we're fine.
Quoted 7 lines
Quoted 7 lines
arch/x86/Kconfig +0
-0help Firmwares often provide initial graphics framebuffers so the BIOS, bootloader or kernel can show basic video-output during boot for@@ -2320,7 +2321,7 @@ config X86_SYSFB and others enabled as fallback if a system framebuffer is incompatible with simplefb.Quoted 6 lines
arch/x86/Kconfig config X86_SYSFB · line 2324
Quoted 2 lines
arch/x86/Kconfig +1
-1- If unsure, say Y. + If unsure, say N.We might in fact leave this bit alone and suggest 'Y' - with the robustification fixes it's not possible anymore to crash the boot or to create an unintentionally headless system, right?
Nope, we will not cause a headless system, but the handover to other fbdev/DRM drivers (other than the common nouveau/radeon/i915) may still fail without the other patch (x86: sysfb: remove sysfb when probing real hw).
Quoted 4 lines
I will gladly keep the Y, if no-one disagrees. Given that the other patch is rather complex (and a no-op with X86_SYSFB=n) I wasn't quite sure. But as SYSFB is set to 'n' now if
FB_SIMPLEwasn't explicitly selected, I think we're fine both ways.
Well, as long as fixes keep coming when people report them, I see no problem with keeping the 'Y'. Bugs happen.
And I think we want to apply the other fix regardless of the default.
Thanks,
Ingo
PATCH v2 1/1 x86: sysfb: fool-proof CONFIG_X86_SYSFB
In reply to David HerrmannTurns out, people do not read help-texts of new config-options and enable them nonetheless. So several reports came in with X86_SYSFB=y and FB_SIMPLE=n, which in almost all situations prevents firmware-fbs from being probed.
X86_SYSFB clearly states that it turns legacy vesa/efi framebuffers into a format compatible to simplefb (and does nothing else..). So to avoid further complaints about missing gfx-support during boot, simply depend on FB_SIMPLE now.
As FB_SIMPLE is disabled by default and usually only enabled on selected ARM architectures, x86 users should thus never see the X86_SYSFB config-option. And if they do, everything is fine as simplefb will be available.
Note that most of the sysfb code is enabled independently of X86_SYSFB. The config option only selects a compatibility mode for simplefb. It was introduced to ease the transition to SimpleDRM and disabling fbdev. As this is still ongoing, there's no need for non-developers to care for X86_SYSFB so we can safely hide it behind FB_SIMPLE.
---
v2:
- keep the "If unsure, say Y"
- (FB_SIMPLE = y) => FB_SIMPLE
- adjust commit-msg
arch/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/x86/Kconfig +1 -0
@@ -2298,6 +2298,7 @@ source "drivers/rapidio/Kconfig" config X86_SYSFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" + depends on FB_SIMPLE help Firmwares often provide initial graphics framebuffers so the BIOS, bootloader or kernel can show basic video-output during boot for
Signature · 1 line
1.8.5.1