net: i40e: fix shifting error in i40e_led_get
Subsystems (3)
PATCH 1/1 net: i40e: fix shifting error in i40e_led_get
In function i40e_led_get(), we fetch the LED mode from the GPIO registers and extract it from gpio_val. However, regardless of the outcome of the fetched value in gpio_val, the calculation to extract the mode will always be 0, as we do the following:
(gpio_val & (61440U /* 0xf << 12 */)) >> 17
Instead of I40E_GLGEN_GPIO_CTL_INT_MODE_SHIFT, we need to use I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT to fix this.
---
Seems like this is still unfixed, so sending to netdev.
drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_common.c +2 -2
@@ -365,8 +365,8 @@ u32 i40e_led_get(struct i40e_hw *hw)if (port != hw->port)continue ; - mode = (gpio_val &I40E_GLGEN_GPIO_CTL_LED_MODE_MASK ) - >>I40E_GLGEN_GPIO_CTL_INT_MODE_SHIFT ; + mode = (gpio_val &I40E_GLGEN_GPIO_CTL_LED_MODE_MASK ) >> +I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT ;break ; }
Signature · 1 line
1.8.3.1
Quoted 10 lines · Daniel Borkmann
In function
i40e_led_get(), we fetch the LED mode from the GPIO registers and extract it fromgpio_val. However, regardless of the outcome of the fetched value ingpio_val, the calculation to extract the mode will always be 0, as we do the following:(
gpio_val& (61440U /*0xf<< 12 */)) >> 17Instead of
I40E_GLGEN_GPIO_CTL_INT_MODE_SHIFT, we need to useI40E_GLGEN_GPIO_CTL_LED_MODE_SHIFTto fix this.
Quoted 6 lines
Signed-off-by Daniel Borkmann <[email protected]>---
Seems like this is still unfixed, so sending to netdev.drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks Daniel, I may already have a patch in my queue that fixes this, but if not, I will add this to my queue.
Quoted 15 lines · Jeff Kirsher
Quoted 14 lines · Daniel Borkmann
In function
i40e_led_get(), we fetch the LED mode from the GPIO registers and extract it fromgpio_val. However, regardless of the outcome of the fetched value ingpio_val, the calculation to extract the mode will always be 0, as we do the following:(gpio_val & (61440U /* 0xf << 12 */)) >> 17Instead of
I40E_GLGEN_GPIO_CTL_INT_MODE_SHIFT, we need to useI40E_GLGEN_GPIO_CTL_LED_MODE_SHIFTto fix this.Signed-off-by Daniel Borkmann <[email protected]>---
Seems like this is still unfixed, so sending to netdev.
Quoted 5 lines
Quoted 2 lines
drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Thanks Daniel, I may already have a patch in my queue that fixes this, but if not, I will add this to my queue.
I reported that plus fix > 1 months ago, so I guess it seems not yet in the queue. ;-)
Anyways, thanks Jeff!