Skip to contentSkip to conversation

ARM: tegra: modify Tegra30 USB2 default phy_type to UTMI

PATCH In review Eric Brower 2 participants 3 messages Dec 20, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 ARM: tegra: modify Tegra30 USB2 default phy_type to UTMI

Modify Tegra30 default USB2 phy_type to UTMI; this matches power-on-reset defaults and is expected to be the common case.

The current implementation is likely an incorrect carry-over from Tegra20, where USB2 does default to ULPI.

---
No upstream Tegra30 dts files reference USB2, so this should be a safe change; anyone using an out-of-tree dts with USB2, sparsely populated from the Tegra30 dtsi, may have an issue.

v2: modified register base address for USB2 bias pad regs

 arch/arm/boot/dts/tegra30.dtsi | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
arch/arm/boot/dts/tegra30.dtsi +16 -5
index 2bd55cf..8bb8c46 100644
@@ -669,7 +669,7 @@
 		compatible = "nvidia,tegra30-ehci", "usb-ehci";
 		reg = <0x7d004000 0x4000>;
 		interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
-		phy_type = "ulpi";
+		phy_type = "utmi";
 		clocks = <&tegra_car TEGRA30_CLK_USB2>;
 		nvidia,phy = <&phy2>;
 		status = "disabled";
@@ -677,12 +677,23 @@
 
 	phy2: usb-phy@7d004000 {
 		compatible = "nvidia,tegra30-usb-phy";
-		reg = <0x7d004000 0x4000>;
-		phy_type = "ulpi";
+		reg = <0x7d004000 0x4000 0x7d000000 0x4000>;
+		phy_type = "utmi";
 		clocks = <&tegra_car TEGRA30_CLK_USB2>,
 			 <&tegra_car TEGRA30_CLK_PLL_U>,
-			 <&tegra_car TEGRA30_CLK_CDEV2>;
-		clock-names = "reg", "pll_u", "ulpi-link";
+			 <&tegra_car TEGRA30_CLK_USBD>;
+		clock-names = "reg", "pll_u", "utmi-pads";
+		nvidia,hssync-start-delay = <9>;
+		nvidia,idle-wait-delay = <17>;
+		nvidia,elastic-limit = <16>;
+		nvidia,term-range-adj = <6>;
+		nvidia,xcvr-setup = <51>;
+		nvidia.xcvr-setup-use-fuses;
+		nvidia,xcvr-lsfslew = <2>;
+		nvidia,xcvr-lsrslew = <2>;
+		nvidia,xcvr-hsslew = <32>;
+		nvidia,hssquelch-level = <2>;
+		nvidia,hsdiscon-level = <5>;
 		status = "disabled";
 	};
 
Signature · 1 line
1.8.1.5

A message that is not in the archive (sent off-list or not yet received): 1387505333-3767-1-git-send-email-ebrower-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#2 lore raw

PATCH v2 2/2 ARM: tegra: enable USB2 on Tegra30 Beaver

Enable USB2 on Beaver, exposed via the mini-PCIe connector.

---
v2: no changes for this patch in the patchset

 arch/arm/boot/dts/tegra30-beaver.dts | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/tegra30-beaver.dts +9 -0
index 08cad69..7aef3e1 100644
@@ -328,6 +328,15 @@
 		non-removable;
 	};
 
+	usb@7d004000 {
+		status = "okay";
+	};
+
+	phy2: usb-phy@7d004000 {
+		vbus-supply = <&sys_3v3_reg>;
+		status = "okay";
+	};
+
 	usb@7d008000 {
 		status = "okay";
 	};
Signature · 1 line
1.8.1.5
#3 lore raw
In reply to a message not in the archive
Quoted 5 lines · Eric Brower

Modify Tegra30 default USB2 phy_type to UTMI; this matches power-on-reset defaults and is expected to be the common case.

The current implementation is likely an incorrect carry-over from Tegra20, where USB2 does default to ULPI.

The series, applied to Tegra's for-3.14/dt branch.