net: nft: call ipv6_find_hdr() with explicitly initialized offset
Subsystems (2)
PATCH 1/1 net: nft: call ipv6_find_hdr() with explicitly initialized offset
In nft's nft_exthdr_eval() routine we process IPv6 extension header through invoking ipv6_find_hdr(), but we call it with an uninitialized offset variable that contains some stack value. In ipv6_find_hdr() we then test if the value of offset != 0 and call skb_header_pointer() on that offset in order to map struct ipv6hdr into it. Fix it up by initializing offset to 0 as it was probably intended to be.
--- net/netfilter/nft_exthdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/nft_exthdr.c +1 -1
@@ -31,7 +31,7 @@ static void nft_exthdr_eval(const struct nft_expr *expr, {struct nft_exthdr *priv =nft_expr_priv (expr);struct nft_data *dest = &data[priv->dreg]; -unsigned int offset; +unsigned int offset =0 ;int err; err =ipv6_find_hdr (pkt->skb, &offset, priv->type,NULL ,NULL );
Signature · 1 line
1.8.3.1
Pablo Neira Ayuso
maintainerQuoted 6 lines · Daniel Borkmann
In nft's
nft_exthdr_eval()routine we process IPv6 extension header through invokingipv6_find_hdr(), but we call it with an uninitialized offset variable that contains some stack value. Inipv6_find_hdr()we then test if the value of offset != 0 and callskb_header_pointer()on that offset in order to map struct ipv6hdr into it. Fix it up by initializing offset to 0 as it was probably intended to be.
good catch, applied. Thanks Daniel.