vmxnet3: use initialized skb pointer to set hash
Subsystems (3)
PATCH 1/1 vmxnet3: use initialized skb pointer to set hash
The recent conversion to skb_set_hash() was incorrect. 'skb' is uninitialized at this point.
Fixes 0b6807034791 ('net: vmxnet3 calls skb_set_hash')
Signed-off-by Michal Schmidt <[email protected]>
--- drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/vmxnet3/vmxnet3_drv.c +2 -1
@@ -1235,7 +1235,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,#ifdef VMXNET3_RSS if (rcd->rssType !=VMXNET3_RCD_RSS_TYPE_NONE && (adapter->netdev->features &NETIF_F_RXHASH )) -skb_set_hash (skb,le32_to_cpu (rcd->rssHash), +skb_set_hash (ctx->skb, +le32_to_cpu (rcd->rssHash),PKT_HASH_TYPE_L3 );#endif skb_put (ctx->skb, rcd->len);
Signature · 1 line
1.8.4.2
Acked-by Tom Herbert <[email protected]>
Quoted 26 lines · Michal Schmidt
The recent conversion to
skb_set_hash()was incorrect. 'skb' is uninitialized at this point.Fixes 0b6807034791 ('net: vmxnet3 calls skb_set_hash')Signed-off-by Michal Schmidt <[email protected]>--- drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/net/vmxnet3/vmxnet3_drv.c +2
-2@@ -1235,7 +1235,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,#ifdef VMXNET3_RSS if (rcd->rssType !=VMXNET3_RCD_RSS_TYPE_NONE && (adapter->netdev->features &NETIF_F_RXHASH )) -skb_set_hash (skb,le32_to_cpu (rcd->rssHash), +skb_set_hash (ctx->skb, +le32_to_cpu (rcd->rssHash),PKT_HASH_TYPE_L3 );#endif skb_put (ctx->skb, rcd->len); --1.8.4.2
From: Michal Schmidt <[email protected]>
Date: Fri, 20 Dec 2013 13:16:57 +0100
Quoted 5 lines
The recent conversion to
skb_set_hash()was incorrect. 'skb' is uninitialized at this point.Fixes 0b6807034791 ('net: vmxnet3 calls skb_set_hash')Signed-off-by Michal Schmidt <[email protected]>
Applied, thank you.