Skip to contentSkip to conversation

vmxnet3: use initialized skb pointer to set hash

PATCH Applied Michal Schmidt 3 participants 3 messages Dec 20, 2013 – Dec 26, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vmxnet3: use initialized skb pointer to set hash

The recent conversion to skb_set_hash() was incorrect. 'skb' is uninitialized at this point.

Fixes 0b6807034791 ('net: vmxnet3 calls skb_set_hash')
---
 drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/vmxnet3/vmxnet3_drv.c +2 -1
index c0eab72..3be786f 100644
@@ -1235,7 +1235,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
 #ifdef VMXNET3_RSS
 			if (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE &&
 			    (adapter->netdev->features & NETIF_F_RXHASH))
-				skb_set_hash(skb, le32_to_cpu(rcd->rssHash),
+				skb_set_hash(ctx->skb,
+					     le32_to_cpu(rcd->rssHash),
 					     PKT_HASH_TYPE_L3);
 #endif
 			skb_put(ctx->skb, rcd->len);
Signature · 1 line
1.8.4.2
Acked-by on v1 1/1
#1 lore raw
Quoted 26 lines · Michal Schmidt

The recent conversion to skb_set_hash() was incorrect. 'skb' is uninitialized at this point.

Fixes 0b6807034791 ('net: vmxnet3 calls skb_set_hash')
---
 drivers/net/vmxnet3/vmxnet3_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/vmxnet3/vmxnet3_drv.c +2 -2
index c0eab72..3be786f 100644
@@ -1235,7 +1235,8 @@ vmxnet3_rq_rx_complete(struct vmxnet3_rx_queue *rq,
 #ifdef VMXNET3_RSS
                        if (rcd->rssType != VMXNET3_RCD_RSS_TYPE_NONE &&
                            (adapter->netdev->features & NETIF_F_RXHASH))
-                               skb_set_hash(skb, le32_to_cpu(rcd->rssHash),
+                               skb_set_hash(ctx->skb,
+                                            le32_to_cpu(rcd->rssHash),
                                             PKT_HASH_TYPE_L3);
 #endif
                        skb_put(ctx->skb, rcd->len);
--

1.8.4.2