mei_me: Ratelimit several error messages
Subsystems (2)
PATCH 1/1 mei_me: Ratelimit several error messages
I'm unsure of the cause, but I found irq/40-mei_me consuming 100% CPU and my disk full due to kern.log, syslog and messages rapidly growing in size filled with these messages:
Dec 23 12:29:57 dukhat kernel: [336224.363138] mei_me 0000:00:16.0: reset: wrong host start response Dec 23 12:29:57 dukhat kernel: [336224.363140] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING Dec 23 12:29:57 dukhat kernel: [336224.363152] mei_me 0000:00:16.0: reset: unexpected enumeration response hbm. Dec 23 12:29:57 dukhat kernel: [336224.363155] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING Dec 23 12:29:57 dukhat kernel: [336224.363185] mei_me 0000:00:16.0: reset: wrong host start response Dec 23 12:29:57 dukhat kernel: [336224.363187] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING Dec 23 12:29:57 dukhat kernel: [336224.363199] mei_me 0000:00:16.0: reset: unexpected enumeration response hbm. Dec 23 12:29:57 dukhat kernel: [336224.363201] mei_me 0000:00:16.0: unexpected reset: dev_state = RESETTING
This patch rate-limits those specific messages to reduce the impact if this problem ever recurs.
Signed-off-by Ian Munsie <[email protected]>
--- drivers/misc/mei/hbm.c | 4 ++-- drivers/misc/mei/init.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/misc/mei/hbm.c +2 -2
@@ -613,7 +613,7 @@ void mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr) dev->init_clients_timer =0 ;mei_hbm_enum_clients_req (dev); }else { -dev_err (&dev->pdev->dev,"reset: wrong host start response\n" ); +dev_err_ratelimited (&dev->pdev->dev,"reset: wrong host start response\n" );mei_reset (dev,1 );return ; }
@@ -690,7 +690,7 @@ void mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)/* first property reqeust */ mei_hbm_prop_req (dev); }else { -dev_err (&dev->pdev->dev,"reset: unexpected enumeration response hbm.\n" ); +dev_err_ratelimited (&dev->pdev->dev,"reset: unexpected enumeration response hbm.\n" );mei_reset (dev,1 );return ; }
drivers/misc/mei/init.c +1 -1
@@ -148,7 +148,7 @@ void mei_reset(struct mei_device *dev, int interrupts_enabled) dev->dev_state != MEI_DEV_POWER_UP);if (unexpected) -dev_warn (&dev->pdev->dev,"unexpected reset: dev_state = %s\n" , +dev_warn_ratelimited (&dev->pdev->dev,"unexpected reset: dev_state = %s\n" ,mei_dev_state_str (dev->dev_state)); ret =mei_hw_reset (dev, interrupts_enabled);
Signature · 1 line
1.8.4.rc3