Skip to contentSkip to conversation

sched: Fix up /proc/sched_debug to print only runnable tasks again

PATCH New Mike Galbraith 1 participant 1 message Dec 23, 2013 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: Fix up /proc/sched_debug to print only runnable tasks again

Hi Ingo,

This hunk of b32e86b430 looks like a booboo.

Commit b32e86b430 dropped p->on_rq check, leading to printing tasks which used to live on runqueues, which is very noisy (and annoying as heck).

---
 kernel/sched/debug.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/debug.c +1 -1
@@ -163,7 +163,7 @@ static void print_rq(struct seq_file *m,
 	read_lock_irqsave(&tasklist_lock, flags);
 
 	do_each_thread(g, p) {
-		if (task_cpu(p) != rq_cpu)
+		if (!p->on_rq || task_cpu(p) != rq_cpu)
 			continue;
 
 		print_task(m, rq, p);