spi: Eliminate 3WIRE spi_transfer check
PATCH 1/1 spi: Eliminate 3WIRE spi_transfer check
Checking for SPI_3WIRE isn't needed. spi_setup() already prevents 3WIRE mode from being combined with DUAL or QUAD mode support. So there is no need to differentiate between a single bit device with SPI_3WIRE set and one with without. It doesn't change the allowed bit widths.
---
Extracted from "spi: Simplify bit width checking code" as there seemed to be no debate about this part.
drivers/spi/spi.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/spi/spi.c +0 -6
@@ -1678,9 +1678,6 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message)if ((xfer->tx_nbits ==SPI_NBITS_QUAD ) && !(spi->mode &SPI_TX_QUAD ))return -EINVAL ; -if ((spi->mode &SPI_3WIRE ) && - (xfer->tx_nbits !=SPI_NBITS_SINGLE )) -return -EINVAL ; }/* check transfer rx_nbits */ if (xfer->rx_buf) {
@@ -1694,9 +1691,6 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message)if ((xfer->rx_nbits ==SPI_NBITS_QUAD ) && !(spi->mode &SPI_RX_QUAD ))return -EINVAL ; -if ((spi->mode &SPI_3WIRE ) && - (xfer->rx_nbits !=SPI_NBITS_SINGLE )) -return -EINVAL ; } }
Signature · 6 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 1388123466-7525-1-git-send-email-tpiepho-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Mark Brown
AppliedQuoted 4 lines · Trent Piepho
Checking for
SPI_3WIREisn't needed.spi_setup()already prevents 3WIRE mode from being combined with DUAL or QUAD mode support. So there is no need to differentiate between a single bit device withSPI_3WIREset and one with without. It doesn't change the allowed bit widths.
Applied, thanks.