core: remove old parameter for __dst_destroy_metrics_generic
Subsystems (2)
PATCH 1/1 core: remove old parameter for __dst_destroy_metrics_generic
From: Li RongQing <[email protected]>
when call __dst_destroy_metrics_generic, we always know who old is, so do not need to pass it.
Signed-off-by Li RongQing <[email protected]>
--- include/net/dst.h | 7 +++---- net/core/dst.c | 5 +++-- 2 files changed, 6 insertions(+), 6 deletions(-)
include/net/dst.h +3 -4
@@ -119,13 +119,12 @@ static inline bool dst_metrics_read_only(const struct dst_entry *dst)return dst->_metrics &DST_METRICS_READ_ONLY ; } -void __dst_destroy_metrics_generic (struct dst_entry *dst,unsigned long old); +void __dst_destroy_metrics_generic (struct dst_entry *dst);static inline void dst_destroy_metrics_generic (struct dst_entry *dst) { -unsigned long val = dst->_metrics; -if (!(val &DST_METRICS_READ_ONLY )) -__dst_destroy_metrics_generic (dst, val); +if (!dst_metrics_read_only (dst)) +__dst_destroy_metrics_generic (dst); }static inline u32 *dst_metrics_write_ptr (struct dst_entry *dst)
net/core/dst.c +3 -2
@@ -308,10 +308,11 @@ u32 *dst_cow_metrics_generic(struct dst_entry *dst, unsigned long old)EXPORT_SYMBOL (dst_cow_metrics_generic);/* Caller asserts that dst_metrics_read_only(dst) is false. */ -void __dst_destroy_metrics_generic (struct dst_entry *dst,unsigned long old) +void __dst_destroy_metrics_generic (struct dst_entry *dst) { -unsigned long prev, new; +unsigned long prev, new, old; + old = dst->_metrics; new = ((unsigned long ) dst_default_metrics) |DST_METRICS_READ_ONLY ; prev =cmpxchg (&dst->_metrics, old, new);if (prev == old)
Signature · 1 line
1.7.10.4
David Miller
maintainerFrom: [email protected]
Date: Fri, 27 Dec 2013 17:26:45 +0800
Quoted 6 lines
From: Li RongQing <[email protected]>
when call
__dst_destroy_metrics_generic, we always know who old is, so do not need to pass it.Signed-off-by Li RongQing <[email protected]>
It's a parameter so that we pass it in a register, rather than having the caller and the function both have to perform a memory operation and load the value.
It's an optimization.
I'm not applying this, sorry.