cpufreq: speedstep: remove unused speedstep_get_state
PATCH 1/1 cpufreq: speedstep: remove unused speedstep_get_state
The only caller of speedstep_get_state() was removed in commit d4019f0a92ab
("cpufreq: move freq change notifications to cpufreq core"). So building
speedstep-smi.o now triggers a GCC warning:
drivers/cpufreq/speedstep-smi.c:148:12: warning: 'speedstep_get_state' defined but not used [-Wunused-function]
Remove this unused function.
---
This seems to be a rather obvious fix. Hasn't it been submitted before?
drivers/cpufreq/speedstep-smi.c | 32 -------------------------------- 1 file changed, 32 deletions(-)
drivers/cpufreq/speedstep-smi.c +0 -32
@@ -141,38 +141,6 @@ static int speedstep_smi_get_freqs(unsigned int *low, unsigned int *high) }/** -* speedstep_get_state - set the SpeedStep state -* @state: processor frequency state (SPEEDSTEP_LOW or SPEEDSTEP_HIGH) -* -*/ -static int speedstep_get_state (void ) -{ -u32 function =GET_SPEEDSTEP_STATE ; -u32 result, state, edi, command, dummy; - - command = (smi_sig &0xffffff00 ) | (smi_cmd &0xff ); - -pr_debug ("trying to determine current setting with command %x " -"at port %x\n" , command, smi_port); - - __asm__ __volatile__( -"push %%ebp\n" -"out %%al, (%%dx)\n" -"pop %%ebp\n" - :"=a" (result), -"=b" (state),"=D" (edi), -"=c" (dummy),"=d" (dummy),"=S" (dummy) - :"a" (command),"b" (function),"c" (0 ), -"d" (smi_port),"S" (0 ),"D" (0 ) - ); - -pr_debug ("state is %x, result is %x\n" , state, result); - -return state &1 ; -} - - -/** * speedstep_set_state - set the SpeedStep state * @state: new processor frequency state (SPEEDSTEP_LOW or SPEEDSTEP_HIGH) *
Signature · 1 line
1.8.1.4
Rafael J. Wysocki
AppliedQuoted 8 lines · Paul Bolle
The only caller of
speedstep_get_state()was removed in commitd4019f0a92ab
("cpufreq: move freq change notifications to cpufreq core"). So building
speedstep-smi.o now triggers a GCC warning:
drivers/cpufreq/speedstep-smi.c:148:12: warning: 'speedstep_get_state' defined but not used [-Wunused-function]Remove this unused function.
Signed-off-by Paul Bolle <[email protected]>
Queued up for 3.14, thanks!
Quoted 50 lines
---
This seems to be a rather obvious fix. Hasn't it been submitted before?drivers/cpufreq/speedstep-smi.c | 32 -------------------------------- 1 file changed, 32 deletions(-)drivers/cpufreq/speedstep-smi.c +0
-32@@ -141,38 +141,6 @@ static int speedstep_smi_get_freqs(unsigned int *low, unsigned int *high) }/** -* speedstep_get_state - set the SpeedStep state -* @state: processor frequency state (SPEEDSTEP_LOW or SPEEDSTEP_HIGH) -* -*/ -static int speedstep_get_state (void ) -{ -u32 function =GET_SPEEDSTEP_STATE ; -u32 result, state, edi, command, dummy; - - command = (smi_sig &0xffffff00 ) | (smi_cmd &0xff ); - -pr_debug ("trying to determine current setting with command %x " -"at port %x\n" , command, smi_port); - - __asm__ __volatile__( -"push %%ebp\n" -"out %%al, (%%dx)\n" -"pop %%ebp\n" - :"=a" (result), -"=b" (state),"=D" (edi), -"=c" (dummy),"=d" (dummy),"=S" (dummy) - :"a" (command),"b" (function),"c" (0 ), -"d" (smi_port),"S" (0 ),"D" (0 ) - ); - -pr_debug ("state is %x, result is %x\n" , state, result); - -return state &1 ; -} - - -/** * speedstep_set_state - set the SpeedStep state * @state: new processor frequency state (SPEEDSTEP_LOW or SPEEDSTEP_HIGH) *
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.