comedi: Humusoft MF634 and MF624 DAQ cards driver

PATCH Superseded Rostislav Lisovy 3 participants 6 messages Jan 7, 2014 – Jan 9, 2014 Staging

Share & tools

Rostislav Lisovy

author

2014-01-07 22:25 UTC #0 lore raw

PATCH v2 1/1 comedi: Humusoft MF634 and MF624 DAQ cards driver

Changes since v1:
* Implemented all the small and big remarks pointed out by Hartley Sweeten, Dan Carpenter and Ian Abbott

Rostislav Lisovy (1):
comedi: Humusoft MF634 and MF624 DAQ cards driver

 drivers/staging/comedi/Kconfig          |   6 +
 drivers/staging/comedi/comedidev.h      |   1 +
 drivers/staging/comedi/drivers/Makefile |   1 +
 drivers/staging/comedi/drivers/mf6x4.c  | 355 ++++++++++++++++++++++++++++++++
 4 files changed, 363 insertions(+)
 create mode 100644 drivers/staging/comedi/drivers/mf6x4.c

Signature · 1 line

1.8.3.2

Rostislav Lisovy

author

2014-01-07 22:25 UTC #1 lore raw

PATCH 1/1 comedi: Humusoft MF634 and MF624 DAQ cards driver

This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/
The driver was tested with both cards. Everything seems to work properly. Just the basic functionality of the card (DIO, ADC, DAC) is supported by this driver.

Signed-off-by Rostislav Lisovy <[email protected]>

 create mode 100644 drivers/staging/comedi/drivers/mf6x4.c

drivers/staging/comedi/Kconfig +6 -0

index bfa27e7..89e25b4 100644
@@ -884,6 +884,12 @@ config COMEDI_GSC_HPDI
 	  To compile this driver as a module, choose M here: the module will be
 	  called gsc_hpdi.
 
+config COMEDI_MF6X4
+	tristate "Humusoft MF634 and MF624 DAQ Card support"
+	---help---
+	  This driver supports both Humusoft MF634 and MF624 Data acquisition
+	  cards. The legacy Humusoft MF614 card is not supported.
+
 config COMEDI_ICP_MULTI
 	tristate "Inova ICP_MULTI support"
 	---help---

drivers/staging/comedi/comedidev.h +1 -0

index 143be80..161bdd2 100644
@@ -410,6 +410,7 @@ void comedi_driver_unregister(struct comedi_driver *);
 #define PCI_VENDOR_ID_IOTECH		0x1616
 #define PCI_VENDOR_ID_CONTEC		0x1221
 #define PCI_VENDOR_ID_RTD		0x1435
+#define PCI_VENDOR_ID_HUMUSOFT		0x186c
 
 struct pci_dev;
 struct pci_driver;

drivers/staging/comedi/drivers/Makefile +1 -0

index 94cbd26..9e979a9 100644
@@ -110,6 +110,7 @@ obj-$(CONFIG_COMEDI_NI_PCIMIO)		+= ni_pcimio.o
 obj-$(CONFIG_COMEDI_RTD520)		+= rtd520.o
 obj-$(CONFIG_COMEDI_S626)		+= s626.o
 obj-$(CONFIG_COMEDI_SSV_DNP)		+= ssv_dnp.o
+obj-$(CONFIG_COMEDI_MF6X4)		+= mf6x4.o
 
 # Comedi PCMCIA drivers
 obj-$(CONFIG_COMEDI_CB_DAS16_CS)	+= cb_das16_cs.o

drivers/staging/comedi/drivers/mf6x4.c new file +355 -0

355 lines not on this page · raw message

Signature · 1 line

1.8.3.2

Dan Carpenter

2014-01-08 07:47 UTC #2 lore raw

Quoted 8 lines · Rostislav Lisovy

This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/
The driver was tested with both cards. Everything seems to work properly. Just the basic functionality of the card (DIO, ADC, DAC) is supported by this driver.

Quoted 4 lines

Signed-off-by Rostislav Lisovy <[email protected]>
 create mode 100644 drivers/staging/comedi/drivers/mf6x4.c

There should be a "---" after the Signed-off-by line and before the diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c" line. Otherwise, the diffstat gets included in the changelog.

Signed-off-by Rostislav Lisovy <[email protected]>

---
create mode 100644 drivers/staging/comedi/drivers/mf6x4.c

It's a small thing... I almost feel bad for pointing it out.

regards,
dan carpenter

Rostislav Lisovy

author

2014-01-08 08:35 UTC #3 lore raw

Hello Dan;

Quoted 14 lines · Dan Carpenter

Quoted 8 lines · Rostislav Lisovy
This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/
The driver was tested with both cards. Everything seems to work properly. Just the basic functionality of the card (DIO, ADC, DAC) is supported by this driver.
Quoted 4 lines
Signed-off-by Rostislav Lisovy <[email protected]>
 create mode 100644 drivers/staging/comedi/drivers/mf6x4.c

Quoted 8 lines

There should be a "---" after the Signed-off-by line and before the diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c" line. Otherwise, the diffstat gets included in the changelog.
Signed-off-by Rostislav Lisovy <[email protected]>
---
create mode 100644 drivers/staging/comedi/drivers/mf6x4.c

You are right, my mistake. But even though there should be v3 patch because I just realized there is an unnecessary comment in mf6x4_detach() and MF6X4_DAC_CHANN_CNT constant is no more used.

Regards;
Rostislav Lisovy

Ian Abbott

2014-01-08 10:42 UTC #4 lore raw

Quoted 26 lines · Rostislav Lisovy

Hello Dan;
Quoted 14 lines · Dan Carpenter
Quoted 8 lines · Rostislav Lisovy
This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/
The driver was tested with both cards. Everything seems to work properly. Just the basic functionality of the card (DIO, ADC, DAC) is supported by this driver.
Quoted 4 lines
Signed-off-by Rostislav Lisovy <[email protected]>
create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
Quoted 8 lines
There should be a "---" after the Signed-off-by line and before the diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c" line. Otherwise, the diffstat gets included in the changelog.
Signed-off-by Rostislav Lisovy <[email protected]>
---
create mode 100644 drivers/staging/comedi/drivers/mf6x4.c

Quoted 6 lines

You are right, my mistake. But even though there should be v3 patch because I just realized there is an unnecessary comment in mf6x4_detach() and MF6X4_DAC_CHANN_CNT constant is no more used.
Regards;
Rostislav Lisovy

I'll wait for the v3 patch, but apart from that it looks fine to me. I suppose it could be argued that the driver only uses 2 of the 3 BARs it ioremaps (a different 2 for each card), but they're only single page mappings.

Signature · 2 lines

-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

Rostislav Lisovy

author

2014-01-09 22:56 UTC #5 lore raw

In reply to Dan Carpenter

Quoted 9 lines · Dan Carpenter

Quoted 8 lines · Rostislav Lisovy
This patch adds Comedi driver for Humusoft MF634 (PCIe) and MF624 (PCI) data acquisition cards. The legacy card Humusoft MF614 is not supported. More info about the cards may be found at http://humusoft.cz/produkty/datacq/
The driver was tested with both cards. Everything seems to work properly. Just the basic functionality of the card (DIO, ADC, DAC) is supported by this driver.

Quoted 8 lines

Quoted 4 lines
Signed-off-by Rostislav Lisovy <[email protected]>
 create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
There should be a "---" after the Signed-off-by line and before the diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c" line. Otherwise, the diffstat gets included in the changelog.

I just resent the v3 patch with this flaw corrected. What surprises me a bit is the fact that the issue was caused by the 'git format-patch' command called with '--summary' argument. The dashes are included properly when the argument is not used. Does it make sense?

Regards;
Rostislav Lisovy