Skip to contentSkip to conversation

drm/i915: Bring UP Power Wells before disabling RC6.

PATCH In review [email protected] 2 participants 3 messages Jan 9, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/i915: Bring UP Power Wells before disabling RC6.

From: Deepak S <[email protected]>

We need do forcewake before Disabling RC6, This is what the BIOS expects while going into suspend.

v2: updated commit message. (Daniel)

---
 drivers/gpu/drm/i915/intel_pm.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +6 -0
index 469170c..bd68eb4 100644
@@ -3135,8 +3135,14 @@ static void valleyview_disable_rps(struct drm_device *dev)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 
+	/* we're doing forcewake before Disabling RC6,
+	 * This what the BIOS expects when going into suspend */
+	gen6_gt_force_wake_get(dev_priv, FORCEWAKE_ALL);
+
 	I915_WRITE(GEN6_RC_CONTROL, 0);
 
+	gen6_gt_force_wake_put(dev_priv, FORCEWAKE_ALL);
+
 	gen6_disable_rps_interrupts(dev);
 
 	if (dev_priv->vlv_pctx) {
Signature · 1 line
1.8.4.2
#1 lore raw
Quoted 4 lines · On Thu, Jan 09, 2014 at 07:28:27PM +0530, [email protected] wrote:

From: Deepak S <[email protected]>

We need do forcewake before Disabling RC6, This is what the BIOS expects while going into suspend.

What suspend are we talking about? When does the BIOS run, how is that serialised with the get/put of forcewake?
-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
author
#2 lore raw

Hi Chris,

During the development of runtime power management we faced some random issue around RC6 during the suspend. After some analyzing, we found by following the flow of doing Forcewake Get before the RC6 Disable and forcewake Put after we enable the RC6 solved most of the issues. This patch adds the Forcewake get before disabling the RC6

My commit message was to generic I guess :) I will change the commit message. The flow is between the driver and punit. :)

Thanks
Deepak

-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Thursday, January 9, 2014 7:32 PM
To: S, Deepak
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Bring UP Power Wells before disabling RC6.

Quoted 4 lines · On Thu, Jan 09, 2014 at 07:28:27PM +0530, [email protected] wrote:

From: Deepak S <[email protected]>

We need do forcewake before Disabling RC6, This is what the BIOS expects while going into suspend.

What suspend are we talking about? When does the BIOS run, how is that serialised with the get/put of forcewake? -Chris

--
Chris Wilson, Intel Open Source Technology Centre