Skip to contentSkip to conversation

Reduce IV_OPENVPN_GUI_VERSION= to IV_GUI_VER=

PATCH In review Gert Doering 2 participants 3 messages Jan 9, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Reduce IV_OPENVPN_GUI_VERSION= to IV_GUI_VER=

Use shorter variable name to signal the same thing (see f3a2cd255a3bc73) to save space in the buffer used the collective IV_ info sent to server.

---
 src/openvpn/ssl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
src/openvpn/ssl.c +2 -2
index 93222c4..15518ca 100644
@@ -1825,13 +1825,13 @@ push_peer_info(struct buffer *buf, struct tls_session *session)
 	    buf_printf (&out, "IV_HWADDR=%s\n", format_hex_ex (rgi.hwaddr, 6, 0, 1, ":", &gc));
         }
 
-      /* push env vars that begin with UV_ and IV_OPENVPN_GUI_VERSION */
+      /* push env vars that begin with UV_ and IV_GUI_VER */
       for (e=es->list; e != NULL; e=e->next)
 	{
 	  if (e->string)
 	    {
 	      if (((strncmp(e->string, "UV_", 3)==0 && session->opt->push_peer_info_detail >= 2)
-		   || (strncmp(e->string,"IV_OPENVPN_GUI_VERSION=",sizeof("IV_OPENVPN_GUI_VERSION=")-1)==0))
+		   || (strncmp(e->string,"IV_GUI_VER=",sizeof("IV_GUI_VER=")-1)==0))
 		  && buf_safe(&out, strlen(e->string)+1))
 		buf_printf (&out, "%s\n", e->string);
 	    }
Signature · 1 line
1.8.3.2
#1 lore raw

Am 09.01.14 20:48, schrieb Gert Doering:

Quoted 2 lines

Use shorter variable name to signal the same thing (see f3a2cd255a3bc73) to save space in the buffer used the collective IV_ info sent to server.

ACK.

Arne

#2 lore raw

Hi,

Quoted 4 lines · Arne Schwabe

Am 09.01.14 20:48, schrieb Gert Doering:

Quoted 2 lines

Use shorter variable name to signal the same thing (see f3a2cd255a3bc73) to save space in the buffer used the collective IV_ info sent to server.

ACK.

committed and pushed, with updated message-id, acked-by, etc.

commit 7efaca734b8d633441ec3d7def2a2768864dedcf (master) commit c1b35689964f6910c1ea239618d42ee5e552c405 (release/2.3)

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...