Skip to contentSkip to conversation

hung_task: Display every hung task warning

RFC PATCH Superseded [email protected] 3 participants 6 messages Jan 13, 2014 – Jan 14, 2014

Subsystems (2)

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

cover hung_task: Display every hung task warning

From: Aaron Tomlin <[email protected]>

Enable hung_task_warnings to display every hung task warning, when set to -1. While ULONG_MAX is practically "unlimited", this patch takes it one step further. Note: The maximum is now 2^31-1 which should (hopefully) be sufficient.

Please let me know your thoughts.

Aaron Tomlin (2):
sysctl: Make neg_one a standard constraint
hung_task: Display every hung task warning

 include/linux/sched/sysctl.h | 2 +-
 kernel/hung_task.c           | 9 +++++----
 kernel/sysctl.c              | 6 ++++--
 3 files changed, 10 insertions(+), 7 deletions(-)
Signature · 1 line
1.8.4.2
#1 lore raw

RFC PATCH 1/2 sysctl: Make neg_one a standard constraint

From: Aaron Tomlin <[email protected]>

Add neg_one to the list of standard constraints.

---
 kernel/sysctl.c | 1 +
 1 file changed, 1 insertion(+)
kernel/sysctl.c +1 -0
index 34a6047..dd531a6 100644
@@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;
 static int sixty = 60;
 #endif
 
+static int neg_one = -1;
 static int zero;
 static int __maybe_unused one = 1;
 static int __maybe_unused two = 2;
Signature · 1 line
1.8.4.2
#3 lore raw

RFC PATCH 2/2 hung_task: Display every hung task warning

In reply to [email protected]

From: Aaron Tomlin <[email protected]>

Enable hung_task_warnings to display every hung
task warning when set to -1.

---
 include/linux/sched/sysctl.h | 2 +-
 kernel/hung_task.c           | 9 +++++----
 kernel/sysctl.c              | 5 +++--
 3 files changed, 9 insertions(+), 7 deletions(-)
include/linux/sched/sysctl.h +1 -1
index 41467f8..eb3c72d7 100644
@@ -5,7 +5,7 @@
 extern int	     sysctl_hung_task_check_count;
 extern unsigned int  sysctl_hung_task_panic;
 extern unsigned long sysctl_hung_task_timeout_secs;
-extern unsigned long sysctl_hung_task_warnings;
+extern int sysctl_hung_task_warnings;
 extern int proc_dohung_task_timeout_secs(struct ctl_table *table, int write,
 					 void __user *buffer,
 					 size_t *lenp, loff_t *ppos);
kernel/hung_task.c +5 -4
index 9328b80..343ed70 100644
@@ -37,7 +37,7 @@ int __read_mostly sysctl_hung_task_check_count = PID_MAX_LIMIT;
  */
 unsigned long __read_mostly sysctl_hung_task_timeout_secs = CONFIG_DEFAULT_HUNG_TASK_TIMEOUT;
 
-unsigned long __read_mostly sysctl_hung_task_warnings = 10;
+int __read_mostly sysctl_hung_task_warnings = 10;
 
 static int __read_mostly did_panic;
 
@@ -98,11 +98,12 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
 
 	if (!sysctl_hung_task_warnings)
 		return;
-	sysctl_hung_task_warnings--;
+
+	if (sysctl_hung_task_warnings > 0)
+		sysctl_hung_task_warnings--;
 
 	/*
-	 * Ok, the task did not get scheduled for more than 2 minutes,
-	 * complain:
+	 * Ok, the task did not get scheduled for a while, complain:
 	 */
 	pr_err("INFO: task %s:%d blocked for more than %ld seconds.\n",
 		t->comm, t->pid, timeout);
kernel/sysctl.c +3 -2
index dd531a6..b50cd13 100644
@@ -985,9 +985,10 @@ static struct ctl_table kern_table[] = {
 	{
 		.procname	= "hung_task_warnings",
 		.data		= &sysctl_hung_task_warnings,
-		.maxlen		= sizeof(unsigned long),
+		.maxlen		= sizeof(int),
 		.mode		= 0644,
-		.proc_handler	= proc_doulongvec_minmax,
+		.proc_handler	= proc_dointvec_minmax,
+		.extra1		= &neg_one,
 	},
 #endif
 #ifdef CONFIG_COMPAT
Signature · 1 line
1.8.4.2
Reviewed-by on v1 2/2
#4 lore raw
Quoted 6 lines · On 01/13/2014 12:14 PM, [email protected] wrote:

From: Aaron Tomlin <[email protected]>

Enable hung_task_warnings to display every hung
task warning when set to -1.

Aaron and I talked on IRC, and after some talking these patches now make sense to me :)

The kernel apparently limits how many hung task warnings it will display at a time, when a timeout occurs. Aaron's patch allows that limit to be set to "unlimited", which will cause the kernel to display info about all hung tasks.

Signature · 1 line
All rights reversed
#5 lore raw
Quoted 8 lines · Rik van Riel
Quoted 6 lines · On 01/13/2014 12:14 PM, [email protected] wrote:

From: Aaron Tomlin <[email protected]>

Enable hung_task_warnings to display every hung
task warning when set to -1.

Quoted 7 lines

Aaron and I talked on IRC, and after some talking these patches now make sense to me :)

The kernel apparently limits how many hung task warnings it will display at a time, when a timeout occurs. Aaron's patch allows that limit to be set to "unlimited", which will cause the kernel to display info about all hung tasks.

The changelog needs to be updated with such kind of descriptive information.

Thanks,

Ingo