Skip to contentSkip to conversation

ELAN Touchscreen regression in recent 3.12 rc's? (USB)

DISCUSSION Kevin Fenzi 6 participants 12 messages Oct 28, 2013 – Jan 19, 2014

lore
Share & tools
lore
#0 lore raw

Greetings.

I have a lenovo yoga 2 pro.. it has a ELAN Touchscreen.

In 3.12rc5 it was detected and works.
in 3.12rc6 it was detected and works.

Sometime after the rc6 timeframe it stopped working. It doesn't work with rc7.

In dmesg I get:

[  159.519663] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[  159.519681] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[  159.519683] usb 2-7: Product: Touchscreen
[  159.519685] usb 2-7: Manufacturer: ELAN
[  159.519901] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[  159.528027] input: ELAN Touchscreen as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input20
[  159.528544] hid-multitouch 0003:04F3:016F.000A: input,hiddev0,hidraw1: USB HID v1.10 Device [ELAN Touchscreen] on usb-0000:00:14.0-7/input0
[  161.601423] usb 2-7: USB disconnect, device number 71
[  161.896828] usb 2-7: new full-speed USB device number 72 using xhci_hcd
[  163.991296] usb 2-7: unable to read config index 0 descriptor/start: -71
[  163.991301] usb 2-7: can't read configurations, error -71
[  164.143686] usb 2-7: new full-speed USB device number 73 using xhci_hcd
[  166.239273] usb 2-7: unable to read config index 0 descriptor/start: -71
[  166.239278] usb 2-7: can't read configurations, error -71
[  166.392576] usb 2-7: new full-speed USB device number 74 using xhci_hcd
[  168.487051] usb 2-7: unable to read config index 0 descriptor/start: -71
[  168.487058] usb 2-7: can't read configurations, error -71
[  168.640308] usb 2-7: new full-speed USB device number 75 using xhci_hcd
[  170.734850] usb 2-7: unable to read config index 0 descriptor/start: -71
[  170.734856] usb 2-7: can't read configurations, error -71
[  170.734927] hub 2-0:1.0: unable to enumerate USB device on port 7
[  171.022134] usb 2-7: new full-speed USB device number 76 using xhci_hcd
[  173.116744] usb 2-7: unable to read config index 0 descriptor/start: -71
[  173.116750] usb 2-7: can't read configurations, error -71
[  173.269840] usb 2-7: new full-speed USB device number 77 using xhci_hcd
[  173.282520] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[  173.282526] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[  173.282528] usb 2-7: Product: Touchscreen
[  173.282530] usb 2-7: Manufacturer: ELAN
[  173.282782] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[  173.290920] input: ELAN Touchscreen

as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input21

So it seems to be bouncing in and out (but never long enough to actually work).

Could be a regression in xhci_hcd?

Happy to provide more info/details/etc

kevin

#1 lore raw
Quoted 43 lines · Kevin Fenzi

Greetings.

I have a lenovo yoga 2 pro.. it has a ELAN Touchscreen.

In 3.12rc5 it was detected and works.
in 3.12rc6 it was detected and works.

Sometime after the rc6 timeframe it stopped working. It doesn't work with rc7.

In dmesg I get:

[  159.519663] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[  159.519681] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[  159.519683] usb 2-7: Product: Touchscreen
[  159.519685] usb 2-7: Manufacturer: ELAN
[  159.519901] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[  159.528027] input: ELAN Touchscreen as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input20
[  159.528544] hid-multitouch 0003:04F3:016F.000A: input,hiddev0,hidraw1: USB HID v1.10 Device [ELAN Touchscreen] on usb-0000:00:14.0-7/input0
[  161.601423] usb 2-7: USB disconnect, device number 71
[  161.896828] usb 2-7: new full-speed USB device number 72 using xhci_hcd
[  163.991296] usb 2-7: unable to read config index 0 descriptor/start: -71
[  163.991301] usb 2-7: can't read configurations, error -71
[  164.143686] usb 2-7: new full-speed USB device number 73 using xhci_hcd
[  166.239273] usb 2-7: unable to read config index 0 descriptor/start: -71
[  166.239278] usb 2-7: can't read configurations, error -71
[  166.392576] usb 2-7: new full-speed USB device number 74 using xhci_hcd
[  168.487051] usb 2-7: unable to read config index 0 descriptor/start: -71
[  168.487058] usb 2-7: can't read configurations, error -71
[  168.640308] usb 2-7: new full-speed USB device number 75 using xhci_hcd
[  170.734850] usb 2-7: unable to read config index 0 descriptor/start: -71
[  170.734856] usb 2-7: can't read configurations, error -71
[  170.734927] hub 2-0:1.0: unable to enumerate USB device on port 7
[  171.022134] usb 2-7: new full-speed USB device number 76 using xhci_hcd
[  173.116744] usb 2-7: unable to read config index 0 descriptor/start: -71
[  173.116750] usb 2-7: can't read configurations, error -71
[  173.269840] usb 2-7: new full-speed USB device number 77 using xhci_hcd
[  173.282520] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[  173.282526] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[  173.282528] usb 2-7: Product: Touchscreen
[  173.282530] usb 2-7: Manufacturer: ELAN
[  173.282782] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[  173.290920] input: ELAN Touchscreen
Quoted 5 lines

as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input21

So it seems to be bouncing in and out (but never long enough to actually work).

Could be a regression in xhci_hcd?

Hm. There were no changes in drivers/usb from -rc6 to -rc7, so if -rc6 works then I doubt it's xhci_hcd. There were two touchscreen quirks added between those two rcs though, so perhaps one of those broke this.

684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen 8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

CC'd AceLan and Jiri.

josh

#2 lore raw

Hi,

It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks.

% git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID ad0e669b922c7790182cf19f8015b30e23ad9499 HID: Fix unit exponent parsing again 684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen 8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

CC'd Nikolai, since his commit changes the protocol.

Best regards,
AceLan Kao.

2013/10/29 Josh Boyer <[email protected]>:

Quoted 62 lines · Kevin Fenzi
Quoted 43 lines

Greetings.

I have a lenovo yoga 2 pro.. it has a ELAN Touchscreen.

In 3.12rc5 it was detected and works.
in 3.12rc6 it was detected and works.

Sometime after the rc6 timeframe it stopped working. It doesn't work with rc7.

In dmesg I get:

[  159.519663] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[  159.519681] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[  159.519683] usb 2-7: Product: Touchscreen
[  159.519685] usb 2-7: Manufacturer: ELAN
[  159.519901] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[  159.528027] input: ELAN Touchscreen as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input20
[  159.528544] hid-multitouch 0003:04F3:016F.000A: input,hiddev0,hidraw1: USB HID v1.10 Device [ELAN Touchscreen] on usb-0000:00:14.0-7/input0
[  161.601423] usb 2-7: USB disconnect, device number 71
[  161.896828] usb 2-7: new full-speed USB device number 72 using xhci_hcd
[  163.991296] usb 2-7: unable to read config index 0 descriptor/start: -71
[  163.991301] usb 2-7: can't read configurations, error -71
[  164.143686] usb 2-7: new full-speed USB device number 73 using xhci_hcd
[  166.239273] usb 2-7: unable to read config index 0 descriptor/start: -71
[  166.239278] usb 2-7: can't read configurations, error -71
[  166.392576] usb 2-7: new full-speed USB device number 74 using xhci_hcd
[  168.487051] usb 2-7: unable to read config index 0 descriptor/start: -71
[  168.487058] usb 2-7: can't read configurations, error -71
[  168.640308] usb 2-7: new full-speed USB device number 75 using xhci_hcd
[  170.734850] usb 2-7: unable to read config index 0 descriptor/start: -71
[  170.734856] usb 2-7: can't read configurations, error -71
[  170.734927] hub 2-0:1.0: unable to enumerate USB device on port 7
[  171.022134] usb 2-7: new full-speed USB device number 76 using xhci_hcd
[  173.116744] usb 2-7: unable to read config index 0 descriptor/start: -71
[  173.116750] usb 2-7: can't read configurations, error -71
[  173.269840] usb 2-7: new full-speed USB device number 77 using xhci_hcd
[  173.282520] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[  173.282526] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[  173.282528] usb 2-7: Product: Touchscreen
[  173.282530] usb 2-7: Manufacturer: ELAN
[  173.282782] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[  173.290920] input: ELAN Touchscreen
Quoted 5 lines

as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input21

So it seems to be bouncing in and out (but never long enough to actually work).

Could be a regression in xhci_hcd?

Hm. There were no changes in drivers/usb from -rc6 to -rc7, so if -rc6 works then I doubt it's xhci_hcd. There were two touchscreen quirks added between those two rcs though, so perhaps one of those broke this.

684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen 8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

CC'd AceLan and Jiri.

josh

#3 lore raw
Quoted 14 lines · On Wed, 30 Oct 2013 09:41:06 +0800 AceLan Kao <[email protected]> wrote:

Hi,

It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks.

% git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID ad0e669b922c7790182cf19f8015b30e23ad9499 HID: Fix unit exponent parsing again 684524d35fe8d13be1f2649633e43bd02c96c695
HID: usbhid: quirk for SiS Touchscreen 8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

Quoted 1 line

CC'd Nikolai, since his commit changes the protocol.

Oddly, after a while it seems to have decided to stay on:

[ 4021.819962] usb 2-7: Manufacturer: ELAN
[ 4021.820163] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[ 4021.828338] input: ELAN Touchscreen as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input221
[ 4021.828801] hid-multitouch 0003:04F3:016F.00D3: input,hiddev0,hidraw1: USB HID v1.10 Device [ELAN Touchscreen] on usb-0000:00:14.0-7/input0
[ 4023.903599] usb 2-7: USB disconnect, device number 86
[ 4024.198444] usb 2-7: new full-speed USB device number 87 using xhci_hcd
[ 4024.211102] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[ 4024.211143] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[ 4024.211177] usb 2-7: Product: Touchscreen
[ 4024.211197] usb 2-7: Manufacturer: ELAN
[ 4024.211489] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[ 4024.219707] input: ELAN Touchscreen as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input222
[ 4024.220555] hid-multitouch 0003:04F3:016F.00D4:

input,hiddev0,hidraw1: USB HID v1.10 Device [ELAN Touchscreen] on usb-0000:00:14.0-7/input0

and it's been working since then. So, only after 87 cycles...

Some kind of weird race condition?

kevin

#4 lore raw
In reply to AceLan Kao

Hi AceLan,

Quoted 4 lines · AceLan Kao

It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks.

Quoted 8 lines

% git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID ad0e669b922c7790182cf19f8015b30e23ad9499 HID: Fix unit exponent parsing again 684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen 8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

CC'd Nikolai, since his commit changes the protocol.

My change is very unlikely to produce such problems. It changes calculation of axes resolution at the time the report descriptor is processed. The results of the calculation are not used by the kernel, AFAIK, but only by userspace drivers. The results should not be used to affect the interactions with the device, but only the interpretation of the reports (again, in userspace), and even that is barely done currently.

Please try reverting that particular commit and see if it affects the behavior.

Sincerely,
Nick

#5 lore raw
Quoted 22 lines · Nikolai Kondrashov
Quoted 13 lines

It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks.

% git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID ad0e669b922c7790182cf19f8015b30e23ad9499 HID: Fix unit exponent parsing again
684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen
8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

Quoted 1 line

CC'd Nikolai, since his commit changes the protocol.

My change is very unlikely to produce such problems. It changes calculation of axes resolution at the time the report descriptor is processed. The results of the calculation are not used by the kernel, AFAIK, but only by userspace drivers. The results should not be used to affect the interactions with the device, but only the interpretation of the reports (again, in userspace), and even that is barely done currently.

Quoted 2 lines

Please try reverting that particular commit and see if it affects the behavior.

AceLan,

do you have any update, please?

Signature · 2 lines
Jiri Kosina
SUSE Labs
#6 lore raw

Hi,

Sorry, no thoughts about this.
If Kevin would like to try, I can bisect the kernel and build the Ubuntu .deb package for him.
But like I say above, those 4 commits doesn't look like to lead to the problem, so I'll try to bisect the whole kernel.

% git bisect start v3.12-rc7 v3.12-rc6
Bisecting: 165 revisions left to test after this (roughly 7 steps) [edd31476011052d8f6591a3194ba0716b0cea681] bnx2x: Set NETIF_F_HIGHDMA unconditionally

Best regards,
AceLan Kao.

2013/11/5 Jiri Kosina <[email protected]>:

Quoted 34 lines · Nikolai Kondrashov
Quoted 23 lines
Quoted 14 lines

It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks.

% git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID ad0e669b922c7790182cf19f8015b30e23ad9499 HID: Fix unit exponent parsing again
684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen
8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

Quoted 1 line

CC'd Nikolai, since his commit changes the protocol.

My change is very unlikely to produce such problems. It changes calculation of axes resolution at the time the report descriptor is processed. The results of the calculation are not used by the kernel, AFAIK, but only by userspace drivers. The results should not be used to affect the interactions with the device, but only the interpretation of the reports (again, in userspace), and even that is barely done currently.

Quoted 2 lines

Please try reverting that particular commit and see if it affects the behavior.

AceLan,

do you have any update, please?

--
Jiri Kosina
SUSE Labs

#7 lore raw
Quoted 8 lines · On Wed, 6 Nov 2013 09:44:11 +0800 AceLan Kao <[email protected]> wrote:

Hi,

Sorry, no thoughts about this.
If Kevin would like to try, I can bisect the kernel and build the Ubuntu .deb package for him.
But like I say above, those 4 commits doesn't look like to lead to the problem, so I'll try to bisect the whole kernel.

Quoted 4 lines

% git bisect start v3.12-rc7 v3.12-rc6
Bisecting: 165 revisions left to test after this (roughly 7 steps) [edd31476011052d8f6591a3194ba0716b0cea681] bnx2x: Set NETIF_F_HIGHDMA unconditionally

Yeah, I can try and do so this weekend. To busy during the week to get very far on this.

Also, it seems like on some boots it just never works, but on others It does finally work:

[ 3238.722796] usb 2-7: new full-speed USB device number 127 using xhci_hcd
[ 3238.735177] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[ 3238.735183] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[ 3238.735185] usb 2-7: Product: Touchscreen
[ 3238.735187] usb 2-7: Manufacturer: ELAN
[ 3238.735539] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[ 3238.743682] input: ELAN Touchscreen as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input368
[ 3238.744505] hid-multitouch 0003:04F3:016F.00B4:

input,hiddev0,hidraw1: USB HID v1.10 Device [ELAN Touchscreen] on usb-0000:00:14.0-7/input0

so, 3238 seconds after boot, with 127 tries it started working on this boot.

I'll try and isolate it this weekend. Thanks for the attention everyone.

kevin
--

Quoted 41 lines

Best regards,
AceLan Kao.

2013/11/5 Jiri Kosina <[email protected]>:

Quoted 35 lines · Nikolai Kondrashov
Quoted 24 lines
Quoted 14 lines

It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks.

% git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID ad0e669b922c7790182cf19f8015b30e23ad9499 HID:
Fix unit exponent parsing again 684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen 8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

Quoted 1 line

CC'd Nikolai, since his commit changes the protocol.

My change is very unlikely to produce such problems. It changes calculation of axes resolution at the time the report descriptor is processed. The results of the calculation are not used by the kernel, AFAIK, but only by userspace drivers. The results should not be used to affect the interactions with the device, but only the interpretation of the reports (again, in userspace), and even that is barely done currently.

Quoted 2 lines

Please try reverting that particular commit and see if it affects the behavior.

AceLan,

do you have any update, please?

--
Jiri Kosina
SUSE Labs

#8 lore raw

Hi Kevin,

http://people.canonical.com/~acelan/elan_touchscreen/
Here are the kernels, please test them one by one and tell me which one works. As your description, the first one should work, and the second one doesn't, I just want to make sure that, so I build the rc6 and rc7 kernel to test. Thanks.

Best regards,
AceLan Kao.

2013/11/7 Kevin Fenzi <[email protected]>:

Quoted 81 lines
Quoted 8 lines · On Wed, 6 Nov 2013 09:44:11 +0800 AceLan Kao <[email protected]> wrote:

Hi,

Sorry, no thoughts about this.
If Kevin would like to try, I can bisect the kernel and build the Ubuntu .deb package for him.
But like I say above, those 4 commits doesn't look like to lead to the problem, so I'll try to bisect the whole kernel.

Quoted 4 lines

% git bisect start v3.12-rc7 v3.12-rc6
Bisecting: 165 revisions left to test after this (roughly 7 steps) [edd31476011052d8f6591a3194ba0716b0cea681] bnx2x: Set NETIF_F_HIGHDMA unconditionally

Yeah, I can try and do so this weekend. To busy during the week to get very far on this.

Also, it seems like on some boots it just never works, but on others It does finally work:

[ 3238.722796] usb 2-7: new full-speed USB device number 127 using xhci_hcd
[ 3238.735177] usb 2-7: New USB device found, idVendor=04f3, idProduct=016f
[ 3238.735183] usb 2-7: New USB device strings: Mfr=4, Product=14, SerialNumber=0
[ 3238.735185] usb 2-7: Product: Touchscreen
[ 3238.735187] usb 2-7: Manufacturer: ELAN
[ 3238.735539] usb 2-7: ep 0x2 - rounding interval to 64 microframes, ep desc says 80 microframes
[ 3238.743682] input: ELAN Touchscreen as /devices/pci0000:00/0000:00:14.0/usb2/2-7/2-7:1.0/input/input368
[ 3238.744505] hid-multitouch 0003:04F3:016F.00B4:

input,hiddev0,hidraw1: USB HID v1.10 Device [ELAN Touchscreen] on usb-0000:00:14.0-7/input0

so, 3238 seconds after boot, with 127 tries it started working on this boot.

I'll try and isolate it this weekend. Thanks for the attention everyone.

kevin
--

Quoted 41 lines

Best regards,
AceLan Kao.

2013/11/5 Jiri Kosina <[email protected]>:

Quoted 35 lines · Nikolai Kondrashov
Quoted 24 lines
Quoted 14 lines

It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks.

% git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID ad0e669b922c7790182cf19f8015b30e23ad9499 HID:
Fix unit exponent parsing again 684524d35fe8d13be1f2649633e43bd02c96c695 HID: usbhid: quirk for SiS Touchscreen 8171a67d587a09e14a4949a81e070345fedcf410 HID: usbhid: quirk for Synaptics Large Touchccreen

Quoted 1 line

CC'd Nikolai, since his commit changes the protocol.

My change is very unlikely to produce such problems. It changes calculation of axes resolution at the time the report descriptor is processed. The results of the calculation are not used by the kernel, AFAIK, but only by userspace drivers. The results should not be used to affect the interactions with the device, but only the interpretation of the reports (again, in userspace), and even that is barely done currently.

Quoted 2 lines

Please try reverting that particular commit and see if it affects the behavior.

AceLan,

do you have any update, please?

--
Jiri Kosina
SUSE Labs

#9 lore raw
Quoted 7 lines · On Thu, 7 Nov 2013 16:10:07 +0800 AceLan Kao <[email protected]> wrote:

Hi Kevin,

http://people.canonical.com/~acelan/elan_touchscreen/
Here are the kernels, please test them one by one and tell me which one works. As your description, the first one should work, and the second one doesn't, I just want to make sure that, so I build the rc6 and rc7 kernel to test. Thanks.

Thats very nice of you. :)

However, I run Fedora rawhide here, so deb's aren't too useful for me.

I just confirmed that:

kernel-3.12.0-0.rc6.git0.1.fc21.x86_64 is ok. and
kernel-3.12.0-0.rc6.git1.1.fc21.x86_64 shows the issue.

So, thats between 3.12-rc6 and 57-g69c88dc I'm setting up to build some kernels to bisect it.

git bisect start
# bad: [69c88dc7d9f1a6c3eceb7058111677c640811c94] vfs: fix new kernel-doc warnings git bisect bad 69c88dc7d9f1a6c3eceb7058111677c640811c94
# good: [31d141e3a666269a3b6fcccddb0351caf7454240] Linux 3.12-rc6
git bisect good 31d141e3a666269a3b6fcccddb0351caf7454240

Will let you know what I end up with, thanks.

kevin

#10 lore raw
In reply to Kevin Fenzi

Well, that was fun. ;)

git bisect start
# bad: [69c88dc7d9f1a6c3eceb7058111677c640811c94] vfs: fix new kernel-doc warnings
git bisect bad 69c88dc7d9f1a6c3eceb7058111677c640811c94
# good: [31d141e3a666269a3b6fcccddb0351caf7454240] Linux 3.12-rc6
git bisect good 31d141e3a666269a3b6fcccddb0351caf7454240
# good: [b403b73c21fcab11411a1439867a3ead9117e5e4] Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux
git bisect good b403b73c21fcab11411a1439867a3ead9117e5e4
# good: [d55f0691c041dba46daad7790b8f2631acb55f9a] Merge remote-tracking branch 'asoc/fix/pcm1792a' into asoc-linus
git bisect good d55f0691c041dba46daad7790b8f2631acb55f9a
# good: [20c87bd40e6c1ff7e31cc5eea4fb37829a57eb58] Merge tag 'asoc-v3.12-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-linus git bisect good 20c87bd40e6c1ff7e31cc5eea4fb37829a57eb58
# good: [d24fec3991076124e069c889c530cdc69cd43fb8] Merge tag 'jfs-3.12' of git://github.com/kleikamp/linux-shaggy
git bisect good d24fec3991076124e069c889c530cdc69cd43fb8
# good: [93cd00043fffec840fa36909c4a8eb0f735dfb04] Merge tag 'sound-3.12' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect good 93cd00043fffec840fa36909c4a8eb0f735dfb04
# good: [606d6fe3ffdb5190d4c8e4d6cd23aa6c1f9cb6ad] fs/namei.c: fix new kernel-doc warning
git bisect good 606d6fe3ffdb5190d4c8e4d6cd23aa6c1f9cb6ad

# first bad commit: [69c88dc7d9f1a6c3eceb7058111677c640811c94] vfs: fix
new kernel-doc warnings

Which is... nonsense. ;)

So, I tried the first bad commit again and it works.

After a small period of head scratching, I noticed that the other change in the non working kernel was re-enabling debugging options.

So, I rebuild locally the bad kernel with the debugging config and sure enough it's back.

So, it's some debugging option causing it.

I can try and bisect again with debugging config but I just got this laptop recently, so it could be that all debugging kernels have the issue and it's nothing recent?

The diff of configs is attached in case anything leaps out at people:

kevin
--
164c164
< CONFIG_DEBUG_BLK_CGROUP=y
---

Quoted 1 line

# CONFIG_DEBUG_BLK_CGROUP is not set

211d210
< CONFIG_PERF_USE_VMALLOC=y
217c216
< CONFIG_DEBUG_PERF_USE_VMALLOC=y
---

Quoted 1 line

# CONFIG_DEBUG_PERF_USE_VMALLOC is not set

286c285
< CONFIG_MODULE_FORCE_UNLOAD=y
---

Quoted 1 line

# CONFIG_MODULE_FORCE_UNLOAD is not set

346c345,350
< CONFIG_UNINLINE_SPIN_UNLOCK=y
---

Quoted 6 lines

CONFIG_INLINE_SPIN_UNLOCK_IRQ=y
CONFIG_INLINE_READ_UNLOCK=y
CONFIG_INLINE_READ_UNLOCK_IRQ=y
CONFIG_INLINE_WRITE_UNLOCK=y
CONFIG_INLINE_WRITE_UNLOCK_IRQ=y
CONFIG_MUTEX_SPIN_ON_OWNER=y

402,403c406,407
< CONFIG_MAXSMP=y
< CONFIG_NR_CPUS=4096
---

Quoted 2 lines

# CONFIG_MAXSMP is not set
CONFIG_NR_CPUS=128

409d412
< CONFIG_PREEMPT_COUNT=y
437c440
< CONFIG_NODES_SHIFT=10
---

Quoted 1 line

CONFIG_NODES_SHIFT=9

460c463
< CONFIG_SPLIT_PTLOCK_CPUS=999999
---

Quoted 1 line

CONFIG_SPLIT_PTLOCK_CPUS=4

484c487
< CONFIG_X86_BOOTPARAM_MEMORY_CORRUPTION_CHECK=y
---

Quoted 1 line

# CONFIG_X86_BOOTPARAM_MEMORY_CORRUPTION_CHECK is not set

535c538
< CONFIG_PM_TEST_SUSPEND=y
---

Quoted 1 line

# CONFIG_PM_TEST_SUSPEND is not set

561c564
< CONFIG_ACPI_DEBUG=y
---

Quoted 1 line

# CONFIG_ACPI_DEBUG is not set

1391c1394
< CONFIG_CEPH_LIB_PRETTYDEBUG=y
---

Quoted 1 line

# CONFIG_CEPH_LIB_PRETTYDEBUG is not set

1545c1548
< CONFIG_DRBD_FAULT_INJECTION=y
---

Quoted 1 line

# CONFIG_DRBD_FAULT_INJECTION is not set

2293c2296
< CONFIG_ATH_DEBUG=y
---

Quoted 1 line

# CONFIG_ATH_DEBUG is not set

2311c2314
< CONFIG_CARL9170_DEBUGFS=y
---

Quoted 1 line

# CONFIG_CARL9170_DEBUGFS is not set

2342c2345
< CONFIG_B43_DEBUG=y
---

Quoted 1 line

# CONFIG_B43_DEBUG is not set

2348c2351
< CONFIG_B43LEGACY_DEBUG=y
---

Quoted 1 line

# CONFIG_B43LEGACY_DEBUG is not set

2384c2387
< CONFIG_IWLWIFI_DEVICE_TRACING=y
---

Quoted 1 line

# CONFIG_IWLWIFI_DEVICE_TRACING is not set

4745,4746c4748
< CONFIG_DMADEVICES_DEBUG=y
< CONFIG_DMADEVICES_VDEBUG=y
---

Quoted 1 line

# CONFIG_DMADEVICES_DEBUG is not set

5202c5204
< CONFIG_EXT4_DEBUG=y
---

Quoted 1 line

# CONFIG_EXT4_DEBUG is not set

5204c5206
< CONFIG_JBD2_DEBUG=y
---

Quoted 1 line

# CONFIG_JBD2_DEBUG is not set

5249c5251
< CONFIG_QUOTA_DEBUG=y
---

Quoted 1 line

# CONFIG_QUOTA_DEBUG is not set

5380c5382
< CONFIG_NFSD_FAULT_INJECTION=y
---

Quoted 1 line

# CONFIG_NFSD_FAULT_INJECTION is not set

5505c5507
< CONFIG_DEBUG_FORCE_WEAK_PER_CPU=y
---

Quoted 1 line

# CONFIG_DEBUG_FORCE_WEAK_PER_CPU is not set

5513,5521c5515,5516
< CONFIG_DEBUG_OBJECTS=y
< # CONFIG_DEBUG_OBJECTS_SELFTEST is not set
< CONFIG_DEBUG_OBJECTS_FREE=y
< CONFIG_DEBUG_OBJECTS_TIMERS=y
< CONFIG_DEBUG_OBJECTS_WORK=y
< CONFIG_DEBUG_OBJECTS_RCU_HEAD=y
< CONFIG_DEBUG_OBJECTS_PERCPU_COUNTER=y
< CONFIG_DEBUG_OBJECTS_ENABLE_DEFAULT=1
< CONFIG_SLUB_DEBUG_ON=y
---

Quoted 2 lines

# CONFIG_DEBUG_OBJECTS is not set
# CONFIG_SLUB_DEBUG_ON is not set

5524,5528c5519,5520
< CONFIG_DEBUG_KMEMLEAK=y
< CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE=1024
< # CONFIG_DEBUG_KMEMLEAK_TEST is not set
< CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF=y
< CONFIG_DEBUG_STACK_USAGE=y
---

Quoted 2 lines

# CONFIG_DEBUG_KMEMLEAK is not set
# CONFIG_DEBUG_STACK_USAGE is not set

5548,5551c5540
< CONFIG_DETECT_HUNG_TASK=y
< CONFIG_DEFAULT_HUNG_TASK_TIMEOUT=120
< # CONFIG_BOOTPARAM_HUNG_TASK_PANIC is not set
< CONFIG_BOOTPARAM_HUNG_TASK_PANIC_VALUE=0
---

Quoted 1 line

# CONFIG_DETECT_HUNG_TASK is not set

5561,5562c5550
< CONFIG_DEBUG_RT_MUTEXES=y
< CONFIG_DEBUG_PI_LIST=y
---

Quoted 1 line

# CONFIG_DEBUG_RT_MUTEXES is not set

5564,5572c5552,5558
< CONFIG_DEBUG_SPINLOCK=y
< CONFIG_DEBUG_MUTEXES=y
< CONFIG_DEBUG_WW_MUTEX_SLOWPATH=y
< CONFIG_DEBUG_LOCK_ALLOC=y
< CONFIG_PROVE_LOCKING=y
< CONFIG_LOCKDEP=y
< CONFIG_LOCK_STAT=y
< # CONFIG_DEBUG_LOCKDEP is not set
< CONFIG_DEBUG_ATOMIC_SLEEP=y
---

Quoted 7 lines

# CONFIG_DEBUG_SPINLOCK is not set
# CONFIG_DEBUG_MUTEXES is not set
# CONFIG_DEBUG_WW_MUTEX_SLOWPATH is not set
# CONFIG_DEBUG_LOCK_ALLOC is not set
# CONFIG_PROVE_LOCKING is not set
# CONFIG_LOCK_STAT is not set
# CONFIG_DEBUG_ATOMIC_SLEEP is not set

5574d5559
< CONFIG_TRACE_IRQFLAGS=y
5579c5564
< CONFIG_DEBUG_WRITECOUNT=y
---

Quoted 1 line

# CONFIG_DEBUG_WRITECOUNT is not set

5581,5583c5566,5568
< CONFIG_DEBUG_SG=y
< CONFIG_DEBUG_NOTIFIERS=y
< CONFIG_DEBUG_CREDENTIALS=y
---

Quoted 3 lines

# CONFIG_DEBUG_SG is not set
# CONFIG_DEBUG_NOTIFIERS is not set
# CONFIG_DEBUG_CREDENTIALS is not set

5588,5589d5572
< CONFIG_PROVE_RCU=y
< # CONFIG_PROVE_RCU_REPEATEDLY is not set
5597,5603c5580
< CONFIG_FAULT_INJECTION=y
< CONFIG_FAILSLAB=y
< CONFIG_FAIL_PAGE_ALLOC=y
< CONFIG_FAIL_MAKE_REQUEST=y
< CONFIG_FAIL_IO_TIMEOUT=y
< CONFIG_FAIL_MMC_REQUEST=y
< CONFIG_FAULT_INJECTION_DEBUG_FS=y
---

Quoted 1 line

# CONFIG_FAULT_INJECTION is not set

5649,5650c5626
< CONFIG_MMIOTRACE=y
< # CONFIG_MMIOTRACE_TEST is not set
---

Quoted 1 line

# CONFIG_MMIOTRACE is not set

5658c5634
< CONFIG_TEST_LIST_SORT=y
---

Quoted 1 line

# CONFIG_TEST_LIST_SORT is not set

5670c5646
< CONFIG_DMA_API_DEBUG=y
---

Quoted 1 line

# CONFIG_DMA_API_DEBUG is not set

5685c5661
< CONFIG_X86_PTDUMP=y
---

Quoted 1 line

# CONFIG_X86_PTDUMP is not set

5709c5685
< CONFIG_X86_DEBUG_STATIC_CPU_HAS=y
---

Quoted 1 line

# CONFIG_X86_DEBUG_STATIC_CPU_HAS is not set

5924a5901

Quoted 1 line

CONFIG_CMPXCHG_LOCKREF=y

5973d5949
< CONFIG_CPUMASK_OFFSTACK=y

#11 lore raw

Hi,

I'm experiencing the same problem using Ubuntu 13.10, kernel 3.11.0-15-generic #23-Ubuntu SMP x86_64

Did you ever figure out what was causing the problem? Did it go away in the release 3.12?

I'm actually interesting in what the underlying cause was and how you found it.

thanks,

eric

--
View this message in context: http://linux-kernel.2935.n7.nabble.com/ELAN-Touchscreen-regression-in-recent-3-12-rc-s-USB-tp743984p789512.html
Sent from the Linux Kernel mailing list archive at Nabble.com.