Skip to contentSkip to conversation

ASoC: fsl_ssi: Do not print 'baud clock' error message all the time

PATCH Applied Fabio Estevam 2 participants 4 messages Jan 20, 2014 – Jan 21, 2014

Subsystems (3)
Sound ASoC Freescale SoC sound drivers
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 2/2 ASoC: fsl_ssi: Do not print 'baud clock' error message all the time

From: Fabio Estevam <[email protected]>

Currently everytime we get the following message on boot:

fsl-ssi-dai 202c000.ssi: could not get baud clock: -2

This is not really useful information to get on every boot, so make it a debug message instead.

Signed-off-by Fabio Estevam <[email protected]>
---
 sound/soc/fsl/fsl_ssi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/fsl/fsl_ssi.c +1 -1
index 7b1772d..3155611 100644
@@ -1407,7 +1407,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
 		 */
 		ssi_private->baudclk = devm_clk_get(&pdev->dev, "baud");
 		if (IS_ERR(ssi_private->baudclk))
-			dev_warn(&pdev->dev, "could not get baud clock: %ld\n",
+			dev_dbg(&pdev->dev, "could not get baud clock: %ld\n",
 				 PTR_ERR(ssi_private->baudclk));
 		else
 			clk_prepare_enable(ssi_private->baudclk);
Signature · 1 line
1.8.1.2
author reviewer
#1 lore raw

PATCH 1/2 ASoC: fsl_ssi: We do support master mode now

From: Fabio Estevam <[email protected]>

Since commit aafa85e71a (ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series) master mode is supported, so update the comments and code to reflect that.

Signed-off-by Fabio Estevam <[email protected]>
---
 sound/soc/fsl/fsl_ssi.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
sound/soc/fsl/fsl_ssi.c +1 -6
index 3155611..e24c7fe 100644
@@ -1278,18 +1278,13 @@ static int fsl_ssi_probe(struct platform_device *pdev)
 		return -EINVAL;
 	hw_type = (enum fsl_ssi_type) of_id->data;
 
-	/* We only support the SSI in "I2S Slave" mode */
 	sprop = of_get_property(np, "fsl,mode", NULL);
 	if (!sprop) {
 		dev_err(&pdev->dev, "fsl,mode property is necessary\n");
 		return -EINVAL;
 	}
-	if (!strcmp(sprop, "ac97-slave")) {
+	if (!strcmp(sprop, "ac97-slave"))
 		ac97 = true;
-	} else if (strcmp(sprop, "i2s-slave")) {
-		dev_notice(&pdev->dev, "mode %s is unsupported\n", sprop);
-		return -ENODEV;
-	}
 
 	/* The DAI name is the last part of the full name of the node. */
 	p = strrchr(np->full_name, '/') + 1;
Signature · 1 line
1.8.1.2
maintainer Applied
#2 lore raw

Re: [PATCH 1/2] ASoC: fsl_ssi: We do support master mode now

Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Since commit aafa85e71a (ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series) master mode is supported, so update the comments and code to reflect that.

Applied, thanks.