Skip to contentSkip to conversation

libtool-cross/native: Force usage of bash due to sstate inconsistencies

PATCH In review Richard Purdie 4 participants 5 messages Jan 23, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtool-cross/native: Force usage of bash due to sstate inconsistencies

Scenario:
a) libtool script is built on system with bash as /bin/sh
b) machine B installs sstate from build a)
c) machine B has dash as /bin/sh

In this scenario, the script fails to work properly since its expecting /bin/sh to have bash like syntax and it no longer does have it.

This patch forces the configure process to use /bin/bash, not /bin/sh and hence allows the scripts to work correctly when used from sstate.

(From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

---

meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb +2 -0
index 34aae0b..72fad37 100644
@@ -39,3 +39,5 @@ libtoolcross_sysroot_preprocess () {
 }
 
 SSTATE_SCAN_FILES += "libtoolize *-libtool"
+
+export CONFIG_SHELL="/bin/bash"
meta/recipes-devtools/libtool/libtool-native_2.4.2.bb +1 -0
index df73f08..f1051d8 100644
@@ -22,3 +22,4 @@ do_install () {
 	install -m 0755 ${HOST_SYS}-libtool ${D}${bindir}/${HOST_SYS}-libtool
 }
 
+export CONFIG_SHELL="/bin/bash"
#1 lore raw
Quoted 8 lines · Richard Purdie

Scenario:
a) libtool script is built on system with bash as /bin/sh
b) machine B installs sstate from build a)
c) machine B has dash as /bin/sh

In this scenario, the script fails to work properly since its expecting /bin/sh to have bash like syntax and it no longer does have it.

Quoted 6 lines

This patch forces the configure process to use /bin/bash, not /bin/sh and hence allows the scripts to work correctly when used from sstate.

(From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

Does this work for Fedora, using bash in /usr/bin/bash?

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#2 lore raw
Quoted 10 lines · Otavio Salvador
Quoted 8 lines · Richard Purdie

Scenario:
a) libtool script is built on system with bash as /bin/sh
b) machine B installs sstate from build a)
c) machine B has dash as /bin/sh

In this scenario, the script fails to work properly since its expecting /bin/sh to have bash like syntax and it no longer does have it.

Quoted 9 lines
Quoted 6 lines

This patch forces the configure process to use /bin/bash, not /bin/sh and hence allows the scripts to work correctly when used from sstate.

(From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

Does this work for Fedora, using bash in /usr/bin/bash?

Yes, I think so, on Fedora:

$ readlink -f /bin/
/usr/bin

/bin is a symlink which points to /usr/bin.

// Robert

#3 lore raw
Quoted 26 lines · Robert Yang
Quoted 15 lines · Otavio Salvador
Quoted 12 lines · Richard Purdie

Scenario:
a) libtool script is built on system with bash as /bin/sh
b) machine B installs sstate from build a)
c) machine B has dash as /bin/sh

In this scenario, the script fails to work properly since its expecting /bin/sh to have bash like syntax and it no longer does have it.

This patch forces the configure process to use /bin/bash, not /bin/sh and hence allows the scripts to work correctly when used from sstate.

Quoted 7 lines
Quoted 3 lines

(From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

Does this work for Fedora, using bash in /usr/bin/bash?

Quoted 7 lines

Yes, I think so, on Fedora:

$ readlink -f /bin/
/usr/bin

/bin is a symlink which points to /usr/bin.

Thanks for checking.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#4 lore raw
In reply to Richard Purdie
Quoted 10 lines · Richard Purdie

Scenario:
a) libtool script is built on system with bash as /bin/sh
b) machine B installs sstate from build a)
c) machine B has dash as /bin/sh

In this scenario, the script fails to work properly since its expecting /bin/sh to have bash like syntax and it no longer does have it.

This patch forces the configure process to use /bin/bash, not /bin/sh and hence allows the scripts to work correctly when used from sstate.

Shouldn't oe-core commit 367a19aaf31bcf997f10d045e7954cc800189052 fix that already? I don't see this issue on our builders since 367a19aaf31bcf997f10d045e7954cc800189052 was merged.

Quoted 1 line

(From OE-Core rev: 2c66aa0fc98b092ebb37baee94e92d1965afd76b)

This is sent from poky repo, right?

Quoted 27 lines

---

meta/recipes-devtools/libtool/libtool-cross_2.4.2.bb +2 -0
index 34aae0b..72fad37 100644
@@ -39,3 +39,5 @@ libtoolcross_sysroot_preprocess () {
 }
 
 SSTATE_SCAN_FILES += "libtoolize *-libtool"
+
+export CONFIG_SHELL="/bin/bash"
meta/recipes-devtools/libtool/libtool-native_2.4.2.bb +1 -0
index df73f08..f1051d8 100644
@@ -22,3 +22,4 @@ do_install () {
 	install -m 0755 ${HOST_SYS}-libtool ${D}${bindir}/${HOST_SYS}-libtool
 }
 
+export CONFIG_SHELL="/bin/bash"

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]