packagegroup refactoring

PATCH In review [email protected] 4 participants 14 messages Jan 24, 2014 – Jan 25, 2014

lore

Share & tools

lore

[email protected]

author

2014-01-24 23:46 UTC #0 lore raw

cover packagegroup refactoring

From: Rogerio Nunes <[email protected]>

This patchset refactors the packagegroup recipe, spliting it in smaller recipes.

With this approach, it will be easier to organize the inclusion of more packagegroups, and also to re-organize packages already grouped in one of the current groups.

This is not only about code refactoring tough. We will have better scalablity also in build time.

When a single packagegroup from a recipe that includes multiple packagegroups is added to one image, all the tasks to build all the packages from the same recipe file are added to the execution queue. In other words, if you need only one of the packagegroups from a big recipe file in your image, currently you are paying a high price in terms of build time for this convenience.

Longer term, I hope we will be able to have a better set of reference images in this layer, from small ones that can be built faster, to more complete images full of features.

Regards.

Rogerio Nunes (3):
packagegroup: rename to packagegroups
packagegroup-fsl: split packagegroup into multiple recipes packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with

X11

 recipes-fsl/packagegroup/packagegroup-fsl.bb       | 89 ----------------------
 .../packagegroups/packagegroup-fsl-gstreamer.bb    | 33 ++++++++
 .../packagegroup-fsl-tools-benchmark.bb            | 20 +++++
 .../packagegroup-fsl-tools-testapps.bb             | 45 +++++++++++
 4 files changed, 98 insertions(+), 89 deletions(-)
 delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb

Signature · 1 line

1.8.3.2

[email protected]

author

2014-01-24 23:46 UTC #1 lore raw

PATCH 1/3 packagegroup: rename to packagegroups

From: Rogerio Nunes <[email protected]>

For consistency with other layers, like poky and meta-openembedded, it's better to have packagegroup(s) directory in the plural version.

This patch prepares the source tree to have the single packagegroup file split into smaller recipes.

Change-Id I28ed48fe00dc9cc3875a9029503456af7c4134e6

Signed-off-by Rogerio Nunes <[email protected]>

---
 recipes-fsl/packagegroup/packagegroup-fsl.bb  | 89 ---------------------------
 recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 89 deletions(-)
 delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb

recipes-fsl/packagegroup/packagegroup-fsl.bb deleted +0 ~~-89~~

deleted file mode 100644
index 80ce5a4..0000000
@@ -1,89 +0,0 @@
-# Copyright (C) 2012-2013 Freescale Semiconductor
-# Released under the MIT license (see COPYING.MIT for the terms)
-
-DESCRIPTION = "Freescale package group"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
-                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-
-PR = "r5"
-
-inherit packagegroup
-
-PROVIDES = "${PACKAGES}"
-PACKAGES += " \
-    ${PN}-gstreamer \
-    ${PN}-gstreamer-streamer \
-    ${PN}-tools-testapps \
-    ${PN}-tools-benchmark \
-"
-
-MACHINE_GSTREAMER_PLUGIN ?= ""
-
-RDEPENDS_${PN}-gstreamer = " \
-    gst-meta-audio \
-    gst-meta-video \
-    gst-meta-debug \
-    gst-plugins-good-meta \
-    ${MACHINE_GSTREAMER_PLUGIN} \
-"
-
-RDEPENDS_${PN}-gstreamer-streamer = " \
-    ${PN}-gstreamer \
-    gst-plugins-good-udp \
-    gst-plugins-good-rtp \
-    gst-plugins-good-rtpmanager \
-    gst-plugins-good-rtsp \
-"
-
-SOC_TOOLS_TESTAPPS = ""
-SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
-"
-
-SOC_TOOLS_TESTAPPS_mx6 = " \
-    gpu-viv-bin-mx6q \
-"
-
-RDEPENDS_${PN}-tools-testapps = " \
-    ${SOC_TOOLS_TESTAPPS} \
-    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
-    alsa-utils \
-    alsa-tools \
-    dosfstools \
-    evtest \
-    e2fsprogs-mke2fs \
-    fsl-rc-local \
-    gst-plugins-base-tcp \
-    i2c-tools \
-    imx-test \
-    iproute2 \
-    memtester \
-    python-subprocess \
-    python-datetime \
-    python-json \
-    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
-    ethtool \
-    mtd-utils \
-    mtd-utils-ubifs \
-"
-
-RDEPENDS_${PN}-tools-benchmark = " \
-    lmbench \
-    bonnie++ \
-    dbench \
-    fio \
-    iozone3 \
-    iperf \
-    nbench-byte \
-    tiobench \
-    "
-# Disabled as it has CRC problems in denzil branch
-#    cpuburn-neon
-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-gstreamer = "1"
-ALLOW_EMPTY_${PN}-tools-testapps = "1"
-ALLOW_EMPTY_${PN}-tools-benchmark = "1"
-
-PACKAGE_ARCH = "${MACHINE_ARCH}"

recipes-fsl/packagegroups/packagegroup-fsl.bb new file +89 -0

89 lines not on this page · raw message

Signature · 1 line

1.8.3.2

Fabio Estevam

2014-01-25 13:39 UTC #2 lore raw

Re: [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups

Hi Rogerio,

Quoted 5 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:

From: Rogerio Nunes <[email protected]>
For consistency with other layers, like poky and meta-openembedded, it's better to have packagegroup(s) directory in the plural version.

Quoted 8 lines

This patch prepares the source tree to have the single packagegroup file split into smaller recipes.
Change-Id I28ed48fe00dc9cc3875a9029503456af7c4134e6
Signed-off-by Rogerio Nunes <[email protected]>
---
 recipes-fsl/packagegroup/packagegroup-fsl.bb  | 89 ---------------------------
 recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++

When doing file renames in git it is better to use 'git mv' and then generate the patch via 'git format patch -M'.

Then the git statistics will present it as a simple file rename change rather than 89 additions and 89 deletions.

Regards,

Fabio Estevam

Rogerio Nunes

author

2014-01-25 18:53 UTC #3 lore raw

Re: [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups

Thanks Fabio,

I used git mv, but indeed forgot to use git format-pacth with -M...

I'll be careful next time.

Regards,
Rogerio.

Quoted 29 lines · Fabio Estevam

Hi Rogerio,
Quoted 5 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:
From: Rogerio Nunes <[email protected]>
For consistency with other layers, like poky and meta-openembedded, it's better to have packagegroup(s) directory in the plural version.
Quoted 7 lines
This patch prepares the source tree to have the single packagegroup file split into smaller recipes.
Change-Id I28ed48fe00dc9cc3875a9029503456af7c4134e6
Signed-off-by Rogerio Nunes <[email protected]>
---
 recipes-fsl/packagegroup/packagegroup-fsl.bb  | 89
---------------------------
Quoted 1 line
 recipes-fsl/packagegroups/packagegroup-fsl.bb | 89
+++++++++++++++++++++++++++
When doing file renames in git it is better to use 'git mv' and then generate the patch via 'git format patch -M'.
Then the git statistics will present it as a simple file rename change rather than 89 additions and 89 deletions.
Regards,
Fabio Estevam

Daiane Angolini

2014-01-25 19:15 UTC #4 lore raw

Re: [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups

In reply to [email protected]

Quoted 7 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:

From: Rogerio Nunes <[email protected]>
For consistency with other layers, like poky and meta-openembedded, it's better to have packagegroup(s) directory in the plural version.
This patch prepares the source tree to have the single packagegroup file split into smaller recipes.

It's nice to see a long commit log, thanks a lot.

reviewed

Daiane

Quoted 207 lines

Change-Id I28ed48fe00dc9cc3875a9029503456af7c4134e6

Signed-off-by Rogerio Nunes <[email protected]>

---
 recipes-fsl/packagegroup/packagegroup-fsl.bb  | 89 ---------------------------
 recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++
 2 files changed, 89 insertions(+), 89 deletions(-)
 delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb

recipes-fsl/packagegroup/packagegroup-fsl.bb deleted +0 ~~-89~~

deleted file mode 100644
index 80ce5a4..0000000
@@ -1,89 +0,0 @@
-# Copyright (C) 2012-2013 Freescale Semiconductor
-# Released under the MIT license (see COPYING.MIT for the terms)
-
-DESCRIPTION = "Freescale package group"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
-                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-
-PR = "r5"
-
-inherit packagegroup
-
-PROVIDES = "${PACKAGES}"
-PACKAGES += " \
-    ${PN}-gstreamer \
-    ${PN}-gstreamer-streamer \
-    ${PN}-tools-testapps \
-    ${PN}-tools-benchmark \
-"
-
-MACHINE_GSTREAMER_PLUGIN ?= ""
-
-RDEPENDS_${PN}-gstreamer = " \
-    gst-meta-audio \
-    gst-meta-video \
-    gst-meta-debug \
-    gst-plugins-good-meta \
-    ${MACHINE_GSTREAMER_PLUGIN} \
-"
-
-RDEPENDS_${PN}-gstreamer-streamer = " \
-    ${PN}-gstreamer \
-    gst-plugins-good-udp \
-    gst-plugins-good-rtp \
-    gst-plugins-good-rtpmanager \
-    gst-plugins-good-rtsp \
-"
-
-SOC_TOOLS_TESTAPPS = ""
-SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
-"
-
-SOC_TOOLS_TESTAPPS_mx6 = " \
-    gpu-viv-bin-mx6q \
-"
-
-RDEPENDS_${PN}-tools-testapps = " \
-    ${SOC_TOOLS_TESTAPPS} \
-    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
-    alsa-utils \
-    alsa-tools \
-    dosfstools \
-    evtest \
-    e2fsprogs-mke2fs \
-    fsl-rc-local \
-    gst-plugins-base-tcp \
-    i2c-tools \
-    imx-test \
-    iproute2 \
-    memtester \
-    python-subprocess \
-    python-datetime \
-    python-json \
-    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
-    ethtool \
-    mtd-utils \
-    mtd-utils-ubifs \
-"
-
-RDEPENDS_${PN}-tools-benchmark = " \
-    lmbench \
-    bonnie++ \
-    dbench \
-    fio \
-    iozone3 \
-    iperf \
-    nbench-byte \
-    tiobench \
-    "
-# Disabled as it has CRC problems in denzil branch
-#    cpuburn-neon
-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-gstreamer = "1"
-ALLOW_EMPTY_${PN}-tools-testapps = "1"
-ALLOW_EMPTY_${PN}-tools-benchmark = "1"
-
-PACKAGE_ARCH = "${MACHINE_ARCH}"

recipes-fsl/packagegroups/packagegroup-fsl.bb new file +89 -1

new file mode 100644
index 0000000..80ce5a4
@@ -0,0 +1,89 @@
+# Copyright (C) 2012-2013 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+PR = "r5"
+
+inherit packagegroup
+
+PROVIDES = "${PACKAGES}"
+PACKAGES += " \
+    ${PN}-gstreamer \
+    ${PN}-gstreamer-streamer \
+    ${PN}-tools-testapps \
+    ${PN}-tools-benchmark \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN}-gstreamer = " \
+    gst-meta-audio \
+    gst-meta-video \
+    gst-meta-debug \
+    gst-plugins-good-meta \
+    ${MACHINE_GSTREAMER_PLUGIN} \
+"
+
+RDEPENDS_${PN}-gstreamer-streamer = " \
+    ${PN}-gstreamer \
+    gst-plugins-good-udp \
+    gst-plugins-good-rtp \
+    gst-plugins-good-rtpmanager \
+    gst-plugins-good-rtsp \
+"
+
+SOC_TOOLS_TESTAPPS = ""
+SOC_TOOLS_TESTAPPS_mx5 = " \
+    amd-gpu-x11-bin-mx51 \
+"
+
+SOC_TOOLS_TESTAPPS_mx6 = " \
+    gpu-viv-bin-mx6q \
+"
+
+RDEPENDS_${PN}-tools-testapps = " \
+    ${SOC_TOOLS_TESTAPPS} \
+    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
+    alsa-utils \
+    alsa-tools \
+    dosfstools \
+    evtest \
+    e2fsprogs-mke2fs \
+    fsl-rc-local \
+    gst-plugins-base-tcp \
+    i2c-tools \
+    imx-test \
+    iproute2 \
+    memtester \
+    python-subprocess \
+    python-datetime \
+    python-json \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
+    ethtool \
+    mtd-utils \
+    mtd-utils-ubifs \
+"
+
+RDEPENDS_${PN}-tools-benchmark = " \
+    lmbench \
+    bonnie++ \
+    dbench \
+    fio \
+    iozone3 \
+    iperf \
+    nbench-byte \
+    tiobench \
+    "
+# Disabled as it has CRC problems in denzil branch
+#    cpuburn-neon
+
+ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-gstreamer = "1"
+ALLOW_EMPTY_${PN}-tools-testapps = "1"
+ALLOW_EMPTY_${PN}-tools-benchmark = "1"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
--

1.8.3.2

_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

[email protected]

author

2014-01-24 23:46 UTC #5 lore raw

PATCH 2/3 packagegroup-fsl: split packagegroup into multiple recipes

In reply to [email protected]

From: Rogerio Nunes <[email protected]>

A single packagegroup recipe with multiple packagegroups inside results in the execution of a huge amount of tasks when any image that includes at least one packagegroup is baked.

This patch splits the packagegroup-fsl recipe into multiple recipes. As a consequence, only tasks related to recipes actually used in an image have tasks added to the execution queue.

Change-Id I9a8cd438337caa5601fd4e904c76ed2e8b5dca36

Signed-off-by Rogerio Nunes <[email protected]>

---
 .../packagegroups/packagegroup-fsl-gstreamer.bb    | 33 ++++++++
 .../packagegroup-fsl-tools-benchmark.bb            | 20 +++++
 .../packagegroup-fsl-tools-testapps.bb             | 45 +++++++++++
 recipes-fsl/packagegroups/packagegroup-fsl.bb      | 89 ----------------------
 4 files changed, 98 insertions(+), 89 deletions(-)
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
 delete mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb

recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb new file +33 -0

new file mode 100644
index 0000000..c071e75
@@ -0,0 +1,33 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - gstreamer"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+PACKAGES += " \
+    ${PN}-streamer \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN} = " \
+    gst-meta-audio \
+    gst-meta-video \
+    gst-meta-debug \
+    gst-plugins-good-meta \
+    ${MACHINE_GSTREAMER_PLUGIN} \
+"
+
+RDEPENDS_${PN}-streamer = " \
+    ${PN} \
+    gst-plugins-good-udp \
+    gst-plugins-good-rtp \
+    gst-plugins-good-rtpmanager \
+    gst-plugins-good-rtsp \
+"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"

recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb new file +20 -0

new file mode 100644
index 0000000..dadefb7
@@ -0,0 +1,20 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - tools/benchmark"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+RDEPENDS_${PN} = " \
+    lmbench \
+    bonnie++ \
+    dbench \
+    fio \
+    iozone3 \
+    iperf \
+    nbench-byte \
+    tiobench \
+"

recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb new file +45 -0

45 lines not on this page · raw message

recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 ~~-89~~

89 lines not on this page · raw message

Signature · 1 line

1.8.3.2

Daiane Angolini

2014-01-25 19:21 UTC #6 lore raw

Re: [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes

Quoted 218 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:

From: Rogerio Nunes <[email protected]>

A single packagegroup recipe with multiple packagegroups inside results in the execution of a huge amount of tasks when any image that includes at least one packagegroup is baked.

This patch splits the packagegroup-fsl recipe into multiple recipes. As a consequence, only tasks related to recipes actually used in an image have tasks added to the execution queue.

Change-Id I9a8cd438337caa5601fd4e904c76ed2e8b5dca36

Signed-off-by Rogerio Nunes <[email protected]>

---
 .../packagegroups/packagegroup-fsl-gstreamer.bb    | 33 ++++++++
 .../packagegroup-fsl-tools-benchmark.bb            | 20 +++++
 .../packagegroup-fsl-tools-testapps.bb             | 45 +++++++++++
 recipes-fsl/packagegroups/packagegroup-fsl.bb      | 89 ----------------------
 4 files changed, 98 insertions(+), 89 deletions(-)
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
 delete mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb

recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb new file +33 -0

new file mode 100644
index 0000000..c071e75
@@ -0,0 +1,33 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - gstreamer"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+PACKAGES += " \
+    ${PN}-streamer \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN} = " \
+    gst-meta-audio \
+    gst-meta-video \
+    gst-meta-debug \
+    gst-plugins-good-meta \
+    ${MACHINE_GSTREAMER_PLUGIN} \
+"
+
+RDEPENDS_${PN}-streamer = " \
+    ${PN} \
+    gst-plugins-good-udp \
+    gst-plugins-good-rtp \
+    gst-plugins-good-rtpmanager \
+    gst-plugins-good-rtsp \
+"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"

recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb new file +20 -0

new file mode 100644
index 0000000..dadefb7
@@ -0,0 +1,20 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - tools/benchmark"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+RDEPENDS_${PN} = " \
+    lmbench \
+    bonnie++ \
+    dbench \
+    fio \
+    iozone3 \
+    iperf \
+    nbench-byte \
+    tiobench \
+"

recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb new file +45 -0

new file mode 100644
index 0000000..8643991
@@ -0,0 +1,45 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - tools/testapps"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+SOC_TOOLS_TESTAPPS = ""
+SOC_TOOLS_TESTAPPS_mx5 = " \
+    amd-gpu-x11-bin-mx51 \
+"
+
+SOC_TOOLS_TESTAPPS_mx6 = " \
+    gpu-viv-bin-mx6q \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN} = " \
+    ${SOC_TOOLS_TESTAPPS} \
+    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
+    alsa-utils \
+    alsa-tools \
+    dosfstools \
+    evtest \
+    e2fsprogs-mke2fs \
+    fsl-rc-local \
+    gst-plugins-base-tcp \
+    i2c-tools \
+    imx-test \
+    iproute2 \
+    memtester \
+    python-subprocess \
+    python-datetime \
+    python-json \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
+    ethtool \
+    mtd-utils \
+    mtd-utils-ubifs \
+"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"

recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 ~~-72~~

deleted file mode 100644
index 80ce5a4..0000000
@@ -1,89 +0,0 @@
-# Copyright (C) 2012-2013 Freescale Semiconductor
-# Released under the MIT license (see COPYING.MIT for the terms)
-
-DESCRIPTION = "Freescale package group"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
-                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-
-PR = "r5"
-
-inherit packagegroup
-
-PROVIDES = "${PACKAGES}"
-PACKAGES += " \
-    ${PN}-gstreamer \
-    ${PN}-gstreamer-streamer \
-    ${PN}-tools-testapps \
-    ${PN}-tools-benchmark \
-"
-
-MACHINE_GSTREAMER_PLUGIN ?= ""
-
-RDEPENDS_${PN}-gstreamer = " \
-    gst-meta-audio \
-    gst-meta-video \
-    gst-meta-debug \
-    gst-plugins-good-meta \
-    ${MACHINE_GSTREAMER_PLUGIN} \
-"
-
-RDEPENDS_${PN}-gstreamer-streamer = " \
-    ${PN}-gstreamer \
-    gst-plugins-good-udp \
-    gst-plugins-good-rtp \
-    gst-plugins-good-rtpmanager \
-    gst-plugins-good-rtsp \
-"
-
-SOC_TOOLS_TESTAPPS = ""
-SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
-"
-
-SOC_TOOLS_TESTAPPS_mx6 = " \
-    gpu-viv-bin-mx6q \
-"
-
-RDEPENDS_${PN}-tools-testapps = " \
-    ${SOC_TOOLS_TESTAPPS} \
-    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
-    alsa-utils \
-    alsa-tools \
-    dosfstools \
-    evtest \
-    e2fsprogs-mke2fs \
-    fsl-rc-local \
-    gst-plugins-base-tcp \
-    i2c-tools \
-    imx-test \
-    iproute2 \
-    memtester \
-    python-subprocess \
-    python-datetime \
-    python-json \
-    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
-    ethtool \
-    mtd-utils \
-    mtd-utils-ubifs \
-"
-
-RDEPENDS_${PN}-tools-benchmark = " \
-    lmbench \

recipes-fsl/packagegroups/packagegroup-fsl.bb line 82

Quoted 10 lines

recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 ~~-10~~

-    bonnie++ \
-    dbench \
-    fio \
-    iozone3 \
-    iperf \
-    nbench-byte \
-    tiobench \
-    "
-# Disabled as it has CRC problems in denzil branch
-#    cpuburn-neon

You have dropped this comment with no note on commit log

recipes-fsl/packagegroups/packagegroup-fsl.bb line 87

Quoted 5 lines

recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 -5

-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-gstreamer = "1"
-ALLOW_EMPTY_${PN}-tools-testapps = "1"
-ALLOW_EMPTY_${PN}-tools-benchmark = "1"

You have dropped all the "allow_empty" with no reason on commit log. It made me think, what the reason for the ALLOW_EMPTY here? (anyway, please add a note on commit log for those things being dropped)

Daiane

Quoted 9 lines

recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 -3
-
-PACKAGE_ARCH = "${MACHINE_ARCH}"
--
1.8.3.2
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

Rogerio Nunes

author

2014-01-25 20:23 UTC #7 lore raw

Re: [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes

Quoted 223 lines · Daiane Angolini

Quoted 222 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:

From: Rogerio Nunes <[email protected]>

A single packagegroup recipe with multiple packagegroups inside results in the execution of a huge amount of tasks when any image that includes at least one packagegroup is baked.

This patch splits the packagegroup-fsl recipe into multiple recipes. As a consequence, only tasks related to recipes actually used in an image have tasks added to the execution queue.

Change-Id I9a8cd438337caa5601fd4e904c76ed2e8b5dca36

Signed-off-by Rogerio Nunes <[email protected]>

---
 .../packagegroups/packagegroup-fsl-gstreamer.bb    | 33 ++++++++
 .../packagegroup-fsl-tools-benchmark.bb            | 20 +++++
 .../packagegroup-fsl-tools-testapps.bb             | 45 +++++++++++
 recipes-fsl/packagegroups/packagegroup-fsl.bb      | 89 ----------------------
 4 files changed, 98 insertions(+), 89 deletions(-)
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
 delete mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb

recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb new file +33 -0

new file mode 100644
index 0000000..c071e75
@@ -0,0 +1,33 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - gstreamer"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+PACKAGES += " \
+    ${PN}-streamer \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN} = " \
+    gst-meta-audio \
+    gst-meta-video \
+    gst-meta-debug \
+    gst-plugins-good-meta \
+    ${MACHINE_GSTREAMER_PLUGIN} \
+"
+
+RDEPENDS_${PN}-streamer = " \
+    ${PN} \
+    gst-plugins-good-udp \
+    gst-plugins-good-rtp \
+    gst-plugins-good-rtpmanager \
+    gst-plugins-good-rtsp \
+"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"

recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb new file +20 -0

new file mode 100644
index 0000000..dadefb7
@@ -0,0 +1,20 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - tools/benchmark"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+RDEPENDS_${PN} = " \
+    lmbench \
+    bonnie++ \
+    dbench \
+    fio \
+    iozone3 \
+    iperf \
+    nbench-byte \
+    tiobench \
+"

recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb new file +45 -0

new file mode 100644
index 0000000..8643991
@@ -0,0 +1,45 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - tools/testapps"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+SOC_TOOLS_TESTAPPS = ""
+SOC_TOOLS_TESTAPPS_mx5 = " \
+    amd-gpu-x11-bin-mx51 \
+"
+
+SOC_TOOLS_TESTAPPS_mx6 = " \
+    gpu-viv-bin-mx6q \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN} = " \
+    ${SOC_TOOLS_TESTAPPS} \
+    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
+    alsa-utils \
+    alsa-tools \
+    dosfstools \
+    evtest \
+    e2fsprogs-mke2fs \
+    fsl-rc-local \
+    gst-plugins-base-tcp \
+    i2c-tools \
+    imx-test \
+    iproute2 \
+    memtester \
+    python-subprocess \
+    python-datetime \
+    python-json \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
+    ethtool \
+    mtd-utils \
+    mtd-utils-ubifs \
+"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"

recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 ~~-76~~

deleted file mode 100644
index 80ce5a4..0000000
@@ -1,89 +0,0 @@
-# Copyright (C) 2012-2013 Freescale Semiconductor
-# Released under the MIT license (see COPYING.MIT for the terms)
-
-DESCRIPTION = "Freescale package group"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
-                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-
-PR = "r5"
-
-inherit packagegroup
-
-PROVIDES = "${PACKAGES}"
-PACKAGES += " \
-    ${PN}-gstreamer \
-    ${PN}-gstreamer-streamer \
-    ${PN}-tools-testapps \
-    ${PN}-tools-benchmark \
-"
-
-MACHINE_GSTREAMER_PLUGIN ?= ""
-
-RDEPENDS_${PN}-gstreamer = " \
-    gst-meta-audio \
-    gst-meta-video \
-    gst-meta-debug \
-    gst-plugins-good-meta \
-    ${MACHINE_GSTREAMER_PLUGIN} \
-"
-
-RDEPENDS_${PN}-gstreamer-streamer = " \
-    ${PN}-gstreamer \
-    gst-plugins-good-udp \
-    gst-plugins-good-rtp \
-    gst-plugins-good-rtpmanager \
-    gst-plugins-good-rtsp \
-"
-
-SOC_TOOLS_TESTAPPS = ""
-SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
-"
-
-SOC_TOOLS_TESTAPPS_mx6 = " \
-    gpu-viv-bin-mx6q \
-"
-
-RDEPENDS_${PN}-tools-testapps = " \
-    ${SOC_TOOLS_TESTAPPS} \
-    ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
-    alsa-utils \
-    alsa-tools \
-    dosfstools \
-    evtest \
-    e2fsprogs-mke2fs \
-    fsl-rc-local \
-    gst-plugins-base-tcp \
-    i2c-tools \
-    imx-test \
-    iproute2 \
-    memtester \
-    python-subprocess \
-    python-datetime \
-    python-json \
-    ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
-    ethtool \
-    mtd-utils \
-    mtd-utils-ubifs \
-"
-
-RDEPENDS_${PN}-tools-benchmark = " \
-    lmbench \
-    bonnie++ \
-    dbench \
-    fio \
-    iozone3 \

Quoted 9 lines

recipes-fsl/packagegroups/packagegroup-fsl.bb line 82
Quoted 6 lines
recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 -6
-    iperf \
-    nbench-byte \
-    tiobench \
-    "
-# Disabled as it has CRC problems in denzil branch
-#    cpuburn-neon
You have dropped this comment with no note on commit log

Sorry that I didn't bring this comment along. The idea now with the recipes split is to review
the RDEPEDS for the packages, and also to create/reorg the recipes to better fit image requirements.
One question though, why cpuburn-neon is still commented out for a problem in denzil?
I kind of assumed that being still a comment after dylan and dora it was not that necessary :)

Quoted 10 lines

recipes-fsl/packagegroups/packagegroup-fsl.bb line 87
Quoted 5 lines
recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 -5
-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-gstreamer = "1"
-ALLOW_EMPTY_${PN}-tools-testapps = "1"
-ALLOW_EMPTY_${PN}-tools-benchmark = "1"
You have dropped all the "allow_empty" with no reason on commit log. It made me think, what the reason for the ALLOW_EMPTY here? (anyway, please add a note on commit log for those things being dropped)

The packagegroup class sets ALLOW_EMPTY variables automatically for all packages listed in the
PACKAGES variable in the recipe.

Quoted 13 lines

Daiane
Quoted 9 lines
recipes-fsl/packagegroups/packagegroup-fsl.bb deleted +0 -3
-
-PACKAGE_ARCH = "${MACHINE_ARCH}"
--
1.8.3.2
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

Otavio Salvador

2014-01-25 21:51 UTC #8 lore raw

Re: [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes

Quoted 4 lines · Rogerio Nunes

One question though, why cpuburn-neon is still commented out for a problem in denzil?
I kind of assumed that being still a comment after dylan and dora it was not that necessary :)

This were commented because it had broken source; it has been fixed but nobody recall to re-enable it.

You can send a patch adding it back but you need to also do it conditionally as not all SoC support NEON and if not supported we ought to use cpuburn instead.

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

[email protected]

author

2014-01-24 23:46 UTC #9 lore raw

PATCH 3/3 packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11

In reply to [email protected]

From: Rogerio Nunes <[email protected]>

Package amd-gpu-x11-bin-mx51 only works if X11 is in DISTRO_FEATURES, and it should not be installed otherwise.

Change-Id I526018066de9b7a7d4fd29c65833e5d5d2487884

Signed-off-by Rogerio Nunes <[email protected]>

---
 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb +1 -1

index 8643991..1fc88e8 100644
@@ -10,7 +10,7 @@ inherit packagegroup
 
 SOC_TOOLS_TESTAPPS = ""
 SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
 "
 
 SOC_TOOLS_TESTAPPS_mx6 = " \

Signature · 1 line

1.8.3.2

Otavio Salvador

2014-01-25 18:48 UTC #10 lore raw

Re: [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11

Hello Rogerio,

Quoted 16 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:

From: Rogerio Nunes <[email protected]>
Package amd-gpu-x11-bin-mx51 only works if X11 is in DISTRO_FEATURES, and it should not be installed otherwise.
Change-Id I526018066de9b7a7d4fd29c65833e5d5d2487884
Signed-off-by Rogerio Nunes <[email protected]>
---
 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb +0 -0
index 8643991..1fc88e8 100644

recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb inherit packagegroup · line 14

Quoted 6 lines

recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb +1 -1

@@ -10,7 +10,7 @@ inherit packagegroup
 
 SOC_TOOLS_TESTAPPS = ""
 SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
 "

This will fail at parsing; you forgot the add the \ at end of line.

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Otavio Salvador

2014-01-25 18:49 UTC #11 lore raw

Re: [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11

Quoted 20 lines · Otavio Salvador

Hello Rogerio,
Quoted 17 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:
From: Rogerio Nunes <[email protected]>
Package amd-gpu-x11-bin-mx51 only works if X11 is in DISTRO_FEATURES, and it should not be installed otherwise.
Change-Id I526018066de9b7a7d4fd29c65833e5d5d2487884
Signed-off-by Rogerio Nunes <[email protected]>
---
 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb +0 -0
index 8643991..1fc88e8 100644
@@ -10,7 +10,7 @@ inherit packagegroup
 

Quoted 7 lines

recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb inherit packagegroup · line 14
Quoted 5 lines
recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb +1 -1
 SOC_TOOLS_TESTAPPS = ""
 SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
 "
This will fail at parsing; you forgot the add the \ at end of line.

I fixed it locally.

Signature · 3 lines

Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Rogerio Nunes

author

2014-01-25 18:57 UTC #12 lore raw

Re: [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11

Quoted 31 lines · Otavio Salvador

Quoted 20 lines · Otavio Salvador
Hello Rogerio,
Quoted 17 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:
From: Rogerio Nunes <[email protected]>
Package amd-gpu-x11-bin-mx51 only works if X11 is in DISTRO_FEATURES, and it should not be installed otherwise.
Change-Id I526018066de9b7a7d4fd29c65833e5d5d2487884
Signed-off-by Rogerio Nunes <[email protected]>
---
 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb +0 -0
index 8643991..1fc88e8 100644
@@ -10,7 +10,7 @@ inherit packagegroup
 
Quoted 7 lines
recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb inherit packagegroup · line 14
Quoted 5 lines
recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb +1 -1
 SOC_TOOLS_TESTAPPS = ""
 SOC_TOOLS_TESTAPPS_mx5 = " \
-    amd-gpu-x11-bin-mx51 \
+    ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
 "
This will fail at parsing; you forgot the add the \ at end of line.

Quoted 1 line

I fixed it locally.

Thanks!! V2 was ready just in case :)

Quoted 5 lines

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750

Daiane Angolini

2014-01-25 19:12 UTC #13 lore raw

In reply to [email protected]

Quoted 12 lines · On Fri, Jan 24, 2014 at 9:45 PM, <[email protected]> wrote:

From: Rogerio Nunes <[email protected]>
This patchset refactors the packagegroup recipe, spliting it in smaller recipes.
With this approach, it will be easier to organize the inclusion of more packagegroups, and also to re-organize packages already grouped in one of the current groups.
This is not only about code refactoring tough. We will have better scalablity also in build time.

Quoted 6 lines

When a single packagegroup from a recipe that includes multiple packagegroups is added to one image, all the tasks to build all the packages from the same recipe file are added to the execution queue. In other words, if you need only one of the packagegroups from a big recipe file in your image, currently you are paying a high price in terms of build time for this convenience.

I'm going to star the review (so, I haven't seem the patches yet), I hope you have included this
info on your commit log.

Quoted 4 lines

Longer term, I hope we will be able to have a better set of reference images in this layer, from small ones that can be built faster, to more complete images full of features.

I agree, and I hope we can get this for 1.6

Daiane

Quoted 26 lines

Regards.
Rogerio Nunes (3):
packagegroup: rename to packagegroups
packagegroup-fsl: split packagegroup into multiple recipes packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with
    X11
 recipes-fsl/packagegroup/packagegroup-fsl.bb       | 89 ----------------------
 .../packagegroups/packagegroup-fsl-gstreamer.bb    | 33 ++++++++
 .../packagegroup-fsl-tools-benchmark.bb            | 20 +++++
 .../packagegroup-fsl-tools-testapps.bb             | 45 +++++++++++
 4 files changed, 98 insertions(+), 89 deletions(-)
 delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
 create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
--
1.8.3.2
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale