Skip to contentSkip to conversation

hummingboard: Return from cpu_eth_init() directly

PATCH New Fabio Estevam 2 participants 2 messages Jan 25, 2014 – Feb 11, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hummingboard: Return from cpu_eth_init() directly

From: Fabio Estevam <[email protected]>

There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it.

In order to simplify the code, just return the value from cpu_eth_init(bis) directly.

---
 board/solidrun/hummingboard/hummingboard.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
board/solidrun/hummingboard/hummingboard.c +1 -5
index 8b309b4..2e2fb2a 100644
@@ -156,11 +156,7 @@ int board_eth_init(bd_t *bis)
 
 	setup_iomux_enet();
 
-	ret = cpu_eth_init(bis);
-	if (ret)
-		printf("FEC MXC: %s:failed\n", __func__);
-
-	return ret;
+	return cpu_eth_init(bis);
 }
 #endif
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 hummingboard: Return from cpu_eth_init() directly

Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

There is no need to print an error message when cpu_eth_init() fails because net/eth.c already prints it.

In order to simplify the code, just return the value from cpu_eth_init(bis) directly.

---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================