drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters
Subsystems (2)
PATCH 1/1 drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters
Having to use i915.i915_foo is inconsistent and a bit on the verbose side. Drop the prefix per Daniel's request, who also says this is not ABI we need to maintain.
Signed-off-by Jani Nikula <[email protected]>
--- drivers/gpu/drm/i915/i915_params.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_params.c +6 -6
@@ -68,16 +68,16 @@ MODULE_PARM_DESC(semaphores,"Use semaphores for inter-ring sync " "(default: -1 (use per-chip defaults))"); -module_param_named (i915_enable_rc6, i915.enable_rc6, int,0400 ); -MODULE_PARM_DESC (i915_enable_rc6, +module_param_named (enable_rc6, i915.enable_rc6, int,0400 ); +MODULE_PARM_DESC (enable_rc6,"Enable power-saving render C-state 6. " "Different stages can be selected via bitmask values " "(0 = disable; 1 = enable rc6; 2 = enable deep rc6; 4 = enable deepest rc6). " "For example, 3 would enable rc6 and deep rc6, and 7 would enable everything. " "default: -1 (use per-chip default)" ); -module_param_named (i915_enable_fbc, i915.enable_fbc, int,0600 ); -MODULE_PARM_DESC (i915_enable_fbc, +module_param_named (enable_fbc, i915.enable_fbc, int,0600 ); +MODULE_PARM_DESC (enable_fbc,"Enable frame buffer compression for power savings " "(default: -1 (use per-chip default))" );
@@ -110,8 +110,8 @@ MODULE_PARM_DESC(enable_hangcheck,"WARNING: Disabling this can cause system wide hangs. " "(default: true)"); -module_param_named (i915_enable_ppgtt, i915.enable_ppgtt, int,0400 ); -MODULE_PARM_DESC (i915_enable_ppgtt, +module_param_named (enable_ppgtt, i915.enable_ppgtt, int,0400 ); +MODULE_PARM_DESC (enable_ppgtt,"Override PPGTT usage. " "(-1=auto [default], 0=disabled, 1=aliasing, 2=full)" );
Signature · 1 line
1.7.10.4
Quoted 5 lines · Jani Nikula
Having to use i915.i915_foo is inconsistent and a bit on the verbose side. Drop the prefix per Daniel's request, who also says this is not ABI we need to maintain.
Signed-off-by Jani Nikula <[email protected]>
Queued for -next, thanks for the patch. And yeah, I consider breaking users of these options a feature, hopefully that gives us a few useful bug reports ;-)
-Daniel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch