nfs: fix setting of ACLs on file creation.
Subsystems (3)
PATCH 1/1 nfs: fix setting of ACLs on file creation.
From: Noah Massey <[email protected]>
nfs3_get_acl() tries to skip posix equivalent ACLs, but misinterprets the return value of posix_acl_equiv_mode(). Fix it.
This is a regression introduced by
"nfs: use generic posix ACL infrastructure for v3 Posix ACLs"
--- fs/nfs/nfs3acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nfs/nfs3acl.c +1 -1
@@ -80,7 +80,7 @@ struct posix_acl *nfs3_get_acl(struct inode *inode, int type) }if (res.acl_access !=NULL ) { -if (posix_acl_equiv_mode (res.acl_access,NULL ) || +if ((posix_acl_equiv_mode (res.acl_access,NULL ) ==0 ) || res.acl_access->a_count ==0 ) {posix_acl_release (res.acl_access); res.acl_access =NULL ;
Signature · 1 line
1.8.5.3
A message that is not in the archive (sent off-list or not yet received): 1391135472-9639-1-git-send-email-Noah.Massey-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Christoph Hellwig
Reviewed-byQuoted 7 lines · Noah Massey
From: Noah Massey <[email protected]>
nfs3_get_acl()tries to skip posix equivalent ACLs, but misinterprets the return value ofposix_acl_equiv_mode(). Fix it.This is a regression introduced by
"nfs: use generic posix ACL infrastructure for v3 Posix ACLs"
Thanks for catching this Noah!
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html