Skip to contentSkip to conversation

target: Simplify command completion by removing CMD_T_FAILED flag

PATCH New Roland Dreier 1 participant 1 message Feb 3, 2014

Subsystems (2)
SCSI SCSI target
lore
Share & tools
lore

Roland Dreier

author
#0 lore raw

PATCH 1/1 target: Simplify command completion by removing CMD_T_FAILED flag

From: Roland Dreier <[email protected]>

The CMD_T_FAILED flag is set used in one place to record the result of a trivial test, and it is only tested once, few lines later. We might as well make the code simpler and easier to read by directly doing the test of "success" where we want to use it.

Signed-off-by Roland Dreier <[email protected]>
---
 drivers/target/target_core_transport.c | 5 +----
 include/target/target_core_base.h      | 1 -
 2 files changed, 1 insertion(+), 5 deletions(-)
drivers/target/target_core_transport.c +1 -4
index c50fd9f11aab..24b4f65d8777 100644
@@ -669,9 +669,6 @@ void target_complete_cmd(struct se_cmd *cmd, u8 scsi_status)
 		return;
 	}
 
-	if (!success)
-		cmd->transport_state |= CMD_T_FAILED;
-
 	/*
 	 * Check for case where an explicit ABORT_TASK has been received
 	 * and transport_wait_for_tasks() will be waiting for completion..

@@ -681,7 +678,7 @@ void target_complete_cmd(struct se_cmd *cmd, u8 scsi_status)
 		spin_unlock_irqrestore(&cmd->t_state_lock, flags);
 		complete(&cmd->t_transport_stop_comp);
 		return;
-	} else if (cmd->transport_state & CMD_T_FAILED) {
+	} else if (!success) {
 		INIT_WORK(&cmd->work, target_complete_failure_work);
 	} else {
 		INIT_WORK(&cmd->work, target_complete_ok_work);
include/target/target_core_base.h +0 -1
index c9c791209cd1..1772fadcff62 100644
@@ -525,7 +525,6 @@ struct se_cmd {
 #define CMD_T_COMPLETE		(1 << 2)
 #define CMD_T_SENT		(1 << 4)
 #define CMD_T_STOP		(1 << 5)
-#define CMD_T_FAILED		(1 << 6)
 #define CMD_T_DEV_ACTIVE	(1 << 7)
 #define CMD_T_REQUEST_STOP	(1 << 8)
 #define CMD_T_BUSY		(1 << 9)
Signature · 1 line
1.9.rc1