xen-netfront: handle backend CLOSED without CLOSING
Subsystems (3)
PATCH 1/1 xen-netfront: handle backend CLOSED without CLOSING
From: David Vrabel <[email protected]>
Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown.
So, treat an unexpected backend CLOSED state the same as CLOSING.
---
Cc: [email protected]
Cc: "David S. Miller" <[email protected]>
--- drivers/net/xen-netfront.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/net/xen-netfront.c +4 -1
@@ -1832,7 +1832,6 @@ static void netback_changed(struct xenbus_device *dev,case XenbusStateReconfiguring:case XenbusStateReconfigured:case XenbusStateUnknown: -case XenbusStateClosed:break ;case XenbusStateInitWait:
@@ -1847,6 +1846,10 @@ static void netback_changed(struct xenbus_device *dev,netdev_notify_peers (netdev);break ; +case XenbusStateClosed: +if (dev->state == XenbusStateClosed) +break ; +/* Missed the backend's CLOSING state -- fallthrough */ case XenbusStateClosing:xenbus_frontend_closed (dev);break ;
Signature · 1 line
1.7.2.5
From: David Vrabel <[email protected]>
Date: Tue, 4 Feb 2014 18:50:26 +0000
Quoted 10 lines
From: David Vrabel <[email protected]>
Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown.
So, treat an unexpected backend CLOSED state the same as CLOSING.
Signed-off-by David Vrabel <[email protected]>
Applied, thanks.
From: David Vrabel <[email protected]>
Date: Tue, 4 Feb 2014 18:50:26 +0000
Quoted 10 lines
From: David Vrabel <[email protected]>
Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown.
So, treat an unexpected backend CLOSED state the same as CLOSING.
Signed-off-by David Vrabel <[email protected]>
Applied, thanks.