Skip to contentSkip to conversation

xen-blkfront: handle backend CLOSED without CLOSING

PATCH New David Vrabel 1 participant 1 message Feb 4, 2014

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen-blkfront: handle backend CLOSED without CLOSING

From: David Vrabel <[email protected]>

Backend drivers shouldn't transistion to CLOSED unless the frontend is CLOSED. If a backend does transition to CLOSED too soon then the frontend may not see the CLOSING state and will not properly shutdown.

So, treat an unexpected backend CLOSED state the same as CLOSING.

---
Cc: Jens Axboe <[email protected]>

---
 drivers/block/xen-blkfront.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/block/xen-blkfront.c +4 -1
index 8dcfb54..0471d63 100644
@@ -1904,13 +1904,16 @@ static void blkback_changed(struct xenbus_device *dev,
 	case XenbusStateReconfiguring:
 	case XenbusStateReconfigured:
 	case XenbusStateUnknown:
-	case XenbusStateClosed:
 		break;
 
 	case XenbusStateConnected:
 		blkfront_connect(info);
 		break;
 
+	case XenbusStateClosed:
+		if (dev->state == XenbusStateClosed)
+			break;
+		/* Missed the backend's Closing state -- fallthrough */
 	case XenbusStateClosing:
 		blkfront_closing(info);
 		break;
Signature · 1 line
1.7.2.5