ti-csl: new recipe providing CSL for TI-KeyStone2 devices -This package provides chip support library interface files
PATCH 1/1 ti-csl: new recipe providing CSL for TI-KeyStone2 devices -This package provides chip support library interface files
--- meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb | 27 ++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +27 -0
@@ -0,0 +1,27 @@ +DESCRIPTION = "TI CSL" +LICENSE = "TI BSD" +LIC_FILES_CHKSUM = "file://COPYING.txt;md5=5857833e20836213677fac33f9aded21" + +COMPATIBLE_MACHINE = "keystone-evm" +ALLOW_EMPTY_${PN} = "1" + +PR = "r1" +BRANCH="master" +LLD-NAME="csl" +SRC_URI = "git://git.ti.com/keystone-rtos/common-csl-ip.git;protocol=git;branch=${BRANCH}" + +S = "${WORKDIR}/git" +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17 +SRCREV = "f6f90144c14e1ee783c4b893b52e54830be8166e" + +do_install () { + install -d ${D}/${includedir}/ti/csl + cp -r ${S}/* ${D}/${includedir}/ti/csl +# Retain only header files + cd ${D}/${includedir}/ti/csl + find . \( -name "*.xdt" -o -name "*.bld" -o -name "*.bat" -o -name "*.c" -o -name "*.xdc" -o -name "*.asm" -o -name "*.xs" \) | xargs rm -rf + rm -rf build docs + mkdir -p src/ip/serdes_sb + cp -r ${S}/src/ip/serdes_sb/V0 src/ip/serdes_sb +} +
Signature · 1 line
1.7.9.5
Quoted 9 lines
-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Aravind Batni
Sent: Tuesday, February 04, 2014 4:40 PM
To: [email protected]; Nelson, Sam
Cc: Aravind Batni
Subject: [meta-arago] [PATCH] ti-csl: new recipe providing CSL for TI-KeyStone2 devices -This package provides chip support library interface files
Thanks for the submission. Some review comments below.
This looks like a malformed commit message
Quoted 16 lines
Signed-off-by Aravind Batni <[email protected]>---
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb | 27
++++++++++++++++++++1 file changed, 27 insertions(+)create mode 100644 meta-arago-extras/recipes-bsp/ti-csl/ti- csl_git.bb
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +0
-0
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 2
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0@@ -0,0 +1,27 @@ +DESCRIPTION = "TI CSL" +LICENSE = "TI BSD"
Any reason this can't just be BSD?
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 6
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +1
-0+LIC_FILES_CHKSUM ="file://COPYING.txt;md5=5857833e20836213677fac33f9aded21"
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+ +COMPATIBLE_MACHINE = "keystone-evm" +ALLOW_EMPTY_${PN} = "1"
Why do you want an empty package? Judging from below this is because you are only trying to install headers right and those will be part of the dev package? Just want to make sure I understand your purpose here.
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ +PR = "r1"
Start with r0
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 10
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+BRANCH="master" +LLD-NAME="csl"
Unused variable?
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 15
Quoted 6 lines
+SRC_URI = "
git://git.ti.com/keystone-rtos/common-csl-ip.git;protocol=git;branch=${BRANCH}"meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +4
-0+ +S = "${WORKDIR}/git" +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17 +SRCREV = "f6f90144c14e1ee783c4b893b52e54830be8166e"
Just a nitpick but this would make more sense being declared before the SRC_URI line. Next to the BRANCH setting.
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 19
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +4
-0+ +do_install () { + install -d ${D}/${includedir}/ti/csl + cp -r ${S}/* ${D}/${includedir}/ti/csl
Use install command. Also, no need for the / between ${D} and ${includedir}
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-1+# Retain only header files + cd ${D}/${includedir}/ti/csl + find . \( -name "*.xdt" -o -name "*.bld" -o -name "*.bat" -o -name "*.c" -o -name "*.xdc" -o -name "*.asm" -o -name "*.xs" \) |xargs rm -rf
This seems kludgy. Why not just find all the .h files and then install those with a for loop?
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 24
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ rm -rf build docs + mkdir -p src/ip/serdes_sb
Implicit assumption that you are in a certain directory. Please reference everything from ${D}
Quoted 1 line
+ cp -r ${S}/src/ip/serdes_sb/V0 src/ip/serdes_sb
Same comment about the assumption of directory location.
Quoted 9 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-1+} + --1.7.9.5
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
Thanks for the feedback. See response in-lined.
-Best Regards,
Aravind
Quoted 30 lines
-----Original Message-----
From: Maupin, Chase
Sent: Tuesday, February 04, 2014 5:37 PM
To: Aravind Batni; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providing CSL for TI- KeyStone2 devices -This package provides chip support library interface filesQuoted 9 lines
-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Aravind Batni
Sent: Tuesday, February 04, 2014 4:40 PM
To: [email protected]; Nelson, Sam
Cc: Aravind Batni
Subject: [meta-arago] [PATCH] ti-csl: new recipe providing CSL for TI-KeyStone2 devices -This package provides chip support library interface filesThanks for the submission. Some review comments below.
This looks like a malformed commit message
Quoted 9 lines
Signed-off-by Aravind Batni <[email protected]>---
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb | 27
++++++++++++++++++++1 file changed, 27 insertions(+)create mode 100644 meta-arago-extras/recipes-bsp/ti-csl/ti- csl_git.bb
Quoted 12 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 2
Quoted 9 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0@@ -0,0 +1,27 @@ +DESCRIPTION = "TI CSL" +LICENSE = "TI BSD"Any reason this can't just be BSD?
[Aravind Batni] The components were approved by TI OSRB for TI BSD (has TI copyright statement on the top and BSD license text below). Not sure if we can change this to BSD
Quoted 10 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 6
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +1
-0+LIC_FILES_CHKSUM ="file://COPYING.txt;md5=5857833e20836213677fac33f9aded21"
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+ +COMPATIBLE_MACHINE = "keystone-evm" +ALLOW_EMPTY_${PN} = "1"Why do you want an empty package? Judging from below this is because you are only trying to install headers right and those will be part of the dev package? Just want to make sure I understand your purpose here.
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ +PR = "r1"Start with r0
[Aravind Batni] Fixed
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 10
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+BRANCH="master" +LLD-NAME="csl"Unused variable?
[Aravind Batni] Removed the unused variable
Quoted 10 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
Quoted 6 lines
+SRC_URI = "
git://git.ti.com/keystone-rtos/common-csl-ip.git;protocol=git;branch=${BRANCH}"meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +4
-0+ +S = "${WORKDIR}/git" +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17 SRCREV = +"f6f90144c14e1ee783c4b893b52e54830be8166e"Just a nitpick but this would make more sense being declared before the
SRC_URIline. Next to the BRANCH setting.
[Aravind Batni] Fixed
Quoted 7 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 19
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +4
-0+ +do_install () { + install -d ${D}/${includedir}/ti/csl + cp -r ${S}/* ${D}/${includedir}/ti/cslUse install command. Also, no need for the / between ${D} and ${includedir}
Quoted 12 lines
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-1+# Retain only header files + cd ${D}/${includedir}/ti/csl + find . \( -name "*.xdt" -o -name "*.bld" -o -name "*.bat" -o -name "*.c" -o -name "*.xdc" -o -name "*.asm" -o -name "*.xs" \) |xargs rm -rf
This seems kludgy. Why not just find all the .h files and then install those with a for loop?
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ rm -rf build docs + mkdir -p src/ip/serdes_sb
[Aravind Batni] How about something like this: find ${S} -name "*.h" -type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl
Quoted 7 lines
Implicit assumption that you are in a certain directory. Please reference everything from ${D}
Quoted 1 line
+ cp -r ${S}/src/ip/serdes_sb/V0 src/ip/serdes_sb
Same comment about the assumption of directory location.
[Aravind Batni] same as before: How about this: find ${S}/src/ip/serdes_sb/V0 -name "*.c" -type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl/src/ip/serdes_sb/V0
Quoted 9 lines
Quoted 9 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-1+} + --1.7.9.5
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
Quoted 30 lines
-----Original Message-----
From: Aravind Batni
Sent: Wednesday, February 05, 2014 12:33 PM
To: Maupin, Chase; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providing CSL for TI-KeyStone2 devices -This package provides chip support library interface filesThanks for the feedback. See response in-lined.
-Best Regards,
AravindQuoted 5 lines
-----Original Message-----
From: Maupin, Chase
Sent: Tuesday, February 04, 2014 5:37 PM
To: Aravind Batni; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providingCSL for TI-
Quoted 1 line
KeyStone2 devices -This package provides chip support library
interface files
Quoted 8 lines
Quoted 8 lines
-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Aravind Batni
Sent: Tuesday, February 04, 2014 4:40 PM
To: [email protected]; Nelson, Sam
Cc: Aravind Batni
Subject: [meta-arago] [PATCH] ti-csl: new recipe providing CSL
Quoted 8 lines
for
Quoted 1 line
Quoted 1 line
TI-KeyStone2 devices -This package provides chip support
library
Quoted 5 lines
Quoted 1 line
interface files
Thanks for the submission. Some review comments below.
This looks like a malformed commit message
Any comment here? Also, when you submit v2 be sure to add something like the below after your signed-off-by line:
---
* Updated in version 2
* change 1
* change 2
The --- above is important.
Quoted 22 lines
Quoted 10 lines
Quoted 10 lines
Signed-off-by Aravind Batni <[email protected]>---
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb | 27
++++++++++++++++++++1 file changed, 27 insertions(+)create mode 100644 meta-arago-extras/recipes-bsp/ti-csl/ti- csl_git.bb
Quoted 12 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 2
Quoted 9 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0@@ -0,0 +1,27 @@ +DESCRIPTION = "TI CSL" +LICENSE = "TI BSD"Any reason this can't just be BSD?
Quoted 3 lines
[Aravind Batni] The components were approved by TI OSRB for TI BSD (has TI copyright statement on the top and BSD license text below). Not sure if we can change this to BSD
OK
Quoted 11 lines
Quoted 7 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 6
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +1
-0+LIC_FILES_CHKSUM ="file://COPYING.txt;md5=5857833e20836213677fac33f9aded21"
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+ +COMPATIBLE_MACHINE = "keystone-evm" +ALLOW_EMPTY_${PN} = "1"Why do you want an empty package? Judging from below this is
because
Quoted 1 line
you are only trying to install headers right and those will be
part of the dev
Quoted 1 line
package? Just want to make sure I understand your purpose here.
Any comment here?
Quoted 44 lines
Quoted 6 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
Quoted 3 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ +PR = "r1"Start with r0
[Aravind Batni] Fixed
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 10
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+BRANCH="master" +LLD-NAME="csl"Unused variable?
[Aravind Batni] Removed the unused variable
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 14
Quoted 5 lines
+SRC_URI = "
git://git.ti.com/keystone-rtos/common-csl-ip.git;protocol=git;branch=${BRANCH}"meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+ +S = "${WORKDIR}/git" +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17SRCREV =
Quoted 3 lines
Quoted 1 line
+"f6f90144c14e1ee783c4b893b52e54830be8166e"
Just a nitpick but this would make more sense being declared
before the
Quoted 2 lines
SRC_URIline. Next to the BRANCH setting.[Aravind Batni] Fixed
Quoted 6 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 19
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +4
-0+ +do_install () { + install -d ${D}/${includedir}/ti/csl + cp -r ${S}/* ${D}/${includedir}/ti/cslUse install command. Also, no need for the / between ${D} and
${includedir}
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+# Retain only header files + cd ${D}/${includedir}/ti/csl + find . \( -name "*.xdt" -o -name "*.bld" -o -name "*.bat"-o
Quoted 1 line
Quoted 1 line
-name "*.c" -o -name "*.xdc" -o -name "*.asm" -o -name "*.xs"
\) |
Quoted 3 lines
Quoted 1 line
xargs rm -rf
This seems kludgy. Why not just find all the .h files and then
install those
Quoted 8 lines
Quoted 5 lines
with a for loop?
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ rm -rf build docs + mkdir -p src/ip/serdes_sb[Aravind Batni] How about something like this: find ${S} -name "*.h" -type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl
Seems OK to me
Quoted 20 lines
Quoted 1 line
Implicit assumption that you are in a certain directory. Please
reference
Quoted 6 lines
everything from ${D}
Quoted 1 line
+ cp -r ${S}/src/ip/serdes_sb/V0 src/ip/serdes_sb
Same comment about the assumption of directory location.
[Aravind Batni] same as before: How about this: find ${S}/src/ip/serdes_sb/V0 -name "*.c" -type f | xargs -I {} cp -- parents {} ${D}${includedir}/ti/csl/src/ip/serdes_sb/V0
Quoted 9 lines
Quoted 9 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-1+} + --1.7.9.5
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
Thanks for the quick response.
-Best Regards,
Aravind
Quoted 49 lines
-----Original Message-----
From: Maupin, Chase
Sent: Wednesday, February 05, 2014 12:50 PM
To: Aravind Batni; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providing CSL for TI- KeyStone2 devices -This package provides chip support library interface filesQuoted 30 lines
-----Original Message-----
From: Aravind Batni
Sent: Wednesday, February 05, 2014 12:33 PM
To: Maupin, Chase; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providing CSL for TI-KeyStone2 devices -This package provides chip support library interface filesThanks for the feedback. See response in-lined.
-Best Regards,
AravindQuoted 5 lines
-----Original Message-----
From: Maupin, Chase
Sent: Tuesday, February 04, 2014 5:37 PM
To: Aravind Batni; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providingCSL for TI-
Quoted 1 line
KeyStone2 devices -This package provides chip support library
interface files
Quoted 8 lines
Quoted 8 lines
-----Original Message-----
From: [email protected] [mailto:meta-arago- [email protected]] On Behalf Of Aravind Batni
Sent: Tuesday, February 04, 2014 4:40 PM
To: [email protected]; Nelson, Sam
Cc: Aravind Batni
Subject: [meta-arago] [PATCH] ti-csl: new recipe providing CSLQuoted 8 lines
for
Quoted 1 line
Quoted 1 line
TI-KeyStone2 devices -This package provides chip support
library
Quoted 5 lines
Quoted 1 line
interface files
Thanks for the submission. Some review comments below.
This looks like a malformed commit message
Any comment here? Also, when you submit v2 be sure to add something like the below after your signed-off-by line:
Quoted 7 lines
---
* Updated in version 2
* change 1
* change 2The --- above is important.
[Aravind Batni] Yes, we will fix the commit message
Quoted 35 lines
Quoted 22 lines
Quoted 10 lines
Quoted 10 lines
Signed-off-by Aravind Batni <[email protected]>---
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb | 27
++++++++++++++++++++1 file changed, 27 insertions(+)create mode 100644 meta-arago-extras/recipes-bsp/ti-csl/ti- csl_git.bb
Quoted 12 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 2
Quoted 9 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0@@ -0,0 +1,27 @@ +DESCRIPTION = "TI CSL" +LICENSE = "TI BSD"Any reason this can't just be BSD?
Quoted 3 lines
[Aravind Batni] The components were approved by TI OSRB for TI BSD (has TI copyright statement on the top and BSD license text below). Not sure if we can change this to BSD
OK
Quoted 7 lines
Quoted 7 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 6
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +1
-0+LIC_FILES_CHKSUM ="file://COPYING.txt;md5=5857833e20836213677fac33f9aded21"
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+ +COMPATIBLE_MACHINE = "keystone-evm" +ALLOW_EMPTY_${PN} = "1"Why do you want an empty package? Judging from below this is
Quoted 7 lines
Quoted 4 lines
because
Quoted 1 line
you are only trying to install headers right and those will be
part of the dev
Quoted 1 line
package? Just want to make sure I understand your purpose here.
Any comment here?
[Aravind Batni] Yes, this is only headers and some C source package and will be part of DEVKIT only. (nothing goes into the root file system).
Quoted 74 lines
Quoted 43 lines
Quoted 6 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
Quoted 3 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ +PR = "r1"Start with r0
[Aravind Batni] Fixed
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 10
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+BRANCH="master" +LLD-NAME="csl"Unused variable?
[Aravind Batni] Removed the unused variable
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 14
Quoted 5 lines
+SRC_URI = "
git://git.ti.com/keystone-rtos/common-csl-ip.git;protocol=git;branch=${BRANCH}"meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+ +S = "${WORKDIR}/git" +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17SRCREV =
Quoted 3 lines
Quoted 1 line
+"f6f90144c14e1ee783c4b893b52e54830be8166e"
Just a nitpick but this would make more sense being declared
before the
Quoted 2 lines
SRC_URIline. Next to the BRANCH setting.[Aravind Batni] Fixed
Quoted 6 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 19
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +4
-0+ +do_install () { + install -d ${D}/${includedir}/ti/csl + cp -r ${S}/* ${D}/${includedir}/ti/cslUse install command. Also, no need for the / between ${D} and
${includedir}
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+# Retain only header files + cd ${D}/${includedir}/ti/csl + find . \( -name "*.xdt" -o -name "*.bld" -o -name "*.bat"-o
Quoted 1 line
Quoted 1 line
-name "*.c" -o -name "*.xdc" -o -name "*.asm" -o -name "*.xs"
\) |
Quoted 3 lines
Quoted 1 line
xargs rm -rf
This seems kludgy. Why not just find all the .h files and then
Quoted 8 lines
install those
Quoted 5 lines
with a for loop?
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ rm -rf build docs + mkdir -p src/ip/serdes_sb[Aravind Batni] How about something like this: find ${S} -name "*.h" -type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl
Seems OK to me
Quoted 20 lines
Quoted 1 line
Implicit assumption that you are in a certain directory. Please
reference
Quoted 6 lines
everything from ${D}
Quoted 1 line
+ cp -r ${S}/src/ip/serdes_sb/V0 src/ip/serdes_sb
Same comment about the assumption of directory location.
[Aravind Batni] same as before: How about this: find ${S}/src/ip/serdes_sb/V0 -name "*.c" -type f | xargs -I {} cp -- parents {} ${D}${includedir}/ti/csl/src/ip/serdes_sb/V0
Quoted 9 lines
Quoted 9 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-1+} + --1.7.9.5
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
Quoted 71 lines
-----Original Message-----
From: Aravind Batni
Sent: Wednesday, February 05, 2014 12:54 PM
To: Maupin, Chase; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providing CSL for TI-KeyStone2 devices -This package provides chip support library interface filesThanks for the quick response.
-Best Regards,
AravindQuoted 5 lines
-----Original Message-----
From: Maupin, Chase
Sent: Wednesday, February 05, 2014 12:50 PM
To: Aravind Batni; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providingCSL for TI-
Quoted 1 line
KeyStone2 devices -This package provides chip support library
interface files
Quoted 6 lines
Quoted 6 lines
-----Original Message-----
From: Aravind Batni
Sent: Wednesday, February 05, 2014 12:33 PM
To: Maupin, Chase; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipe providingCSL for
Quoted 1 line
Quoted 1 line
TI-KeyStone2 devices -This package provides chip support
library
Quoted 8 lines
Quoted 8 lines
interface files
Thanks for the feedback. See response in-lined.
-Best Regards,
AravindQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
-----Original Message-----
From: Maupin, Chase
Sent: Tuesday, February 04, 2014 5:37 PM
To: Aravind Batni; [email protected]; Nelson, Sam
Subject: RE: [meta-arago] [PATCH] ti-csl: new recipeproviding
Quoted 6 lines
Quoted 6 lines
CSL for TI-
Quoted 1 line
KeyStone2 devices -This package provides chip support library
interface files
Quoted 3 lines
Quoted 3 lines
-----Original Message-----
From: [email protected] [mailto:meta-arago-
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
[email protected]] On Behalf Of Aravind Batni
Sent: Tuesday, February 04, 2014 4:40 PM
To: [email protected]; Nelson, Sam
Cc: Aravind Batni
Subject: [meta-arago] [PATCH] ti-csl: new recipe providingCSL
Quoted 10 lines
Quoted 8 lines
for
Quoted 1 line
Quoted 1 line
TI-KeyStone2 devices -This package provides chip support
library
Quoted 5 lines
Quoted 1 line
interface files
Thanks for the submission. Some review comments below.
This looks like a malformed commit message
Any comment here? Also, when you submit v2 be sure to add
something like
Quoted 2 lines
the below after your signed-off-by line:
Quoted 8 lines
Quoted 7 lines
---
* Updated in version 2
* change 1
* change 2The --- above is important.
[Aravind Batni] Yes, we will fix the commit message
Great. I look forward to v2.
Quoted 131 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Review
Quoted 11 lines
Signed-off-by Aravind Batni <[email protected]>---
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb | 27
++++++++++++++++++++1 file changed, 27 insertions(+)create mode 100644 meta-arago-extras/recipes-bsp/ti-csl/ti- csl_git.bb
(quoted diff) +0
-0csl_git.bb
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 2
Quoted 8 lines
b/meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file mode 100644
index 0000000..2896506meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0@@ -0,0 +1,27 @@ +DESCRIPTION = "TI CSL" +LICENSE = "TI BSD"Any reason this can't just be BSD?
Quoted 1 line
Quoted 1 line
[Aravind Batni] The components were approved by TI OSRB for TI
BSD (has
Quoted 1 line
Quoted 1 line
TI copyright statement on the top and BSD license text below).
Not sure
Quoted 13 lines
Quoted 1 line
if we can change this to BSD
OK
Quoted 9 lines
Quoted 7 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 6
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +1
-0+LIC_FILES_CHKSUM ="file://COPYING.txt;md5=5857833e20836213677fac33f9aded21"
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+ +COMPATIBLE_MACHINE = "keystone-evm" +ALLOW_EMPTY_${PN} = "1"Why do you want an empty package? Judging from below this is
because
Quoted 1 line
you are only trying to install headers right and those will
be
Quoted 2 lines
Quoted 2 lines
part of the dev
Quoted 1 line
package? Just want to make sure I understand your purpose
here.
Quoted 3 lines
Any comment here?
[Aravind Batni] Yes, this is only headers and some C source package and will be part of DEVKIT only. (nothing goes into the root file system).
Quoted 25 lines
Quoted 25 lines
Quoted 6 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb
Quoted 3 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ +PR = "r1"Start with r0
[Aravind Batni] Fixed
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 10
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+BRANCH="master" +LLD-NAME="csl"Unused variable?
[Aravind Batni] Removed the unused variable
Quoted 5 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 14
Quoted 5 lines
+SRC_URI = "
git://git.ti.com/keystone-rtos/common-csl-ip.git;protocol=git;branch=${BRANCH}"meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+ +S = "${WORKDIR}/git" +# commit ID corresponds to DEV.CSL_KEYSTONE2.02.00.00.17SRCREV =
Quoted 3 lines
Quoted 1 line
+"f6f90144c14e1ee783c4b893b52e54830be8166e"
Just a nitpick but this would make more sense being declared
before the
Quoted 2 lines
SRC_URIline. Next to the BRANCH setting.Quoted 7 lines
Quoted 7 lines
[Aravind Batni] Fixed
Quoted 6 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb line 19
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +4
-0+ +do_install () { + install -d ${D}/${includedir}/ti/csl + cp -r ${S}/* ${D}/${includedir}/ti/cslUse install command. Also, no need for the / between ${D}
and
Quoted 5 lines
Quoted 5 lines
${includedir}
Quoted 4 lines
Quoted 4 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +3
-0+# Retain only header files + cd ${D}/${includedir}/ti/csl + find . \( -name "*.xdt" -o -name "*.bld" -o -name"*.bat"
Quoted 2 lines
Quoted 2 lines
-o
Quoted 1 line
Quoted 1 line
-name "*.c" -o -name "*.xdc" -o -name "*.asm" -o -name
"*.xs"
Quoted 4 lines
Quoted 4 lines
\) |
Quoted 3 lines
Quoted 1 line
xargs rm -rf
This seems kludgy. Why not just find all the .h files and
then
Quoted 7 lines
Quoted 7 lines
install those
Quoted 5 lines
with a for loop?
Quoted 2 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-0+ rm -rf build docs + mkdir -p src/ip/serdes_sb[Aravind Batni] How about something like this: find ${S} -name
"*.h"
Quoted 5 lines
Quoted 1 line
-type f | xargs -I {} cp --parents {} ${D}${includedir}/ti/csl
Seems OK to me
Quoted 1 line
Quoted 1 line
Implicit assumption that you are in a certain directory.
Please
Quoted 9 lines
Quoted 9 lines
reference
Quoted 6 lines
everything from ${D}
Quoted 1 line
+ cp -r ${S}/src/ip/serdes_sb/V0 src/ip/serdes_sb
Same comment about the assumption of directory location.
[Aravind Batni] same as before: How about this: find ${S}/src/ip/serdes_sb/V0 -name "*.c" -type f | xargs -I {} cp -
-
Quoted 10 lines
Quoted 10 lines
parents {} ${D}${includedir}/ti/csl/src/ip/serdes_sb/V0
Quoted 9 lines
Quoted 9 lines
meta-arago-extras/recipes-bsp/ti-csl/ti-csl_git.bb new file +2
-1+} + --1.7.9.5
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago