Skip to contentSkip to conversation

arm: add DSB after icache flush in __flush_icache_all()

PATCH New Vinayak Kale 3 participants 6 messages Feb 5, 2014 – Feb 11, 2014 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: add DSB after icache flush in __flush_icache_all()

Add DSB after icache flush to complete the cache maintenance operation.

---

PS:
- This patch is tested for ARM-v7.

 arch/arm/include/asm/cacheflush.h |    1 +
 1 file changed, 1 insertion(+)
arch/arm/include/asm/cacheflush.h +1 -0
index ee753f1..ab91ebb 100644
@@ -212,6 +212,7 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *,
 static inline void __flush_icache_all(void)
 {
 	__flush_icache_preferred();
+	dsb();
 }
 
 /*
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 1/1 arm: add DSB after icache flush in __flush_icache_all()

In reply to Vinayak Kale

Am 05.02.2014 10:33, schrieb Vinayak Kale:

Quoted 3 lines

Add DSB after icache flush to complete the cache maintenance operation.

Should this go to -stable, too?

I haven't looked into the details, but at least it seems to apply cleanly on a 3.8 kernel.

Best regards

Dirk

Quoted 21 lines

---

PS:
- This patch is tested for ARM-v7.

  arch/arm/include/asm/cacheflush.h |    1 +
  1 file changed, 1 insertion(+)
arch/arm/include/asm/cacheflush.h +1 -0
index ee753f1..ab91ebb 100644
@@ -212,6 +212,7 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *,
  static inline void __flush_icache_all(void)
  {
  	__flush_icache_preferred();
+	dsb();
  }
 
  /*
#3 lore raw

PATCH 1/1 arm: add DSB after icache flush in __flush_icache_all()

Quoted 9 lines · Dirk Behme

Am 05.02.2014 10:33, schrieb Vinayak Kale:

Quoted 3 lines

Add DSB after icache flush to complete the cache maintenance operation.

Should this go to -stable, too?

I haven't looked into the details, but at least it seems to apply cleanly on a 3.8 kernel.

It should. For the similar arm64 fix I added 'cc: stable' myself (commit 5044bad43ee57).

Thanks.

Signature · 1 line
Catalin
#4 lore raw

PATCH 1/1 arm: add DSB after icache flush in __flush_icache_all()

Am 10.02.2014 11:43, schrieb Catalin Marinas:

Quoted 6 lines · Dirk Behme
Quoted 5 lines

Am 05.02.2014 10:33, schrieb Vinayak Kale:

Quoted 3 lines

Add DSB after icache flush to complete the cache maintenance operation.

Quoted 7 lines
Quoted 4 lines

Should this go to -stable, too?

I haven't looked into the details, but at least it seems to apply cleanly on a 3.8 kernel.

It should. For the similar arm64 fix I added 'cc: stable' myself (commit 5044bad43ee57).

While the arm64 patch already hit mainline, I can't find this one in mainline, -next or even the patch system, yet (?)

Vinayak: Could you put this patch into the patch system and CC stable, please?

Thanks

Dirk

#5 lore raw

PATCH 1/1 arm: add DSB after icache flush in __flush_icache_all()

Quoted 21 lines · Dirk Behme

Am 10.02.2014 11:43, schrieb Catalin Marinas:

Quoted 9 lines · Dirk Behme
Quoted 8 lines

Am 05.02.2014 10:33, schrieb Vinayak Kale:

Quoted 4 lines

Add DSB after icache flush to complete the cache maintenance operation.

Quoted 8 lines
Quoted 4 lines

Should this go to -stable, too?

I haven't looked into the details, but at least it seems to apply cleanly on a 3.8 kernel.

It should. For the similar arm64 fix I added 'cc: stable' myself (commit 5044bad43ee57).

Quoted 5 lines

While the arm64 patch already hit mainline, I can't find this one in mainline, -next or even the patch system, yet (?)

Vinayak: Could you put this patch into the patch system and CC stable, please?

Sure.

Quoted 4 lines

Thanks

Dirk