bnx2x: Allow VF rss on higher PFs
PATCH 1/1 bnx2x: Allow VF rss on higher PFs
bnx2x driver uses incorrect PF identifier to configure (in HW) the VF interrupt scheme; As a result, in multi-function mode the configuration for PFs with a high index (4+) will overflow and the PF will erroneously configure a single ISR scheme for its VFs.
As a result, if such a VF uses multiple queues, interrupt generation will stop after VF receives an Rx packet or sends a Tx packet on a queue other than queue[0].
---
Hi Dave,
Please consider applying this to `net'.
Thanks,
Yuval
--- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +3 -3
@@ -1446,12 +1446,12 @@ static void bnx2x_vf_igu_reset(struct bnx2x *bp, struct bnx2x_virtf *vf)if (vf->cfg_flags &VF_CFG_INT_SIMD ) val |=IGU_VF_CONF_SINGLE_ISR_EN ; val &= ~IGU_VF_CONF_PARENT_MASK ; - val |=BP_FUNC (bp) <<IGU_VF_CONF_PARENT_SHIFT ;/* parent PF */ + val |= (BP_ABS_FUNC (bp) >>1 ) <<IGU_VF_CONF_PARENT_SHIFT ;REG_WR (bp,IGU_REG_VF_CONFIGURATION , val);DP (BNX2X_MSG_IOV , -"value in IGU_REG_VF_CONFIGURATION of vf %d after write %x\n" , - vf->abs_vfid,REG_RD (bp,IGU_REG_VF_CONFIGURATION )); +"value in IGU_REG_VF_CONFIGURATION of vf %d after write is 0x%08x\n" , + vf->abs_vfid, val);bnx2x_pretend_func (bp,BP_ABS_FUNC (bp));
Signature · 1 line
1.8.1.227.g44fe835
From: Yuval Mintz <[email protected]>
Date: Wed, 5 Feb 2014 16:07:12 +0200
Quoted 10 lines
bnx2x driver uses incorrect PF identifier to configure (in HW) the VF interrupt scheme; As a result, in multi-function mode the configuration for PFs with a high index (4+) will overflow and the PF will erroneously configure a single ISR scheme for its VFs.
As a result, if such a VF uses multiple queues, interrupt generation will stop after VF receives an Rx packet or sends a Tx packet on a queue other than queue[0].Signed-off-by Yuval Mintz <[email protected]>Signed-off-by Ariel Elior <[email protected]>
Applied.