Skip to contentSkip to conversation

xen/events: bind all new interdomain events to VCPU0

PATCH New David Vrabel 1 participant 1 message Feb 5, 2014 Xen hypervisor interface

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/events: bind all new interdomain events to VCPU0

From: David Vrabel <[email protected]>

Commit fc087e10734a4d3e40693fc099461ec1270b3fff (xen/events: remove unnecessary init_evtchn_cpu_bindings()) causes a regression.

The kernel-side VCPU binding was not being correctly set for newly allocated or bound interdomain events. In ARM guests where 2-level events were used, this would result in no interdomain events being handled because the kernel-side VCPU masks would all be clear.

x86 guests would work because the irq affinity was set during irq setup and this would set the correct kernel-side VCPU binding.

Fix this by properly initializing the kernel-side VCPU binding in bind_evtchn_to_irq().

---
 drivers/xen/events/events_base.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/xen/events/events_base.c +2 -0
index 4672e00..f4a9e33 100644
@@ -862,6 +862,8 @@ int bind_evtchn_to_irq(unsigned int evtchn)
 			irq = ret;
 			goto out;
 		}
+		/* New interdomain events are bound to VCPU 0. */
+		bind_evtchn_to_cpu(evtchn, 0);
 	} else {
 		struct irq_info *info = info_for_irq(irq);
 		WARN_ON(info == NULL || info->type != IRQT_EVTCHN);
Signature · 1 line
1.7.2.5