Skip to contentSkip to conversation

ARM: tegra: enable I2C MUX PCA954x

PATCH New Bryan Wu 2 participants 3 messages Feb 7, 2014

Subsystems (3)
lore
Share & tools
lore

Bryan Wu

author
#0 lore raw

PATCH 1/1 ARM: tegra: enable I2C MUX PCA954x

Cardhu has a PCA9546 for I2C bus extension, which connects to 3 cameras. It's required for Tegra V4L2 soc camera driver and camera sensor drivers.

---
 arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
 arch/arm/configs/tegra_defconfig      | 1 +
 2 files changed, 9 insertions(+)
arch/arm/boot/dts/tegra30-cardhu.dtsi +8 -0
index 9104224..bfce643 100644
@@ -187,6 +187,14 @@
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
 		};
+
+		/* NXP PCA9546 I2C Mux */
+		pca9546 at 70 {
+			compatible = "nxp,pca9546";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <0x70>;
+		};
 	};
 
 	i2c at 7000c700 {
arch/arm/configs/tegra_defconfig +1 -0
index 995d434..efcf15f 100644
@@ -125,6 +125,7 @@ CONFIG_SERIAL_TEGRA=y
 CONFIG_SERIAL_OF_PLATFORM=y
 # CONFIG_HW_RANDOM is not set
 # CONFIG_I2C_COMPAT is not set
+CONFIG_I2C_MUX_PCA954x=y
 CONFIG_I2C_MUX_PINCTRL=y
 CONFIG_I2C_TEGRA=y
 CONFIG_SPI=y
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 ARM: tegra: enable I2C MUX PCA954x

Quoted 6 lines · Bryan Wu

Cardhu has a PCA9546 for I2C bus extension, which connects to 3 cameras. It's required for Tegra V4L2 soc camera driver and camera sensor drivers.

 arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
 arch/arm/configs/tegra_defconfig      | 1 +

DT and defconfig changes go into separate branches. Could I get this split into two patches please?

arch/arm/boot/dts/tegra30-cardhu.dtsi

Quoted 3 lines
arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -0
 
+		/* NXP PCA9546 I2C Mux */

That comment isn't useful, since the compatible value below spells out what the device is.

arch/arm/boot/dts/tegra30-cardhu.dtsi line 192

Quoted 1 line
arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -0
+		pca9546 at 70 {

DT nodes should be named after the class/type of device, not the identify. As such, use "i2cmux at 70".

author
#2 lore raw

PATCH 1/1 ARM: tegra: enable I2C MUX PCA954x

Quoted 15 lines · Stephen Warren
Quoted 6 lines · Bryan Wu

Cardhu has a PCA9546 for I2C bus extension, which connects to 3 cameras. It's required for Tegra V4L2 soc camera driver and camera sensor drivers.

 arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 ++++++++
 arch/arm/configs/tegra_defconfig      | 1 +

DT and defconfig changes go into separate branches. Could I get this split into two patches please?

arch/arm/boot/dts/tegra30-cardhu.dtsi

Quoted 3 lines
arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -0
 
+             /* NXP PCA9546 I2C Mux */
Quoted 8 lines

That comment isn't useful, since the compatible value below spells out what the device is.

Quoted 1 line

+ pca9546 at 70 {

DT nodes should be named after the class/type of device, not the identify. As such, use "i2cmux at 70".

OK, cool. I will take all the comments and post my V2 patches.