spi: Use reinit_completion at appropriate places
Subsystems (4)
PATCH 1/1 spi: Use reinit_completion at appropriate places
Calling init_completion() once is enough.
For the rest of the iterations, call reinit_completion() instead.
Cc Jonas Gorski <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc Tanguy Bouzeloc <[email protected]>
Cc Uwe Kleine-König <[email protected]>
Cc Sascha Hauer <[email protected]>
Signed-off-by Axel Lin <[email protected]>
--- drivers/spi/spi-bcm63xx-hsspi.c | 3 ++- drivers/spi/spi-bcm63xx.c | 3 ++- drivers/spi/spi-efm32.c | 3 ++- drivers/spi/spi-imx.c | 2 +- 4 files changed, 7 insertions(+), 4 deletions(-)
drivers/spi/spi-bcm63xx-hsspi.c +2 -1
@@ -180,7 +180,7 @@ static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct spi_transfer *t)while (pending >0 ) {int curr_step =min_t (int, step_size, pending); -init_completion (&bs->done); +reinit_completion (&bs->done);if (tx) {memcpy_toio (bs->fifo +HSSPI_OPCODE_LEN , tx, curr_step); tx += curr_step;
@@ -369,6 +369,7 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev) bs->fifo = (u8 __iomem *)(bs->regs +HSSPI_FIFO_REG (0 ));mutex_init (&bs->bus_mutex); +init_completion (&bs->done); master->bus_num =HSSPI_BUS_NUM ; master->num_chipselect =8 ;
drivers/spi/spi-bcm63xx.c +2 -1
@@ -169,7 +169,7 @@ static int bcm63xx_txrx_bufs(struct spi_device *spi, struct spi_transfer *first, transfer_list); } -init_completion (&bs->done); +reinit_completion (&bs->done);/* Fill in the Message control register */ msg_ctl = (len <<SPI_BYTE_CNT_SHIFT );
@@ -353,6 +353,7 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) } bs =spi_master_get_devdata (master); +init_completion (&bs->done);platform_set_drvdata (pdev, master); bs->pdev = pdev;
drivers/spi/spi-efm32.c +2 -1
@@ -198,7 +198,7 @@ static int efm32_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t)efm32_spi_filltx (ddata); -init_completion (&ddata->done); +reinit_completion (&ddata->done);efm32_spi_write32 (ddata,REG_IF_TXBL |REG_IF_RXDATAV ,REG_IEN );
@@ -349,6 +349,7 @@ static int efm32_spi_probe(struct platform_device *pdev) ddata->bitbang.txrx_bufs = efm32_spi_txrx_bufs;spin_lock_init (&ddata->lock); +init_completion (&ddata->done); ddata->clk =devm_clk_get (&pdev->dev,NULL );if (IS_ERR (ddata->clk)) {
drivers/spi/spi-imx.c +1 -1
@@ -740,7 +740,7 @@ static int spi_imx_transfer(struct spi_device *spi, spi_imx->count = transfer->len; spi_imx->txfifo =0 ; -init_completion (&spi_imx->xfer_done); +reinit_completion (&spi_imx->xfer_done);spi_imx_push (spi_imx);
Signature · 8 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Mark Brown
AppliedQuoted 2 lines · Axel Lin
Calling
init_completion()once is enough.
For the rest of the iterations, callreinit_completion()instead.
Applied, thanks.