Skip to contentSkip to conversation

sdhci: Drop unnecessary #include

PATCH Applied Kevin Wolf 3 participants 4 messages Feb 9, 2014 – Feb 10, 2014

lore
Share & tools
lore

Kevin Wolf

author
#0 lore raw

PATCH 1/1 sdhci: Drop unnecessary #include

---
 hw/sd/sdhci.c | 1 -
 1 file changed, 1 deletion(-)
hw/sd/sdhci.c +0 -1
index 0906a1d..a0b90ba 100644
@@ -26,7 +26,6 @@
 #include "sysemu/blockdev.h"
 #include "sysemu/dma.h"
 #include "qemu/timer.h"
-#include "block/block_int.h"
 #include "qemu/bitops.h"
 
 #include "sdhci.h"
Signature · 1 line
1.8.1.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Kevin Wolf
---
 hw/sd/sdhci.c | 1 -
 1 file changed, 1 deletion(-)
hw/sd/sdhci.c +0 -1
index 0906a1d..a0b90ba 100644
@@ -26,7 +26,6 @@
 #include "sysemu/blockdev.h"
 #include "sysemu/dma.h"
 #include "qemu/timer.h"
-#include "block/block_int.h"
 #include "qemu/bitops.h"
 
 #include "sdhci.h"
Signature · 1 line
1.8.1.4

BTW it seems bitops.h is not used too, although I'm not 100% sure.

author
#2 lore raw

Am 10.02.2014 um 08:00 hat Fam Zheng geschrieben:

Quoted 17 lines · Kevin Wolf
Quoted 16 lines
---
 hw/sd/sdhci.c | 1 -
 1 file changed, 1 deletion(-)
hw/sd/sdhci.c +0 -1
index 0906a1d..a0b90ba 100644
@@ -26,7 +26,6 @@
 #include "sysemu/blockdev.h"
 #include "sysemu/dma.h"
 #include "qemu/timer.h"
-#include "block/block_int.h"
 #include "qemu/bitops.h"
 
Quoted 8 lines
Quoted 4 lines
hw/sd/sdhci.c +0 -0
 #include "sdhci.h"
Signature · 1 line
1.8.1.4

BTW it seems bitops.h is not used too, although I'm not 100% sure.

Not sure, you'd have to try it out.

The main reason for this removal is that it is the last user of block_int.h in hw/

Kevin