NFSv4: Infinite loop in lease recovery when rpc.gssd is not running.
Subsystems (2)
PATCH 1/1 NFSv4: Infinite loop in lease recovery when rpc.gssd is not running.
Commit 0ea9de0e introduce a regression in the lease recovery code.
An infinite loop is caused when nfs4_establish_lease() fails with -EACCES. This causes nfs4_handle_reclaim_lease_error() to sleep a bit and resets the NFS4CLNT_LEASE_EXPIRED bit. This in turn causes nfs4_state_manager() to try and reestablished the lease, again, again, again...
The problem is a valid RPCSEC_GSS client is being created when rpc.gssd is not running. This is causing the RPC code to fail with the -EACCES sending the lease reestablished off the deep end.
Moving the gssd_running() check back into nfs4_init_client(), stopping the RPCSEC_GSS client from being create, stops the looping
Signed-off-by Steve Dickson <[email protected]>
--- fs/nfs/nfs4client.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
fs/nfs/nfs4client.c +4 -1
@@ -372,7 +372,10 @@ struct nfs_client *nfs4_init_client(struct nfs_client *clp,__set_bit (NFS_CS_DISCRTRY , &clp->cl_flags);__set_bit (NFS_CS_NO_RETRANS_TIMEOUT , &clp->cl_flags); - error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_GSS_KRB5I ); + error = -EINVAL ; +if (gssd_running (clp->cl_net)) + error =nfs_create_rpc_client (clp, timeparms, +RPC_AUTH_GSS_KRB5I );if (error == -EINVAL ) error =nfs_create_rpc_client (clp, timeparms,RPC_AUTH_UNIX );if (error <0 )
Signature · 1 line
1.7.1