Skip to contentSkip to conversation

cpufreq: cpu0: drop selecting of THERMAL and THERMAL_CPU

PATCH In review Rob Herring 2 participants 2 messages Feb 11, 2014 – Feb 12, 2014 CPU frequency scaling framework

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 cpufreq: cpu0: drop selecting of THERMAL and THERMAL_CPU

From: Rob Herring <[email protected]>

The addition of THERMAL and THERMAL_CPU selections causes a kconfig warning on highbank platforms:

warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK &&
REGULATOR && OF && THERMAL && CPU_THERMAL)

The cpufreq-cpu0 driver does not require thermal zone support to function as highbank does not need these, so drop selecting of THERMAL and CPU_THERMAL.

---
v2:
- just drop selecting THERMAL and THERMAL_CPU instead of a new kconfig option

Dropping REGULATOR doesn't build w/o some empty regulator functions, so that's 3.15 material.

Rob

 drivers/cpufreq/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/Kconfig +1 -1
index 4b029c0..d100926 100644
@@ -185,7 +185,7 @@ config CPU_FREQ_GOV_CONSERVATIVE
 
 config GENERIC_CPUFREQ_CPU0
 	tristate "Generic CPU0 cpufreq driver"
-	depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
+	depends on HAVE_CLK && REGULATOR && OF
 	select PM_OPP
 	help
 	  This adds a generic cpufreq driver for CPU0 frequency management.
Signature · 1 line
1.8.3.2
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 36 lines · Rob Herring

From: Rob Herring <[email protected]>

The addition of THERMAL and THERMAL_CPU selections causes a kconfig warning on highbank platforms:

warning: (ARM_HIGHBANK_CPUFREQ) selects GENERIC_CPUFREQ_CPU0 which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && HAVE_CLK &&
REGULATOR && OF && THERMAL && CPU_THERMAL)

The cpufreq-cpu0 driver does not require thermal zone support to function as highbank does not need these, so drop selecting of THERMAL and CPU_THERMAL.

---
v2:
- just drop selecting THERMAL and THERMAL_CPU instead of a new kconfig option

Dropping REGULATOR doesn't build w/o some empty regulator functions, so that's 3.15 material.

Rob

 drivers/cpufreq/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/Kconfig +0 -0
index 4b029c0..d100926 100644

drivers/cpufreq/Kconfig config CPU_FREQ_GOV_CONSERVATIVE · line 191

Quoted 8 lines
drivers/cpufreq/Kconfig +1 -1
@@ -185,7 +185,7 @@ config CPU_FREQ_GOV_CONSERVATIVE
 
 config GENERIC_CPUFREQ_CPU0
        tristate "Generic CPU0 cpufreq driver"
-       depends on HAVE_CLK && REGULATOR && OF && THERMAL && CPU_THERMAL
+       depends on HAVE_CLK && REGULATOR && OF
        select PM_OPP
        help
          This adds a generic cpufreq driver for CPU0 frequency management.