Skip to contentSkip to conversation

blackfin: Kconfig symbol VIDEO_MT9M114?

DISCUSSION Paul Bolle 3 participants 4 messages Feb 12, 2014 – Feb 13, 2014

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

Steven, Sonic,

Your commit 54e4ff4d4024 ("blackfin: adi gpio driver and pinctrl driver support") added a check for the Kconfig macro CONFIG_VIDEO_MT9M114. That commit was added during the v3.13 release cycle.

There's no Kconfig symbol VIDEO_MT9M114 in mainline. And it doesn't look like this was a typo. So why was that check added?

Regards,

Paul Bolle

#1 lore raw

Hi Paul,

Quoted 8 lines · Paul Bolle

Steven, Sonic,

Your commit 54e4ff4d4024 ("blackfin: adi gpio driver and pinctrl driver support") added a check for the Kconfig macro CONFIG_VIDEO_MT9M114. That commit was added during the v3.13 release cycle.

There's no Kconfig symbol VIDEO_MT9M114 in mainline. And it doesn't look like this was a typo. So why was that check added?

VIDEO_MT9M114 is from patch "Aptina mt9m114 HD digital image sensor driver", but unfortunately this patch hasn't been accepted yet.
https://patchwork.linuxtv.org/patch/16308/
This Kconfig symbol should be removed until the mt9m114 driver is accepted by mainline.

Quoted 6 lines

Regards,

Paul Bolle

-steven

author
#2 lore raw

Hi Steven,

Quoted 5 lines · Steven Miao

VIDEO_MT9M114 is from patch "Aptina mt9m114 HD digital image sensor driver", but unfortunately this patch hasn't been accepted yet.
https://patchwork.linuxtv.org/patch/16308/
This Kconfig symbol should be removed until the mt9m114 driver is accepted by mainline.

Thanks for looking into this.

It's easy for me to submit a trivial patch to remove the one line depending on these Kconfig macros. But it seems that line should be added to the queue for that driver at the same time, otherwise we risk losing it. So it's safer if you or the people working on that driver coordinate that, isn't it?

Paul Bolle

#3 lore raw

Hi Paul,

I will send out a patch to remove it.

Regards,

Sonic

Quoted 20 lines

-----Original Message-----
From: Paul Bolle [mailto:[email protected]]
Sent: Thursday, February 13, 2014 5:30 PM
To: Steven Miao
Cc: Zhang, Sonic; Richard Weinberger; [email protected]; open list:CAN NETWORK DRIVERS <[email protected]>, open list:NETWORKING DRIVERS <[email protected]>, open list
Subject: Re: blackfin: Kconfig symbol VIDEO_MT9M114?

Hi Steven,

Quoted 5 lines · Steven Miao

VIDEO_MT9M114 is from patch "Aptina mt9m114 HD digital image sensor driver", but unfortunately this patch hasn't been accepted yet.
https://patchwork.linuxtv.org/patch/16308/
This Kconfig symbol should be removed until the mt9m114 driver is accepted by mainline.

Thanks for looking into this.

Quoted 8 lines

It's easy for me to submit a trivial patch to remove the one line depending on these Kconfig macros. But it seems that line should be added to the queue for that driver at the same time, otherwise we risk losing it. So it's safer if you or the people working on that driver coordinate that, isn't it?

Paul Bolle

���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m���� ������?�I�