Skip to contentSkip to conversation

Tools: hv: vssdaemon: Ignore VFAT mounts during the Freeze operation

PATCH In review K. Y. Srinivasan 2 participants 3 messages Feb 12, 2014 Hyper-V/Azure core and drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Tools: hv: vssdaemon: Ignore VFAT mounts during the Freeze operation

If the guest has a FAT file system mounted, skip it during the FREEZE operation. With this change we can support host initiated backup of the guest even when the guest may have FAT file systems mounted.

---
 tools/hv/hv_vss_daemon.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
tools/hv/hv_vss_daemon.c +2 -0
index 520de3304..6a213b8 100644
@@ -87,6 +87,8 @@ static int vss_operate(int operation)
 			continue;
 		if (strcmp(ent->mnt_type, "iso9660") == 0)
 			continue;
+		if (strcmp(ent->mnt_type, "vfat") == 0)
+			continue;
 		if (strcmp(ent->mnt_dir, "/") == 0) {
 			root_seen = 1;
 			continue;
Signature · 1 line
1.7.4.1
#1 lore raw
Quoted 14 lines · K. Y. Srinivasan

If the guest has a FAT file system mounted, skip it during the FREEZE operation. With this change we can support host initiated backup of the guest even when the guest may have FAT file systems mounted.

---
 tools/hv/hv_vss_daemon.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
tools/hv/hv_vss_daemon.c +0 -0
index 520de3304..6a213b8 100644

tools/hv/hv_vss_daemon.c static int vss_operate(int operation) · line 91

Quoted 5 lines
tools/hv/hv_vss_daemon.c +2 -0
@@ -87,6 +87,8 @@ static int vss_operate(int operation)
 			continue;
 		if (strcmp(ent->mnt_type, "iso9660") == 0)
 			continue;
+		if (strcmp(ent->mnt_type, "vfat") == 0)
+			continue;

Why should the filesystem type matter here at all?

thanks,

greg k-h

#2 lore raw
Quoted 21 lines

-----Original Message-----
From: Greg KH [mailto:[email protected]]
Sent: Wednesday, February 12, 2014 8:42 AM
To: KY Srinivasan
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 1/1] Tools: hv: vssdaemon: Ignore VFAT mounts during the Freeze operation

Quoted 9 lines · K. Y. Srinivasan

If the guest has a FAT file system mounted, skip it during the FREEZE operation. With this change we can support host initiated backup of the guest even when the guest may have FAT file systems mounted.

---
 tools/hv/hv_vss_daemon.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Quoted 12 lines

tools/hv/hv_vss_daemon.c static int vss_operate(int operation) · line 91

Quoted 10 lines
tools/hv/hv_vss_daemon.c +2 -0
index 520de3304..6a213b8 100644
@@ -87,6 +87,8 @@ static int vss_operate(int operation)
 			continue;
 		if (strcmp(ent->mnt_type, "iso9660") == 0)
 			continue;
+		if (strcmp(ent->mnt_type, "vfat") == 0)
+			continue;

Why should the filesystem type matter here at all?

As part of snapshotting the guest, we want to freeze all mounted file systems in the guest. FAT file system does not support the freeze operation and so we want to skip these mount points. For VMs on UEFI firmware, the EFI partition is a FAT partition.

Regards,

K. Y