gpu:drm:tilcdc: backlight node never found
Subsystems (3)
PATCH 1/1 gpu:drm:tilcdc: backlight node never found
In panel_probe() the backlight node is never found, correct this.
Signed-off-by Heiko Schocher <[email protected]>
Cc Anatolij Gustschin <[email protected]>
Cc Benoit Parrot <[email protected]>
Cc Rob Clark <[email protected]>
Cc David Airlie <[email protected]>
Cc Grant Likely <[email protected]>
Cc Rob Herring <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Cc Sachin Kamat <[email protected]>
--- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/gpu/drm/tilcdc/tilcdc_panel.c +10 -3
@@ -356,6 +356,7 @@ static struct of_device_id panel_of_match[];static int panel_probe (struct platform_device *pdev) {struct device_node *node = pdev->dev.of_node; +struct device_node *backlight_node;struct panel_module *panel_mod;struct tilcdc_module *mod;struct pinctrl *pinctrl;
@@ -395,9 +396,15 @@ static int panel_probe(struct platform_device *pdev) mod->preferred_bpp = panel_mod->info->bpp; - panel_mod->backlight =of_find_backlight_by_node (node); -if (panel_mod->backlight) -dev_info (&pdev->dev,"found backlight\n" ); + backlight_node =of_parse_phandle (pdev->dev.of_node,"backlight" ,0 ); +if (backlight_node) { + panel_mod->backlight = +of_find_backlight_by_node (backlight_node); +if (panel_mod->backlight) +dev_info (&pdev->dev,"found backlight\n" ); + }else { +dev_warn (&pdev->dev,"backlight node missing...\n" ); + }return 0 ;
Signature · 6 lines
1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines · On Thu, 13 Feb 2014 14:47:38 +0100 Heiko Schocher…
In
panel_probe()the backlight node is never found, correct this.Signed-off-by Heiko Schocher <[email protected]>
Quoted 36 lines
Cc Anatolij Gustschin <[email protected]>Cc Benoit Parrot <[email protected]>Cc Rob Clark <[email protected]>Cc David Airlie <[email protected]>Cc Grant Likely <[email protected]>Cc Rob Herring <[email protected]>Cc Tomi Valkeinen <[email protected]>Cc Sachin Kamat <[email protected]>--- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)drivers/gpu/drm/tilcdc/tilcdc_panel.c +3
-3@@ -356,6 +356,7 @@ static struct of_device_id panel_of_match[];static int panel_probe (struct platform_device *pdev) {struct device_node *node = pdev->dev.of_node; +struct device_node *backlight_node;struct panel_module *panel_mod;struct tilcdc_module *mod;struct pinctrl *pinctrl;@@ -395,9 +396,15 @@ static int panel_probe(struct platform_device *pdev) mod->preferred_bpp = panel_mod->info->bpp; - panel_mod->backlight =of_find_backlight_by_node (node); -if (panel_mod->backlight) -dev_info (&pdev->dev,"found backlight\n" ); + backlight_node =of_parse_phandle (pdev->dev.of_node,"backlight" ,0 ); +if (backlight_node) {
drivers/gpu/drm/tilcdc/tilcdc_panel.c static int panel_probe(struct platform_device *pdev) · line 410
Quoted 10 lines
drivers/gpu/drm/tilcdc/tilcdc_panel.c +7
-0+ panel_mod->backlight = +of_find_backlight_by_node (backlight_node); +if (panel_mod->backlight) +dev_info (&pdev->dev,"found backlight\n" ); + }else { +dev_warn (&pdev->dev,"backlight node missing...\n" ); + }return 0 ;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html