Skip to contentSkip to conversation

sparc32: fix build failure for arch_jump_label_transform

PATCH Applied Paul Gortmaker 2 participants 2 messages Feb 13, 2014 – Feb 20, 2014 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc32: fix build failure for arch_jump_label_transform

In arch/sparc/Kernel/Makefile, we see:

   obj-$(CONFIG_SPARC64)   += jump_label.o

However, the Kconfig selects HAVE_ARCH_JUMP_LABEL unconditionally for all SPARC. This in turn leads to the following failure when doing allmodconfig coverage builds:

kernel/built-in.o: In function `__jump_label_update':
jump_label.c:(.text+0x8560c): undefined reference to arch_jump_label_transform' kernel/built-in.o: In function arch_jump_label_transform_static':
(.text+0x85cf4): undefined reference to `arch_jump_label_transform'
make: *** [vmlinux] Error 1

Change HAVE_ARCH_JUMP_LABEL to be conditional on SPARC64 so that it matches the Makefile.

---

[This appears to be nothing new ; I checked out 3.0 and the
same Makefile/Kconfig mismatch existed back then as well.]

 arch/sparc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sparc/Kconfig +1 -1
index c51efdcd07a2..7d8b7e94b93b 100644
@@ -27,7 +27,7 @@ config SPARC
 	select RTC_DRV_M48T59
 	select HAVE_DMA_ATTRS
 	select HAVE_DMA_API_DEBUG
-	select HAVE_ARCH_JUMP_LABEL
+	select HAVE_ARCH_JUMP_LABEL if SPARC64
 	select GENERIC_IRQ_SHOW
 	select ARCH_WANT_IPC_PARSE_VERSION
 	select GENERIC_PCI_IOMAP
Signature · 1 line
1.8.5.2
maintainer Applied
#1 lore raw

From: Paul Gortmaker <[email protected]>
Date: Thu, 13 Feb 2014 13:57:44 -0500

Quoted 14 lines

In arch/sparc/Kernel/Makefile, we see:

   obj-$(CONFIG_SPARC64)   += jump_label.o

However, the Kconfig selects HAVE_ARCH_JUMP_LABEL unconditionally for all SPARC. This in turn leads to the following failure when doing allmodconfig coverage builds:

kernel/built-in.o: In function `__jump_label_update':
jump_label.c:(.text+0x8560c): undefined reference to arch_jump_label_transform' kernel/built-in.o: In function arch_jump_label_transform_static':
(.text+0x85cf4): undefined reference to `arch_jump_label_transform'
make: *** [vmlinux] Error 1

Quoted 4 lines

Change HAVE_ARCH_JUMP_LABEL to be conditional on SPARC64 so that it matches the Makefile.

Applied.