Skip to contentSkip to conversation

ath10k: add more details to some debug messages

PATCH Superseded [email protected] 2 participants 3 messages Feb 13, 2014 Qualcomm Atheros ATH10K wireless driver

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ath10k: add more details to some debug messages

From: Ben Greear <[email protected]>

---

Add SoB, fix title as suggested, fix log message as suggested.

 drivers/net/wireless/ath/ath10k/mac.c  | 3 ++-
 drivers/net/wireless/ath/ath10k/txrx.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/net/wireless/ath/ath10k/mac.c +2 -1
index 1c305b1..c9c6efe 100644
@@ -3433,7 +3433,8 @@ static void ath10k_flush(struct ieee80211_hw *hw, u32 queues, bool drop)
 		}), ATH10K_FLUSH_TIMEOUT_HZ);
 
 	if (ret <= 0 || skip)
-		ath10k_warn("tx not flushed\n");
+		ath10k_warn("tx not flushed (skip %i ar-state %i): %i\n",
+			    skip, ar->state, ret);
 
 skip:
 	mutex_unlock(&ar->conf_mutex);
drivers/net/wireless/ath/ath10k/txrx.c +2 -1
index b11e478..d52883a 100644
@@ -378,7 +378,8 @@ void ath10k_peer_unmap_event(struct ath10k_htt *htt,
 	spin_lock_bh(&ar->data_lock);
 	peer = ath10k_peer_find_by_id(ar, ev->peer_id);
 	if (!peer) {
-		ath10k_warn("unknown peer id %d\n", ev->peer_id);
+		ath10k_warn("peer-unmap-event: unknown peer id %d\n",
+			    ev->peer_id);
 		goto exit;
 	}
 
Signature · 7 lines
1.7.11.7


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
author
#1 lore raw
Quoted 4 lines · On 02/13/2014 11:08 AM, [email protected] wrote:

From: Ben Greear <[email protected]>

---

Ahh, crap...I forgot to add a summary as you had previously suggested...I'll re-send v4 in a bit...yell if there are other issues as well.

Thanks,
Ben

Signature · 8 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#2 lore raw
Quoted 8 lines · Ben Greear
Quoted 4 lines · On 02/13/2014 11:08 AM, [email protected] wrote:

From: Ben Greear <[email protected]>

---

Ahh, crap...I forgot to add a summary as you had previously suggested...I'll re-send v4 in a bit...yell if there are other issues as well.

For ath10k patches also CC linux-wireless mailing list. We get more review comments that way.

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k