hostap: Do not free priv until timer handler hasn't actually stopped using it
PATCH 1/1 hostap: Do not free priv until timer handler hasn't actually stopped using it
Function del_timer() does not guarantee that timer was really deleted. If the timer handler is beeing executed at the moment, the function does nothing. So, it's possible to use already freed memory in the handler:
[ref: Documentation/DocBook/kernel-locking.tmpl]
This was found using grep and compile-tested only. Please, consider applying or something similar to it.
Signed-off-by Kirill Tkhai <[email protected]>
CC Jouni Malinen <[email protected]>
CC John W. Linville <[email protected]>
--- drivers/net/wireless/hostap/hostap_ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/hostap/hostap_ap.c +1 -1
@@ -147,7 +147,7 @@ static void ap_free_sta(struct ap_data *ap, struct sta_info *sta)if (!sta->ap && sta->u.sta.challenge)kfree (sta->u.sta.challenge); -del_timer (&sta->timer); +del_timer_sync (&sta->timer);#endif /* PRISM2_NO_KERNEL_IEEE80211_MGMT */ kfree (sta);