wandboard: Staticize usdhc1_pads
PATCH 1/5 wandboard: Staticize usdhc1_pads
From: Fabio Estevam <[email protected]>
Fix the following sparse warning:
wandboard.c:58:22: warning: symbol 'usdhc1_pads' was not declared. Should it be static?
--- board/wandboard/wandboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/wandboard/wandboard.c +1 -1
@@ -55,7 +55,7 @@ static iomux_v3_cfg_t const uart1_pads[] = { MX6_PAD_CSI0_DAT11__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL), }; -iomux_v3_cfg_t const usdhc1_pads[] = { +static iomux_v3_cfg_t const usdhc1_pads[] = {MX6_PAD_SD1_CLK__SD1_CLK |MUX_PAD_CTRL (USDHC_PAD_CTRL ),MX6_PAD_SD1_CMD__SD1_CMD |MUX_PAD_CTRL (USDHC_PAD_CTRL ),MX6_PAD_SD1_DAT0__SD1_DATA0 |MUX_PAD_CTRL (USDHC_PAD_CTRL ),
Signature · 1 line
1.8.1.2
PATCH 2/5 mmc: Add a prototype for board_mmc_init()
From: Fabio Estevam <[email protected]>
Fixes the following sparse warning:
wandboard.c:137:5: warning: symbol 'board_mmc_init' was not declared. Should it be static?
--- include/mmc.h | 2 ++ 1 file changed, 2 insertions(+)
include/mmc.h +2 -0
@@ -349,4 +349,6 @@ struct mmc *mmc_spi_init(uint bus, uint cs, uint speed, uint mode);int mmc_legacy_init (int verbose);#endif +int board_mmc_init (bd_t *bis); +#endif /* _MMC_H_ */
Signature · 1 line
1.8.1.2
PATCH 2/5 mmc: Add a prototype for board_mmc_init()
Quoted 9 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Fixes the following sparse warning:
wandboard.c:137:5: warning: symbol '
board_mmc_init' was not declared. Should it be static?Cc Pantelis Antoniou <[email protected]>Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 3/5 wandboard: Fix sparse warning
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Add a prototype for board_phy_config() to fix the following sparse warning:
wandboard.c:200:5: warning: symbol 'board_phy_config' was not declared. Should it be static?
--- board/wandboard/wandboard.c | 1 + include/phy.h | 2 ++ 2 files changed, 3 insertions(+)
board/wandboard/wandboard.c +1 -0
@@ -25,6 +25,7 @@#include <miiphy.h> #include <netdev.h> #include <linux/fb.h> +#include <phy.h> DECLARE_GLOBAL_DATA_PTR ;
include/phy.h +2 -0
@@ -234,6 +234,8 @@ int phy_smsc_init(void);int phy_teranetics_init (void );int phy_vitesse_init (void ); +int board_phy_config (struct phy_device *phydev); +/* PHY UIDs for various PHYs that are referenced in external code */ #define PHY_UID_TN2020 0x00a19410
Signature · 1 line
1.8.1.2
PATCH 3/5 wandboard: Fix sparse warning
Quoted 9 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Add a prototype for
board_phy_config()to fix the following sparse warning:wandboard.c:200:5: warning: symbol '
board_phy_config' was not declared. Should it be static?Cc Joe Hershberger <[email protected]>Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 4/5 wandboard: Include <input.h>
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Include <input.h> in order to fix the following sparse warning:
wandboard.c:278:5: warning: symbol 'overwrite_console' was not declared. Should it be static?
--- board/wandboard/wandboard.c | 1 + 1 file changed, 1 insertion(+)
board/wandboard/wandboard.c +1 -0
@@ -26,6 +26,7 @@#include <netdev.h> #include <linux/fb.h> #include <phy.h> +#include <input.h> DECLARE_GLOBAL_DATA_PTR ;
Signature · 1 line
1.8.1.2
PATCH 4/5 wandboard: Include <input.h>
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Include <
input.h> in order to fix the following sparse warning:wandboard.c:278:5: warning: symbol '
overwrite_console' was not declared. Should it be static?Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 5/5 fb: Add a prototype for board_video_skip()
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Add a prototype for board_video_skip() in order to fix the following sparse warning:
wandboard.c:227:5: warning: symbol 'board_video_skip' was not declared. Should it be static?
--- include/linux/fb.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/fb.h +2 -0
@@ -612,6 +612,8 @@ struct fb_videomode {u32 flag; }; +int board_video_skip (void ); +#endif /* __KERNEL__ */ #endif /* _LINUX_FB_H */
Signature · 1 line
1.8.1.2
PATCH 5/5 fb: Add a prototype for board_video_skip()
Quoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Add a prototype for
board_video_skip()in order to fix the following sparse warning:wandboard.c:227:5: warning: symbol '
board_video_skip' was not declared. Should it be static?Cc Anatolij Gustschin <[email protected]>Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/5 wandboard: Staticize usdhc1_pads
In reply to Fabio EstevamHi Fabio,
Quoted 16 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Fix the following sparse warning:
wandboard.c:58:22: warning: symbol '
usdhc1_pads' was not declared. Should it be static?Signed-off-by Fabio Estevam <[email protected]>--- board/wandboard/wandboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)board/wandboard/wandboard.c +0
-0
board/wandboard/wandboard.c static iomux_v3_cfg_t const uart1_pads[] = { · line 61
Quoted 8 lines
board/wandboard/wandboard.c +1
-1@@ -55,7 +55,7 @@ static iomux_v3_cfg_t const uart1_pads[] = { MX6_PAD_CSI0_DAT11__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL), }; -iomux_v3_cfg_t const usdhc1_pads[] = { +static iomux_v3_cfg_t const usdhc1_pads[] = {MX6_PAD_SD1_CLK__SD1_CLK |MUX_PAD_CTRL (USDHC_PAD_CTRL ),MX6_PAD_SD1_CMD__SD1_CMD |MUX_PAD_CTRL (USDHC_PAD_CTRL ),MX6_PAD_SD1_DAT0__SD1_DATA0 |MUX_PAD_CTRL (USDHC_PAD_CTRL ),
Thanks for fix it. However, which gcc version reports these warnings ? Surely I must update and test with a newer one: with gcc 4.6.4/4.7.2 I saw no error.
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/5 wandboard: Staticize usdhc1_pads
Hi Stefano,
Quoted 3 lines · Stefano Babic
Thanks for fix it. However, which gcc version reports these warnings ? Surely I must update and test with a newer one: with gcc 4.6.4/4.7.2 I saw no error.
In order to trigger the sparse warnings we need to build it as:
make -j4 C=1 2>wandboard.txt
Regards,
Fabio Estevam
PATCH 1/5 wandboard: Staticize usdhc1_pads
Quoted 1 line · Fabio Estevam
make -j4 C=1 2>wandboard.txt
Thanks,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/5 wandboard: Staticize usdhc1_pads
In reply to Fabio EstevamQuoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Fix the following sparse warning:
wandboard.c:58:22: warning: symbol '
usdhc1_pads' was not declared. Should it be static?Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================