Skip to contentSkip to conversation

hwmon: (ltc4245) Associate log messages with hwmon device

PATCH In review Guenter Roeck 2 participants 3 messages Feb 16, 2014 – Feb 23, 2014 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH 2/3 hwmon: (ltc4245) Associate log messages with hwmon device

Since sysfs attributes are not attached to the hwmon device, it makes sense to associate log messages with the hwmon device as well.

---
 drivers/hwmon/ltc4245.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/ltc4245.c +2 -2
index 2c6da5d..0a3eddb 100644
@@ -95,7 +95,7 @@ static void ltc4245_update_gpios(struct device *dev)
 	 * readings as stale by setting them to -EAGAIN
 	 */
 	if (time_after(jiffies, data->last_updated + 5 * HZ)) {
-		dev_dbg(&client->dev, "Marking GPIOs invalid\n");
+		dev_dbg(dev, "Marking GPIOs invalid\n");
 		for (i = 0; i < ARRAY_SIZE(data->gpios); i++)
 			data->gpios[i] = -EAGAIN;
 	}
@@ -141,7 +141,7 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)
 
 	if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
 
-		dev_dbg(&client->dev, "Starting ltc4245 update\n");
+		dev_dbg(dev, "Starting ltc4245 update\n");
 
 		/* Read control registers -- 0x00 to 0x07 */
 		for (i = 0; i < ARRAY_SIZE(data->cregs); i++) {
Signature · 7 lines
1.7.9.7


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw
Quoted 23 lines · Guenter Roeck

Since sysfs attributes are not attached to the hwmon device, it makes sense to associate log messages with the hwmon device as well.

---
 drivers/hwmon/ltc4245.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/ltc4245.c +1 -1
index 2c6da5d..0a3eddb 100644
@@ -95,7 +95,7 @@ static void ltc4245_update_gpios(struct device *dev)
 	 * readings as stale by setting them to -EAGAIN
 	 */
 	if (time_after(jiffies, data->last_updated + 5 * HZ)) {
-		dev_dbg(&client->dev, "Marking GPIOs invalid\n");
+		dev_dbg(dev, "Marking GPIOs invalid\n");
 		for (i = 0; i < ARRAY_SIZE(data->gpios); i++)
 			data->gpios[i] = -EAGAIN;
 	}

drivers/hwmon/ltc4245.c static struct ltc4245_data *ltc4245_update_device(struct device *dev) · line 147

Quoted 8 lines
drivers/hwmon/ltc4245.c +1 -1
@@ -141,7 +141,7 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)
 
 	if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
 
-		dev_dbg(&client->dev, "Starting ltc4245 update\n");
+		dev_dbg(dev, "Starting ltc4245 update\n");
 
 		/* Read control registers -- 0x00 to 0x07 */
 		for (i = 0; i < ARRAY_SIZE(data->cregs); i++) {

Both debug messages are quite pointless IMHO and I'd rather delete them than update them.

Signature · 7 lines
Jean Delvare
Suse L3 Support

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
author maintainer
#2 lore raw
In reply to Guenter Roeck
Quoted 27 lines · Jean Delvare
Quoted 26 lines · Guenter Roeck

Since sysfs attributes are not attached to the hwmon device, it makes sense to associate log messages with the hwmon device as well.

---
  drivers/hwmon/ltc4245.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/ltc4245.c +1 -1
index 2c6da5d..0a3eddb 100644
@@ -95,7 +95,7 @@ static void ltc4245_update_gpios(struct device *dev)
  	 * readings as stale by setting them to -EAGAIN
  	 */
  	if (time_after(jiffies, data->last_updated + 5 * HZ)) {
-		dev_dbg(&client->dev, "Marking GPIOs invalid\n");
+		dev_dbg(dev, "Marking GPIOs invalid\n");
  		for (i = 0; i < ARRAY_SIZE(data->gpios); i++)
  			data->gpios[i] = -EAGAIN;
  	}
@@ -141,7 +141,7 @@ static struct ltc4245_data *ltc4245_update_device(struct device *dev)
 
  	if (time_after(jiffies, data->last_updated + HZ) || !data->valid) {
 
Quoted 9 lines

drivers/hwmon/ltc4245.c static struct ltc4245_data *ltc4245_update_device(struct device *dev) · line 147

Quoted 5 lines
drivers/hwmon/ltc4245.c +1 -1
-		dev_dbg(&client->dev, "Starting ltc4245 update\n");
+		dev_dbg(dev, "Starting ltc4245 update\n");
 
  		/* Read control registers -- 0x00 to 0x07 */
  		for (i = 0; i < ARRAY_SIZE(data->cregs); i++) {

Both debug messages are quite pointless IMHO and I'd rather delete them than update them.

Ok, I'll do that.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors