Skip to contentSkip to conversation

xen: remove XEN_PRIVILEGED_GUEST

PATCH New Paul Bolle 1 participant 1 message Feb 16, 2014

Subsystems (2)
lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 xen: remove XEN_PRIVILEGED_GUEST

This patch removes the Kconfig symbol XEN_PRIVILEGED_GUEST which is used nowhere in the tree. We do know grub2 has a script that greps kernel configuration files for this symbol. It shouldn't do that. As Linus summarized:
This is a grub bug. It really is that simple. Treat it as one.

So there's no reason to not remove it, like we do with all unused Kconfig symbols.

[[email protected]: rewrote commit explanation.]

---
Tested with "git grep".

Michael's version can be found at https://lkml.org/lkml/2013/7/8/34 . (This is the same patch, with a rewritten explanation, and my S-o-b line.) The question whether this symbol can be removed was further discussed in https://lkml.org/lkml/2013/7/15/308 .

I don't think a bug was ever filed against grub2 regarding its way to check for Xen support. Should that be done first?

 arch/x86/xen/Kconfig | 5 -----
 1 file changed, 5 deletions(-)
arch/x86/xen/Kconfig +0 -5
index 01b9026..512219d 100644
@@ -19,11 +19,6 @@ config XEN_DOM0
 	depends on XEN && PCI_XEN && SWIOTLB_XEN
 	depends on X86_LOCAL_APIC && X86_IO_APIC && ACPI && PCI
 
-# Dummy symbol since people have come to rely on the PRIVILEGED_GUEST
-# name in tools.
-config XEN_PRIVILEGED_GUEST
-	def_bool XEN_DOM0
-
 config XEN_PVHVM
 	def_bool y
 	depends on XEN && PCI && X86_LOCAL_APIC
Signature · 1 line
1.8.5.3