Bluetooth: Restrict long term keys to public and static addresses
Subsystems (2)
Marcel Holtmann
maintainerPATCH 1/2 Bluetooth: Restrict long term keys to public and static addresses
The long term keys should be associated with an identity address. Valid identity addresses are public addresses or static addresses. So only allow these two as valid address information for long term keys.
Signed-off-by Marcel Holtmann <[email protected]>
--- net/bluetooth/mgmt.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
net/bluetooth/mgmt.c +13 -3
@@ -4162,9 +4162,19 @@ static bool ltk_is_valid(struct mgmt_ltk_info *key) {if (key->master !=0x00 && key->master !=0x01 )return false; -if (!bdaddr_type_is_le (key->addr.type)) -return false; -return true; + +switch (key->addr.type) { +case BDADDR_LE_PUBLIC : +return true; + +case BDADDR_LE_RANDOM : +/* Two most significant bits shall be set */ +if ((key->addr.bdaddr.b[5 ] &0xc0 ) !=0xc0 ) +return false; +return true; + } + +return false; } static int load_long_term_keys(struct sock *sk, struct hci_dev *hdev,
Signature · 1 line
1.8.5.3
Hi Marcel,
Quoted 8 lines · Marcel Holtmann
The long term keys should be associated with an identity address. Valid identity addresses are public addresses or static addresses. So only allow these two as valid address information for long term keys.
Signed-off-by Marcel Holtmann <[email protected]>--- net/bluetooth/mgmt.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
Both patches have been applied to bluetooth-next. Thanks.
Johan