Skip to contentSkip to conversation

netlink_linearize: fix wrong comparison in netlink_gen_flagcmp()

PATCH In review Pablo Neira Ayuso 2 participants 4 messages Feb 16, 2014 – Feb 17, 2014 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 netlink_linearize: fix wrong comparison in netlink_gen_flagcmp()

nft add rule filter input ct state established,related counter drop

is not matching here due to a wrong comparison in the rule:

ip filter input 20 19
[ ct load state => reg 1 ]
[ bitwise reg 1 = (reg=1 & 0x00000006 ) ^ 0x00000000 ] [ cmp neq reg 1 0x00000006 ] <----- this has to be zero [ counter pkts 0 bytes 0 ]
[ immediate reg 0 drop ]

There's a line that generates the value from the right-hand expression which was not in the original code. This bug was introduced in aae836a ("src: use libnftables").

---
 src/netlink_linearize.c |    1 -
 1 file changed, 1 deletion(-)
src/netlink_linearize.c +0 -1
index 332383a..3e9a078 100644
@@ -285,7 +285,6 @@ static void netlink_gen_flagcmp(struct netlink_linearize_ctx *ctx,
 	netlink_gen_raw_data(zero, expr->right->byteorder, len, &nld);
 	nft_rule_expr_set_u32(nle, NFT_EXPR_CMP_SREG, sreg);
 	nft_rule_expr_set_u32(nle, NFT_EXPR_CMP_OP, NFT_CMP_NEQ);
-	netlink_gen_data(expr->right, &nld);
 	nft_rule_expr_set(nle, NFT_EXPR_CMP_DATA, nld.value, nld.len);
 	nft_rule_add_expr(ctx->nlr, nle);
 
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 11 lines · Pablo Neira Ayuso

nft add rule filter input ct state established,related counter drop

is not matching here due to a wrong comparison in the rule:

ip filter input 20 19
[ ct load state => reg 1 ]
[ bitwise reg 1 = (reg=1 & 0x00000006 ) ^ 0x00000000 ] [ cmp neq reg 1 0x00000006 ] <----- this has to be zero [ counter pkts 0 bytes 0 ]
[ immediate reg 0 drop ]

Quoted 3 lines

There's a line that generates the value from the right-hand expression which was not in the original code. This bug was introduced in aae836a ("src: use libnftables").

I already pushed that patch two or three hours ago.

author maintainer
#2 lore raw
Quoted 12 lines · Patrick McHardy
Quoted 11 lines · Pablo Neira Ayuso

nft add rule filter input ct state established,related counter drop

is not matching here due to a wrong comparison in the rule:

ip filter input 20 19
[ ct load state => reg 1 ]
[ bitwise reg 1 = (reg=1 & 0x00000006 ) ^ 0x00000000 ] [ cmp neq reg 1 0x00000006 ] <----- this has to be zero [ counter pkts 0 bytes 0 ]
[ immediate reg 0 drop ]

Quoted 5 lines
Quoted 3 lines

There's a line that generates the value from the right-hand expression which was not in the original code. This bug was introduced in aae836a ("src: use libnftables").

I already pushed that patch two or three hours ago.

Thanks Patrick. I noticed this when testing state established,related. Please, send your patches to nf-devel next time, I would have noticed and saved that time.

#3 lore raw
Quoted 17 lines · Pablo Neira Ayuso
Quoted 16 lines · Patrick McHardy
Quoted 14 lines · Pablo Neira Ayuso

nft add rule filter input ct state established,related counter drop

is not matching here due to a wrong comparison in the rule:

ip filter input 20 19
[ ct load state => reg 1 ]
[ bitwise reg 1 = (reg=1 & 0x00000006 ) ^ 0x00000000 ] [ cmp neq reg 1 0x00000006 ] <----- this has to be zero [ counter pkts 0 bytes 0 ]
[ immediate reg 0 drop ]

There's a line that generates the value from the right-hand expression which was not in the original code. This bug was introduced in aae836a ("src: use libnftables").

Quoted 5 lines
Quoted 1 line

I already pushed that patch two or three hours ago.

Thanks Patrick. I noticed this when testing state established,related. Please, send your patches to nf-devel next time, I would have noticed and saved that time.

I actually did, but it was burried inside a thread with Florian. Some related patches coming up soon ...