Skip to contentSkip to conversation

IA64, sba_iommu: fix section mismatch

PATCH Superseded Jiang Liu 2 participants 4 messages Feb 17, 2014

lore
Share & tools
lore

Jiang Liu

author
#0 lore raw

PATCH 1/1 IA64, sba_iommu: fix section mismatch

Fix the section mismatch warning by remove __init annotate for function acpi_sba_ioc_add() because it may be called at runtime.

WARNING: vmlinux.o(.data+0x66ee0): Section mismatch in reference from the variable acpi_sba_ioc_handler to the function .init.text:acpi_sba_ioc_add() The variable acpi_sba_ioc_handler references
the function __init acpi_sba_ioc_add()

---
 arch/ia64/hp/common/sba_iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/hp/common/sba_iommu.c +1 -1
index 8e858b5..c9d6f0b 100644
@@ -2041,7 +2041,7 @@ sba_map_ioc_to_node(struct ioc *ioc, acpi_handle handle)
 #define sba_map_ioc_to_node(ioc, handle)
 #endif
 
-static int __init
+static int
 acpi_sba_ioc_add(struct acpi_device *device,
 		 const struct acpi_device_id *not_used)
 {
Signature · 1 line
1.7.10.4
#1 lore raw

arch/ia64/hp/common/sba_iommu.c sba_map_ioc_to_node(struct ioc *ioc, acpi_handle handle) · line 2047

Quoted 6 lines
arch/ia64/hp/common/sba_iommu.c +1 -1
-static int __init
+static int
 acpi_sba_ioc_add(struct acpi_device *device,
 		 const struct acpi_device_id *not_used)
 {

Hi Gerry,
ioc_init() and sba_map_ioc_to_node() in this function seems also have the __init annotate.

Signature · 2 lines
Thanks!
Yijing
author
#2 lore raw

Thanks for reminder, will send out v2.

Quoted 11 lines · Yijing Wang

arch/ia64/hp/common/sba_iommu.c sba_map_ioc_to_node(struct ioc *ioc, acpi_handle handle) · line 2047

Quoted 6 lines
arch/ia64/hp/common/sba_iommu.c +1 -1
-static int __init
+static int
 acpi_sba_ioc_add(struct acpi_device *device,
 		 const struct acpi_device_id *not_used)
 {

Hi Gerry,
ioc_init() and sba_map_ioc_to_node() in this function seems also have the __init annotate.

author
#3 lore raw

PATCH v2 1/1 IA64, sba_iommu: fix section mismatch

In reply to Jiang Liu

Fix the section mismatch warning by remove __init annotate for function acpi_sba_ioc_add() because it may be called at runtime.

WARNING: vmlinux.o(.data+0x66ee0): Section mismatch in reference from the variable acpi_sba_ioc_handler to the function .init.text:acpi_sba_ioc_add() The variable acpi_sba_ioc_handler references
the function __init acpi_sba_ioc_add()

---
 arch/ia64/hp/common/sba_iommu.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/ia64/hp/common/sba_iommu.c +3 -3
index 8e858b5..30c43d3 100644
@@ -1596,7 +1596,7 @@ static void sba_unmap_sg_attrs(struct device *dev, struct scatterlist *sglist,
 *
 ***************************************************************/
 
-static void __init
+static void
 ioc_iova_init(struct ioc *ioc)
 {
 	int tcnfg;
@@ -1807,7 +1807,7 @@ static struct ioc_iommu ioc_iommu_info[] __initdata = {
 	{ SX2000_IOC_ID, "sx2000", NULL },
 };
 
-static struct ioc * __init
+static struct ioc *
 ioc_init(unsigned long hpa, void *handle)
 {
 	struct ioc *ioc;
@@ -2041,7 +2041,7 @@ sba_map_ioc_to_node(struct ioc *ioc, acpi_handle handle)
 #define sba_map_ioc_to_node(ioc, handle)
 #endif
 
-static int __init
+static int
 acpi_sba_ioc_add(struct acpi_device *device,
 		 const struct acpi_device_id *not_used)
 {
Signature · 1 line
1.7.10.4