Skip to contentSkip to conversation

src: proto: fixed a rreply symbol

PATCH Applied Ana Rey 2 participants 2 messages Feb 17, 2014 netfilter

lore
Share & tools
lore

Ana Rey

author
#0 lore raw

PATCH 1/1 src: proto: fixed a rreply symbol

There is a bug with rreply symbol. The rreply and reply symbol were the same.

There is a reproduction of this bug here:

$ sudo nft add rule arp art-t filter arp operation reply
$ sudo nft list table arp art-t
table arp art-t {
        chain filter {
                 type filter hook input priority 0;
                 arp operation 512
        }
}
$ sudo nft add rule arp art-t filter arp operation rreply
$ sudo nft list table arp art-t
table arp art-t {
        chain filter {
                 type filter hook input priority 0;
                 arp operation 512  <=====
                 arp operation 512  <=====
        }
}
 src/proto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/proto.c +1 -1
index cc073af..3e62f92 100644
@@ -661,7 +661,7 @@ static const struct symbol_table arpop_tbl = {
 		SYMBOL("request",	ARPOP_REQUEST),
 		SYMBOL("reply",		ARPOP_REPLY),
 		SYMBOL("rrequest",	ARPOP_RREQUEST),
-		SYMBOL("rreply",	ARPOP_REPLY),
+		SYMBOL("rreply",	ARPOP_RREPLY),
 		SYMBOL("inrequest",	ARPOP_InREQUEST),
 		SYMBOL("inreply",	ARPOP_InREPLY),
 		SYMBOL("nak",		ARPOP_NAK),
Signature · 1 line
1.8.5.3
#1 lore raw
Quoted 12 lines · Ana Rey

There is a bug with rreply symbol. The rreply and reply symbol were the same.

There is a reproduction of this bug here:

$ sudo nft add rule arp art-t filter arp operation reply
$ sudo nft list table arp art-t
table arp art-t {
        chain filter {
                 type filter hook input priority 0;
                 arp operation 512
        }
}
Quoted 9 lines
$ sudo nft add rule arp art-t filter arp operation rreply
$ sudo nft list table arp art-t
table arp art-t {
        chain filter {
                 type filter hook input priority 0;
                 arp operation 512  <=====
                 arp operation 512  <=====
        }
}

Applied, thanks.

Please remember to sign off your patches next time.

Quoted 24 lines
 src/proto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/proto.c +1 -1
index cc073af..3e62f92 100644
@@ -661,7 +661,7 @@ static const struct symbol_table arpop_tbl = {
 		SYMBOL("request",	ARPOP_REQUEST),
 		SYMBOL("reply",		ARPOP_REPLY),
 		SYMBOL("rrequest",	ARPOP_RREQUEST),
-		SYMBOL("rreply",	ARPOP_REPLY),
+		SYMBOL("rreply",	ARPOP_RREPLY),
 		SYMBOL("inrequest",	ARPOP_InREQUEST),
 		SYMBOL("inreply",	ARPOP_InREPLY),
 		SYMBOL("nak",		ARPOP_NAK),
Signature · 6 lines
1.8.5.3

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html