acpi: Remove Kconfig symbol ACPI_PROCFS
PATCH 1/1 acpi: Remove Kconfig symbol ACPI_PROCFS
Nothing cares about ACPI_PROCFS. This has been the case since v2.6.38. This Kconfig symbol serves no purpose and its help text is now misleading. It can safely be removed. If this symbol would be needed again in the future it can be readded in a commit that adds code that actually uses it.
---
Tested with "git grep" only.
Michael Opdenacker did a previous attempt in
https://lkml.org/lkml/2013/10/27/15 . That patch that needed some context changes, so I redid it. I also wrote a new commit explanation. It also addresses the reasons not to accept Michael's patch.
drivers/acpi/Kconfig | 13 ------------- 1 file changed, 13 deletions(-)
drivers/acpi/Kconfig +0 -13
@@ -43,19 +43,6 @@ config ACPI_SLEEP depends on SUSPEND || HIBERNATION default y -config ACPI_PROCFS - bool "Deprecated /proc/acpi files" - depends on PROC_FS - help - For backwards compatibility, this option allows - deprecated /proc/acpi/ files to exist, even when - they have been replaced by functions in /sys. - - This option has no effect on /proc/acpi/ files - and functions which do not yet exist in /sys. - - Say N to delete /proc/acpi/ files that have moved to /sys/ - config ACPI_EC_DEBUGFS tristate "EC read/write access through /sys/kernel/debug/ec" default n
Signature · 1 line
1.8.5.3
Quoted 1 line · Paul Bolle
Nothing cares about
ACPI_PROCFS.
Some defconfigs set it. Care to remove it from them too?
Quoted 43 lines
This has been the case since v2.6.38.
ThisKconfigsymbol serves no purpose and its help text is now misleading. It can safely be removed. If this symbol would be needed again in the future it can be readded in a commit that adds code that actually uses it.Signed-off-by Paul Bolle <[email protected]>---
Tested with "git grep" only.Michael Opdenacker did a previous attempt in
https://lkml.org/lkml/2013/10/27/15 . That patch that needed some context changes, so I redid it. I also wrote a new commit explanation. It also addresses the reasons not to accept Michael's patch.drivers/acpi/Kconfig | 13 ------------- 1 file changed, 13 deletions(-)drivers/acpi/Kconfig +0
-13@@ -43,19 +43,6 @@ config ACPI_SLEEP depends on SUSPEND || HIBERNATION default y -config ACPI_PROCFS - bool "Deprecated /proc/acpi files" - depends on PROC_FS - help - For backwards compatibility, this option allows - deprecated /proc/acpi/ files to exist, even when - they have been replaced by functions in /sys. - - This option has no effect on /proc/acpi/ files - and functions which do not yet exist in /sys. - - Say N to delete /proc/acpi/ files that have moved to /sys/ - config ACPI_EC_DEBUGFS tristate "EC read/write access through /sys/kernel/debug/ec" default n
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
Quoted 1 line · Rafael J. Wysocki
Some defconfigs set it. Care to remove it from them too?
As in: send a v2 which also strips it from those defconfigs? Fine with me.
(Side note: I've learned to ignore the defconfigs. They have accumulated a lot of cruft. I once sent a pull request to clean all defconfigs. It was ignored and I was rather fed up with doing trying to clean up defconfigs, so I never sent out an updated pull request.)
Paul Bolle
PATCH v2 1/1 acpi: Remove Kconfig symbol ACPI_PROCFS
Nothing cares about ACPI_PROCFS. This has been the case since v2.6.38. This Kconfig symbol serves no purpose and its help text is now misleading. It can safely be removed. If this symbol would be needed again in the future it can be readded in a commit that adds code that actually uses it.
---
v2: clean up defconfigs too, as Rafael suggested. Still tested with "git grep" only.
arch/ia64/configs/generic_defconfig | 1 - arch/ia64/configs/tiger_defconfig | 1 - arch/ia64/configs/zx1_defconfig | 1 - arch/x86/configs/i386_defconfig | 1 - arch/x86/configs/x86_64_defconfig | 1 - drivers/acpi/Kconfig | 13 ------------- 6 files changed, 18 deletions(-)
arch/ia64/configs/generic_defconfig +0 -1
@@ -25,7 +25,6 @@ CONFIG_KEXEC=y CONFIG_CRASH_DUMP=y CONFIG_EFI_VARS=y CONFIG_BINFMT_MISC=m -CONFIG_ACPI_PROCFS=y CONFIG_ACPI_BUTTON=m CONFIG_ACPI_FAN=m CONFIG_ACPI_DOCK=y
arch/ia64/configs/tiger_defconfig +0 -1
@@ -26,7 +26,6 @@ CONFIG_IA64_PALINFO=y CONFIG_KEXEC=y CONFIG_EFI_VARS=y CONFIG_BINFMT_MISC=m -CONFIG_ACPI_PROCFS=y CONFIG_ACPI_BUTTON=m CONFIG_ACPI_FAN=m CONFIG_ACPI_PROCESSOR=m
arch/ia64/configs/zx1_defconfig +0 -1
@@ -16,7 +16,6 @@ CONFIG_IA64_PALINFO=y CONFIG_CRASH_DUMP=y CONFIG_EFI_VARS=y CONFIG_BINFMT_MISC=y -CONFIG_ACPI_PROCFS=y CONFIG_HOTPLUG_PCI=y CONFIG_HOTPLUG_PCI_ACPI=y CONFIG_PACKET=y
arch/x86/configs/i386_defconfig +0 -1
@@ -60,7 +60,6 @@ CONFIG_CRASH_DUMP=y CONFIG_HIBERNATION=y CONFIG_PM_DEBUG=y CONFIG_PM_TRACE_RTC=y -CONFIG_ACPI_PROCFS=y CONFIG_ACPI_DOCK=y CONFIG_CPU_FREQ=y # CONFIG_CPU_FREQ_STAT is not set
arch/x86/configs/x86_64_defconfig +0 -1
@@ -58,7 +58,6 @@ CONFIG_CRASH_DUMP=y CONFIG_HIBERNATION=y CONFIG_PM_DEBUG=y CONFIG_PM_TRACE_RTC=y -CONFIG_ACPI_PROCFS=y CONFIG_ACPI_DOCK=y CONFIG_CPU_FREQ=y # CONFIG_CPU_FREQ_STAT is not set
drivers/acpi/Kconfig +0 -13
@@ -43,19 +43,6 @@ config ACPI_SLEEP depends on SUSPEND || HIBERNATION default y -config ACPI_PROCFS - bool "Deprecated /proc/acpi files" - depends on PROC_FS - help - For backwards compatibility, this option allows - deprecated /proc/acpi/ files to exist, even when - they have been replaced by functions in /sys. - - This option has no effect on /proc/acpi/ files - and functions which do not yet exist in /sys. - - Say N to delete /proc/acpi/ files that have moved to /sys/ - config ACPI_EC_DEBUGFS tristate "EC read/write access through /sys/kernel/debug/ec" default n
Signature · 1 line
1.8.5.3